From: Matan Azrad <matan@mellanox.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"keith.wiles@intel.com" <keith.wiles@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal: add API to align integer to previous power of 2
Date: Tue, 27 Feb 2018 19:30:40 +0000 [thread overview]
Message-ID: <AM4PR0501MB2657D0F68F4FFB3E9172DAB1D2C00@AM4PR0501MB2657.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180226191017.GA9950@ltp-pvn>
Hi Pavan
From: Pavan Nikhilesh, Monday, February 26, 2018 9:10 PM
> Hi Matan,
>
> On Mon, Feb 19, 2018 at 12:09:46PM +0000, Matan Azrad wrote:
> > Since you are using the same 5 lines from the rte_align32pow2() function, I
>> think this part can be in a separate function to do reuse.
> > Also the "fill ones 32" function can be used for other purpose.
> > What do you think?
>
> I do agree that it would be cleaner to have a common function for both, but
> not able to decide on a appropriate function name "fill ones 32" doesn't
> convey what the function truly does. If you have a cleaner name do suggest, i
> will roll up a v3 adding the function and experimental tag.
Sure.
I'm suggesting next names:
rte_combine32ms1b(register uint32_t x)
rte_combine64ms1b(register uint64_t x)
The description may be something like:
combine the upper bits into the LSBs to construct a value with the same most significant 1 as x but all 1's under it.
I would add the register keyword for each variables in all the align functions here just to hint for the compiler that it's better to save this variables in register and not in memory.
Matan.
> Thanks,
> Pavan
>
> >
> >
next prev parent reply other threads:[~2018-02-27 19:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 10:49 [dpdk-dev] [PATCH " Pavan Nikhilesh
2018-02-17 10:49 ` [dpdk-dev] [PATCH 2/2] test: update common auto test Pavan Nikhilesh
2018-02-18 6:11 ` [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2 Matan Azrad
2018-02-18 15:39 ` Wiles, Keith
2018-02-19 6:03 ` Matan Azrad
2018-02-19 13:55 ` Wiles, Keith
2018-02-19 14:13 ` Matan Azrad
2018-02-19 14:21 ` Wiles, Keith
2018-02-19 16:18 ` Thomas Monjalon
2018-02-19 8:36 ` Pavan Nikhilesh
2018-02-19 11:36 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2018-02-19 11:36 ` [dpdk-dev] [PATCH v2 2/2] test: update common auto test Pavan Nikhilesh
2018-02-19 12:09 ` [dpdk-dev] [PATCH v2 1/2] eal: add API to align integer to previous power of 2 Matan Azrad
2018-02-26 19:10 ` Pavan Nikhilesh
2018-02-27 19:30 ` Matan Azrad [this message]
2018-04-04 10:16 ` [dpdk-dev] [PATCH v3 " Pavan Nikhilesh
2018-04-04 10:16 ` [dpdk-dev] [PATCH v3 2/2] test: update common auto test Pavan Nikhilesh
2018-04-04 12:49 ` Thomas Monjalon
2018-04-04 12:54 ` Pavan Nikhilesh
2018-04-04 16:10 ` [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2 Matan Azrad
2018-04-04 16:42 ` Pavan Nikhilesh
2018-04-04 17:11 ` Matan Azrad
2018-04-04 17:51 ` Pavan Nikhilesh
2018-04-04 18:10 ` Matan Azrad
2018-04-04 18:15 ` Pavan Nikhilesh
2018-04-04 18:23 ` Matan Azrad
2018-04-04 18:36 ` Pavan Nikhilesh
2018-04-04 19:41 ` Matan Azrad
2018-04-04 13:20 ` [dpdk-dev] [PATCH v4] " Pavan Nikhilesh
2018-04-04 15:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR0501MB2657D0F68F4FFB3E9172DAB1D2C00@AM4PR0501MB2657.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=keith.wiles@intel.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).