From: Feifei Wang <Feifei.Wang2@arm.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: David Hunt <david.hunt@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"thomas@monjalon.net" <thomas@monjalon.net>, nd <nd@arm.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>, nd <nd@arm.com>
Subject: 回复: [PATCH v2 3/3] examples/l3fwd-power: enable PMD power monitor on Arm
Date: Tue, 8 Nov 2022 03:25:40 +0000 [thread overview]
Message-ID: <AS8PR08MB77182577E77D0F8AE9B29797C83F9@AS8PR08MB7718.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20221107080144.34cdde78@hermes.local>
Hi, Stephen
> -----邮件原件-----
> 发件人: Stephen Hemminger <stephen@networkplumber.org>
> 发送时间: Tuesday, November 8, 2022 12:02 AM
> 收件人: Feifei Wang <Feifei.Wang2@arm.com>
> 抄送: David Hunt <david.hunt@intel.com>; dev@dpdk.org;
> david.marchand@redhat.com; thomas@monjalon.net; nd <nd@arm.com>;
> Ruifeng Wang <Ruifeng.Wang@arm.com>
> 主题: Re: [PATCH v2 3/3] examples/l3fwd-power: enable PMD power
> monitor on Arm
>
> On Mon, 7 Nov 2022 15:04:49 +0800
> Feifei Wang <feifei.wang2@arm.com> wrote:
>
> > + /* Ensure the main lcore does not enter the
> power-monitor state,
> > + * so that it can be used to wake up other
> lcores on ARM.
> > + * This is due to WFE instruction has no
> timeout wake-up mechanism,
> > + * and if users want to exit actively, the main
> lcore is needed
> > + * to send SEV instruction to wake up other
> lcores.
> > + */
> > + unsigned int main_lcore =
> rte_get_main_lcore();
>
> This can be done in a simpler an cleaner manner with a continue statement
> earlier in the loop.
>
> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
> index fd3ade330f82..115535fd4cd7 100644
> --- a/examples/l3fwd-power/main.c
> +++ b/examples/l3fwd-power/main.c
> @@ -2984,6 +2984,16 @@ main(int argc, char **argv)
> }
>
> if (app_mode == APP_MODE_PMD_MGMT
> && !baseline_enabled) {
> +#ifdef RTE_ARCH_ARM64
> + /* Ensure the main lcore does not enter the
> power-monitor state,
> + * so that it can be used to wake up other
> lcores on ARM.
> + * This is due to WFE instruction has no
> timeout wake-up mechanism,
> + * and if users want to exit actively, the main
> lcore is needed
> + * to send SEV instruction to wake up other
> lcors.
> + */
> + if (lcore_id == rte_get_main_lcore())
> + continue;
> +#endif
> /* Set power_pmd_mgmt configs passed by
> user */
>
> rte_power_pmd_mgmt_set_emptypoll_max(max_empty_polls);
> ret =
> rte_power_pmd_mgmt_set_pause_duration(pause_duration);
Thanks for the comment.
There maybe some problems for this change. This is due to that we just want to disable power monitor
feature on the main core when "app_mode == APP_MODE_PMD_MGMT && pmgmt_type == RTE_POWER_MGMT_TYPE_MONITOR".
When “pmgmt_type == RTE_POWER_MGMT_TYPE_PAUSE || pmgmt_type == RTE_POWER_MGMT_TYPE_SCALE", main core
power management mode can be enabled.
Best Regards
Feifei
next prev parent reply other threads:[~2022-11-08 3:26 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 6:42 [PATCH v1 0/3] Enable PMD power management " Feifei Wang
2022-08-25 6:42 ` [PATCH v1 1/3] eal: add 8 bits case for wait scheme Feifei Wang
2022-08-25 6:42 ` [PATCH v1 2/3] eal: add power mgmt support on Arm Feifei Wang
2022-08-25 6:42 ` [PATCH v1 3/3] examples/l3fwd-power: enable PMD power mgmt " Feifei Wang
2022-08-29 12:48 ` Hunt, David
2022-10-03 7:12 ` David Marchand
2022-10-11 7:56 ` 回复: " Feifei Wang
2022-10-20 20:41 ` Thomas Monjalon
2022-10-27 9:38 ` 回复: " Feifei Wang
2022-10-20 22:09 ` Stephen Hemminger
2022-10-27 9:43 ` 回复: " Feifei Wang
2022-11-07 7:04 ` [PATCH v2 0/3] Enable PMD power management " Feifei Wang
2022-11-07 7:04 ` [PATCH v2 1/3] eal: add 8 bits case for wait scheme Feifei Wang
2022-11-07 7:04 ` [PATCH v2 2/3] eal: add power mgmt support on Arm Feifei Wang
2022-11-07 7:04 ` [PATCH v2 3/3] examples/l3fwd-power: enable PMD power monitor " Feifei Wang
2022-11-07 16:01 ` Stephen Hemminger
2022-11-08 3:25 ` Feifei Wang [this message]
2022-11-11 7:26 ` [PATCH v3 0/3] Enable PMD power management " Feifei Wang
2022-11-11 7:26 ` [PATCH v3 1/3] eal: add 8 bits case for wait scheme Feifei Wang
2022-11-11 7:26 ` [PATCH v3 2/3] eal: add power mgmt support on Arm Feifei Wang
2022-11-11 7:26 ` [PATCH v3 3/3] examples/l3fwd-power: enable PMD power monitor " Feifei Wang
2022-11-11 8:22 ` Thomas Monjalon
2022-11-11 10:21 ` 回复: " Feifei Wang
2022-11-11 10:20 ` [PATCH v4 0/4] Enable PMD power management " Feifei Wang
2022-11-11 10:20 ` [PATCH v4 1/4] eal: add 8 bits case for wait scheme Feifei Wang
2022-11-11 10:20 ` [PATCH v4 2/4] eal: add power mgmt support on Arm Feifei Wang
2022-11-11 10:20 ` [PATCH v4 3/4] power: add power monitor support check Feifei Wang
2022-11-11 10:20 ` [PATCH v4 4/4] examples/l3fwd-power: add power monitor wake up API Feifei Wang
2022-12-14 8:14 ` [PATCH v5 0/2] Enable PMD power management on Arm Feifei Wang
2022-12-14 8:14 ` [PATCH v5 1/2] eal: add 8 bits case for wait scheme Feifei Wang
2022-12-14 8:14 ` [PATCH v5 2/2] eal: add power mgmt support on Arm Feifei Wang
2023-02-17 16:23 ` Stephen Hemminger
2023-02-20 1:56 ` 回复: " Feifei Wang
2023-02-17 8:26 ` 回复: [PATCH v5 0/2] Enable PMD power management " Feifei Wang
2023-02-20 8:51 ` [PATCH v6 " Feifei Wang
2023-02-20 8:51 ` [PATCH v6 1/2] eal: add 8 bits case for wait scheme Feifei Wang
2023-02-20 8:51 ` [PATCH v6 2/2] eal: add power mgmt support on Arm Feifei Wang
2023-02-20 12:07 ` [PATCH v6 0/2] Enable PMD power management " David Marchand
2023-02-21 2:37 ` 回复: " Feifei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR08MB77182577E77D0F8AE9B29797C83F9@AS8PR08MB7718.eurprd08.prod.outlook.com \
--to=feifei.wang2@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).