From: Feifei Wang <Feifei.Wang2@arm.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Ruifeng Wang <Ruifeng.Wang@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
David Hunt <david.hunt@intel.com>, nd <nd@arm.com>
Subject: 回复: [PATCH v5 2/2] eal: add power mgmt support on Arm
Date: Mon, 20 Feb 2023 01:56:02 +0000 [thread overview]
Message-ID: <AS8PR08MB7718E836E420C69FE1EA1570C8A49@AS8PR08MB7718.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20230217082301.644addae@hermes.local>
> -----邮件原件-----
> 发件人: Stephen Hemminger <stephen@networkplumber.org>
> 发送时间: Saturday, February 18, 2023 12:23 AM
> 收件人: Feifei Wang <Feifei.Wang2@arm.com>
> 抄送: Ruifeng Wang <Ruifeng.Wang@arm.com>; dev@dpdk.org; nd
> <nd@arm.com>; David Hunt <david.hunt@intel.com>
> 主题: Re: [PATCH v5 2/2] eal: add power mgmt support on Arm
>
> On Wed, 14 Dec 2022 16:14:30 +0800
> Feifei Wang <feifei.wang2@arm.com> wrote:
>
> > +__check_val_size(const uint8_t sz)
> > +{
> > + switch (sz) {
> > + case sizeof(uint8_t): /* fall-through */
> > + case sizeof(uint16_t): /* fall-through */
> > + case sizeof(uint32_t): /* fall-through */
> > + case sizeof(uint64_t): /* fall-through */
> > + return 0;
> > + default:
> > + /* unexpected size */
> > + return -1;
> > + }
> > +}
> > +#endif
>
> One simplification would be to get rid of this function and just check for
> unexpected size in the switch statement in rte_power_monitor().
Thanks for the comments.
__check_val_size API is following intel path. And agree with your comments,
for arm path, it is unnecessary.
Thus I will delete __check_val_size and simplify the code.
Best Regards
Feifei
>
> > + switch (pmc->size) {
> > + case sizeof(uint8_t):
> > + __RTE_ARM_LOAD_EXC_8(pmc->addr, cur_value,
> __ATOMIC_RELAXED);
> > + __RTE_ARM_WFE()
> > + break;
> > + case sizeof(uint16_t):
> > + __RTE_ARM_LOAD_EXC_16(pmc->addr, cur_value,
> __ATOMIC_RELAXED);
> > + __RTE_ARM_WFE()
> > + break;
> > + case sizeof(uint32_t):
> > + __RTE_ARM_LOAD_EXC_32(pmc->addr, cur_value,
> __ATOMIC_RELAXED);
> > + __RTE_ARM_WFE()
> > + break;
> > + case sizeof(uint64_t):
> > + __RTE_ARM_LOAD_EXC_64(pmc->addr, cur_value,
> __ATOMIC_RELAXED);
> > + __RTE_ARM_WFE()
>
> default:
> return -1; /* unexpected size */
> > + }
next prev parent reply other threads:[~2023-02-20 1:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 6:42 [PATCH v1 0/3] Enable PMD power management " Feifei Wang
2022-08-25 6:42 ` [PATCH v1 1/3] eal: add 8 bits case for wait scheme Feifei Wang
2022-08-25 6:42 ` [PATCH v1 2/3] eal: add power mgmt support on Arm Feifei Wang
2022-08-25 6:42 ` [PATCH v1 3/3] examples/l3fwd-power: enable PMD power mgmt " Feifei Wang
2022-08-29 12:48 ` Hunt, David
2022-10-03 7:12 ` David Marchand
2022-10-11 7:56 ` 回复: " Feifei Wang
2022-10-20 20:41 ` Thomas Monjalon
2022-10-27 9:38 ` 回复: " Feifei Wang
2022-10-20 22:09 ` Stephen Hemminger
2022-10-27 9:43 ` 回复: " Feifei Wang
2022-11-07 7:04 ` [PATCH v2 0/3] Enable PMD power management " Feifei Wang
2022-11-07 7:04 ` [PATCH v2 1/3] eal: add 8 bits case for wait scheme Feifei Wang
2022-11-07 7:04 ` [PATCH v2 2/3] eal: add power mgmt support on Arm Feifei Wang
2022-11-07 7:04 ` [PATCH v2 3/3] examples/l3fwd-power: enable PMD power monitor " Feifei Wang
2022-11-07 16:01 ` Stephen Hemminger
2022-11-08 3:25 ` 回复: " Feifei Wang
2022-11-11 7:26 ` [PATCH v3 0/3] Enable PMD power management " Feifei Wang
2022-11-11 7:26 ` [PATCH v3 1/3] eal: add 8 bits case for wait scheme Feifei Wang
2022-11-11 7:26 ` [PATCH v3 2/3] eal: add power mgmt support on Arm Feifei Wang
2022-11-11 7:26 ` [PATCH v3 3/3] examples/l3fwd-power: enable PMD power monitor " Feifei Wang
2022-11-11 8:22 ` Thomas Monjalon
2022-11-11 10:21 ` 回复: " Feifei Wang
2022-11-11 10:20 ` [PATCH v4 0/4] Enable PMD power management " Feifei Wang
2022-11-11 10:20 ` [PATCH v4 1/4] eal: add 8 bits case for wait scheme Feifei Wang
2022-11-11 10:20 ` [PATCH v4 2/4] eal: add power mgmt support on Arm Feifei Wang
2022-11-11 10:20 ` [PATCH v4 3/4] power: add power monitor support check Feifei Wang
2022-11-11 10:20 ` [PATCH v4 4/4] examples/l3fwd-power: add power monitor wake up API Feifei Wang
2022-12-14 8:14 ` [PATCH v5 0/2] Enable PMD power management on Arm Feifei Wang
2022-12-14 8:14 ` [PATCH v5 1/2] eal: add 8 bits case for wait scheme Feifei Wang
2022-12-14 8:14 ` [PATCH v5 2/2] eal: add power mgmt support on Arm Feifei Wang
2023-02-17 16:23 ` Stephen Hemminger
2023-02-20 1:56 ` Feifei Wang [this message]
2023-02-17 8:26 ` 回复: [PATCH v5 0/2] Enable PMD power management " Feifei Wang
2023-02-20 8:51 ` [PATCH v6 " Feifei Wang
2023-02-20 8:51 ` [PATCH v6 1/2] eal: add 8 bits case for wait scheme Feifei Wang
2023-02-20 8:51 ` [PATCH v6 2/2] eal: add power mgmt support on Arm Feifei Wang
2023-02-20 12:07 ` [PATCH v6 0/2] Enable PMD power management " David Marchand
2023-02-21 2:37 ` 回复: " Feifei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR08MB7718E836E420C69FE1EA1570C8A49@AS8PR08MB7718.eurprd08.prod.outlook.com \
--to=feifei.wang2@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).