From: "Verma, Shally" <Shally.Verma@cavium.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Athreya, Narayana Prasad" <NarayanaPrasad.Athreya@cavium.com>,
"Challa, Mahipal" <Mahipal.Challa@cavium.com>,
"Gupta, Ashish" <Ashish.Gupta@cavium.com>,
"Sahu, Sunila" <Sunila.Sahu@cavium.com>
Subject: Re: [dpdk-dev] [PATCH v1 3/7] compress/octeontx: add xform and stream create support
Date: Wed, 20 Jun 2018 06:12:26 +0000 [thread overview]
Message-ID: <CY4PR0701MB3634112BE4B3640B38FA6AE9F0770@CY4PR0701MB3634.namprd07.prod.outlook.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8977F8D851B@IRSMSX108.ger.corp.intel.com>
>-----Original Message-----
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com]
>Sent: 20 June 2018 03:43
>To: Verma, Shally <Shally.Verma@cavium.com>
>Cc: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org; Athreya, Narayana Prasad <NarayanaPrasad.Athreya@cavium.com>;
>Challa, Mahipal <Mahipal.Challa@cavium.com>; Gupta, Ashish <Ashish.Gupta@cavium.com>; Sahu, Sunila
><Sunila.Sahu@cavium.com>
>Subject: RE: [PATCH v1 3/7] compress/octeontx: add xform and stream create support
>
>External Email
>
>> -----Original Message-----
>> From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
>> Sent: Tuesday, June 5, 2018 11:35 AM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> Cc: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org;
>> pathreya@caviumnetworks.com; mchalla@caviumnetworks.com; Ashish Gupta
>> <ashish.gupta@caviumnetworks.com>; Sunila Sahu
>> <sunila.sahu@caviumnetworks.com>
>> Subject: [PATCH v1 3/7] compress/octeontx: add xform and stream create
>> support
>>
>> implement private xform and stream create ops
>>
>> Signed-off-by: Ashish Gupta <ashish.gupta@caviumnetworks.com>
>> Signed-off-by: Shally Verma <shally.verma@caviumnetworks.com>
>> Signed-off-by: Sunila Sahu <sunila.sahu@caviumnetworks.com>
>> ---
>> drivers/compress/octeontx/zip_pmd.c | 138
>> ++++++++++++++++++++++++++++++++++++
>> drivers/compress/octeontx/zipvf.h | 29 ++++++++
>> 2 files changed, 167 insertions(+)
>>
>> diff --git a/drivers/compress/octeontx/zip_pmd.c
>> b/drivers/compress/octeontx/zip_pmd.c
>> index 3bb7f6896..349114626 100644
>> --- a/drivers/compress/octeontx/zip_pmd.c
>> +++ b/drivers/compress/octeontx/zip_pmd.c
>
>...
>
>> +static int
>> +zip_pmd_stream_create(struct rte_compressdev *dev,
>> + const struct rte_comp_xform *xform, void **stream) {
>> + int ret;
>> + struct zip_stream *strm;
>> +
>> + strm = rte_malloc(NULL,
>> + sizeof(struct zip_stream), 0);
>
>Should not this come from a mempool, as there is an option
>in the configuration for max number of sessions.
>
[Shally] We're using mempool for per-stream resources but not specifically for stream struct itself.
We, though, had thought about approach too but it turns out to be more feasible to keep it this way for now.
>
>> + ret = zip_set_stream_parameters(dev, xform, strm);
>> + if (ret < 0) {
>> + ZIP_PMD_ERR("failed configure xform parameters");
>> + rte_free(strm);
>> + return ret;
>> + }
>> + *stream = strm;
>> + return 0;
>> +}
>> +
>> +static int
>> +zip_pmd_stream_free(struct rte_compressdev *dev, void *stream) {
>> + struct zip_vf *vf = (struct zip_vf *) (dev->data->dev_private);
>> + struct zip_stream *z_stream;
>> +
>> + if (stream == NULL)
>> + return -1;
>> +
>> + z_stream = (struct zip_stream *)stream;
>> + rte_mempool_put_bulk(vf->zip_mp,
>> + (void *)&(z_stream->bufs[0]),
>> + MAX_BUFS_PER_STREAM);
>> +
>> + /* Zero out the whole structure */
>> + memset(stream, 0, sizeof(struct zip_stream));
>> + rte_free(stream);
>
>I was expecting this stream to be put back into a mempool,
>but anyway, there is no need to reset this structure if you are freeing the memory then.
>
Thanks for review.
Shally
next prev parent reply other threads:[~2018-06-20 6:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 10:35 [dpdk-dev] [PATCH v1 0/7] compress: add Octeontx ZIP compression PMD Shally Verma
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD support Shally Verma
2018-06-10 10:38 ` Jerin Jacob
2018-06-20 6:32 ` Verma, Shally
2018-06-19 22:15 ` De Lara Guarch, Pablo
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 2/7] compress/octeontx: add device setup PMD ops Shally Verma
2018-06-19 22:15 ` De Lara Guarch, Pablo
2018-06-20 6:04 ` Verma, Shally
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 3/7] compress/octeontx: add xform and stream create support Shally Verma
2018-06-19 22:13 ` De Lara Guarch, Pablo
2018-06-20 6:12 ` Verma, Shally [this message]
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 4/7] compress/octeontx: add ops enq deq apis Shally Verma
2018-06-19 22:18 ` De Lara Guarch, Pablo
2018-06-29 7:42 ` Verma, Shally
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 5/7] test: add octeontx zip PMD for compressdev tests Shally Verma
2018-06-19 22:18 ` De Lara Guarch, Pablo
2018-06-20 6:03 ` Verma, Shally
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 6/7] doc: add octeontx zip PMD documentation Shally Verma
2018-06-14 11:22 ` Kovacevic, Marko
2018-06-19 22:22 ` De Lara Guarch, Pablo
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 7/7] drivers/compress: add meson.build support Shally Verma
2018-06-19 22:30 ` De Lara Guarch, Pablo
2018-06-20 6:02 ` Verma, Shally
2018-06-20 7:25 ` De Lara Guarch, Pablo
2018-06-20 7:36 ` Verma, Shally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR0701MB3634112BE4B3640B38FA6AE9F0770@CY4PR0701MB3634.namprd07.prod.outlook.com \
--to=shally.verma@cavium.com \
--cc=Ashish.Gupta@cavium.com \
--cc=Mahipal.Challa@cavium.com \
--cc=NarayanaPrasad.Athreya@cavium.com \
--cc=Sunila.Sahu@cavium.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).