From: "Verma, Shally" <Shally.Verma@cavium.com>
To: "Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com>
Cc: "pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
"fiona.trahe@intel.com" <fiona.trahe@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Athreya, Narayana Prasad" <NarayanaPrasad.Athreya@cavium.com>,
"Challa, Mahipal" <Mahipal.Challa@cavium.com>,
"Gupta, Ashish" <Ashish.Gupta@cavium.com>,
"Sahu, Sunila" <Sunila.Sahu@cavium.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD support
Date: Wed, 20 Jun 2018 06:32:31 +0000 [thread overview]
Message-ID: <CY4PR0701MB36342A3A7144A08EB82164C5F0770@CY4PR0701MB3634.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20180610103838.GA5152@jerin>
Hi Jerin
>-----Original Message-----
>From: Jacob, Jerin
>Sent: 10 June 2018 16:09
>To: Verma, Shally <Shally.Verma@cavium.com>
>Cc: pablo.de.lara.guarch@intel.com; fiona.trahe@intel.com; dev@dpdk.org; Athreya, Narayana Prasad
><NarayanaPrasad.Athreya@cavium.com>; Challa, Mahipal <Mahipal.Challa@cavium.com>; Gupta, Ashish
><Ashish.Gupta@cavium.com>; Sahu, Sunila <Sunila.Sahu@cavium.com>
>Subject: Re: [dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD support
>
>-----Original Message-----
>> Date: Tue, 5 Jun 2018 16:05:07 +0530
>> From: Shally Verma <shally.verma@caviumnetworks.com>
>> To: pablo.de.lara.guarch@intel.com
>> CC: fiona.trahe@intel.com, dev@dpdk.org, pathreya@caviumnetworks.com,
>> mchalla@caviumnetworks.com, Ashish Gupta
>> <ashish.gupta@caviumnetworks.com>, Sunila Sahu
>> <sunila.sahu@caviumnetworks.com>
>> Subject: [dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD
>> support
>> X-Mailer: git-send-email 1.9.1
>>
>> Add octeontx zip pmd support in compressdev driver.
>> Add device probe and remove support.
>> Update makefile to build octeontx zip pmd
>>
>> Signed-off-by: Ashish Gupta <ashish.gupta@caviumnetworks.com>
>> Signed-off-by: Shally Verma <shally.verma@caviumnetworks.com>
>> Signed-off-by: Sunila Sahu <sunila.sahu@caviumnetworks.com>
>> ---
>> config/common_base | 6 +
>> drivers/compress/Makefile | 2 +-
>> drivers/compress/octeontx/Makefile | 33 ++++++
>> drivers/compress/octeontx/meson.build | 10 ++
>> .../octeontx/rte_pmd_octeontx_compress_version.map | 3 +
>> drivers/compress/octeontx/zip_pmd.c | 129 +++++++++++++++++++++
>> drivers/compress/octeontx/zipvf.c | 48 ++++++++
>> drivers/compress/octeontx/zipvf.h | 47 ++++++++
>> usertools/dpdk-devbind.py | 9 ++
>> 9 files changed, 286 insertions(+), 1 deletion(-)
>>
>> diff --git a/config/common_base b/config/common_base
>> index 6b0d1cbbb..e56d14b7f 100644
>> --- a/config/common_base
>> +++ b/config/common_base
>> @@ -584,6 +584,12 @@ CONFIG_RTE_COMPRESS_MAX_DEVS=64
>> #
>> CONFIG_RTE_COMPRESSDEV_TEST=n
>>
>> +#
>> +# Compile PMD for Octeontx ZIPVF compression device
>> +#
>> +CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF=n
>
>Please enable this option by default, If there are arm64 specific
>usage then please stub it out so that it can compile on
>all architectures. It will help to verify the API changes
>across the architecture by author.(i.e author should not depend arm64
>box to verify the compilation changes)
>
[Shally] Ok. Will propose this change in next patch
>> +CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF_DEBUG=n
>
>This config option is not required when we are using
>dynamic debugging.
[Shally] Ack
>
>> +
>> #
>> # Compile PMD for ISA-L compression device
>> #
>> diff --git a/drivers/compress/Makefile b/drivers/compress/Makefile
>> index 592497f51..62b4e5abe 100644
>> --- a/drivers/compress/Makefile
>> +++ b/drivers/compress/Makefile
>> @@ -4,5 +4,5 @@
>> include $(RTE_SDK)/mk/rte.vars.mk
>>
>> DIRS-$(CONFIG_RTE_LIBRTE_PMD_ISAL) += isal
>> -
>> +DIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_ZIPVF) += octeontx
>> include $(RTE_SDK)/mk/rte.subdir.mk
>> diff --git a/drivers/compress/octeontx/Makefile b/drivers/compress/octeontx/Makefile
>> new file mode 100644
>> index 000000000..89078f085
>> --- /dev/null
>> +++ b/drivers/compress/octeontx/Makefile
>> @@ -0,0 +1,33 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2017-2018 Cavium Network
>
>We are using the following copyright header across DPDK,
>Please use the same schematics new.
>
>example:
>Copyright(c) 2017 Cavium, Inc
>
>
//snip
>
>Use alphabetical order.
>
>> +#include "zipvf.h"
>> +
>> +/* global structure to keep driver info */
>> +struct zip_pmd_private zip_pmd_priv;
>
>Remove global memory. Use name based memzone infrastructure to
>allocate the memory.
[Shally] Ok. Will look into this.
>
//snip
>> +
>> +
>> +#endif /* _RTE_ZIP_VF_H_ */
>> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
>
>Addition to usertools/dpdk-devbind.py, please send it as separate patch as
>it is an common code change
[Shally] Ok.
Thanks for review.
Shally
next prev parent reply other threads:[~2018-06-20 6:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 10:35 [dpdk-dev] [PATCH v1 0/7] compress: add Octeontx ZIP compression PMD Shally Verma
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD support Shally Verma
2018-06-10 10:38 ` Jerin Jacob
2018-06-20 6:32 ` Verma, Shally [this message]
2018-06-19 22:15 ` De Lara Guarch, Pablo
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 2/7] compress/octeontx: add device setup PMD ops Shally Verma
2018-06-19 22:15 ` De Lara Guarch, Pablo
2018-06-20 6:04 ` Verma, Shally
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 3/7] compress/octeontx: add xform and stream create support Shally Verma
2018-06-19 22:13 ` De Lara Guarch, Pablo
2018-06-20 6:12 ` Verma, Shally
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 4/7] compress/octeontx: add ops enq deq apis Shally Verma
2018-06-19 22:18 ` De Lara Guarch, Pablo
2018-06-29 7:42 ` Verma, Shally
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 5/7] test: add octeontx zip PMD for compressdev tests Shally Verma
2018-06-19 22:18 ` De Lara Guarch, Pablo
2018-06-20 6:03 ` Verma, Shally
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 6/7] doc: add octeontx zip PMD documentation Shally Verma
2018-06-14 11:22 ` Kovacevic, Marko
2018-06-19 22:22 ` De Lara Guarch, Pablo
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 7/7] drivers/compress: add meson.build support Shally Verma
2018-06-19 22:30 ` De Lara Guarch, Pablo
2018-06-20 6:02 ` Verma, Shally
2018-06-20 7:25 ` De Lara Guarch, Pablo
2018-06-20 7:36 ` Verma, Shally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR0701MB36342A3A7144A08EB82164C5F0770@CY4PR0701MB3634.namprd07.prod.outlook.com \
--to=shally.verma@cavium.com \
--cc=Ashish.Gupta@cavium.com \
--cc=Jerin.JacobKollanukkaran@cavium.com \
--cc=Mahipal.Challa@cavium.com \
--cc=NarayanaPrasad.Athreya@cavium.com \
--cc=Sunila.Sahu@cavium.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).