From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
David Marchand <david.marchand@6wind.com>,
Olivier Matz <olivier.matz@6wind.com>,
"Horton, Remy" <remy.horton@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: document xstats API assumption
Date: Tue, 3 Jul 2018 16:11:54 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA65E268271@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <20180628141602.91695-1-ferruh.yigit@intel.com>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Thursday, June 28, 2018 3:16 PM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; David Marchand
> <david.marchand@6wind.com>; Olivier Matz <olivier.matz@6wind.com>; Horton,
> Remy <remy.horton@intel.com>
> Subject: [dpdk-dev] [PATCH] ethdev: document xstats API assumption
>
> Documents the assumption that 'xstats[i].id == i' and
> key=xstats_names[i].name, value=xstats[i].value
>
> xstats[i].id is still used for xstats _by_id() APIs.
>
> This patch reverts some part of the commit 6d52d1d4afb4 ("ethdev:
> clarify extended statistics documentation")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
I'm also in favor of simplifying xstats APIs if possible, given we have a number of PMDs using it, and they all adhere to this simplification;
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
next prev parent reply other threads:[~2018-07-03 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 8:15 [dpdk-dev] [PATCH] app/testpmd: add sanity checks when retrieving xstats David Marchand
2018-06-12 7:09 ` David Marchand
2018-06-12 8:38 ` Remy Horton
2018-06-13 15:39 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-06-14 6:39 ` Remy Horton
2018-06-14 10:55 ` Ferruh Yigit
2018-06-14 19:33 ` Remy Horton
2018-06-28 14:16 ` [dpdk-dev] [PATCH] ethdev: document xstats API assumption Ferruh Yigit
2018-06-29 7:15 ` David Marchand
2018-07-04 17:38 ` Ferruh Yigit
2018-07-03 16:11 ` Van Haaren, Harry [this message]
2018-07-07 17:45 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA65E268271@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=remy.horton@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).