From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>,
dev@dpdk.org, Yuanhan Liu <yliu@fridaylinux.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 03/10] net/virtio: fix compilation with -Og
Date: Fri, 6 Oct 2017 00:28:54 +0100 [thread overview]
Message-ID: <ce278266-6d39-7acc-15bc-091ca56f7cb9@intel.com> (raw)
In-Reply-To: <e0ff05a9-7dff-89b7-d166-0ff39a5a1392@intel.com>
On 10/6/2017 12:17 AM, Ferruh Yigit wrote:
> On 9/11/2017 4:13 PM, Olivier Matz wrote:
>> The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following
>> error:
>>
>> CC virtio_rxtx.o
>> virtio_rxtx.c: In function ‘virtio_rx_offload’:
>> virtio_rxtx.c:680:10: error: ‘csum’ may be used uninitialized in
>> this function [-Werror=maybe-uninitialized]
>> csum = ~csum;
>> ~~~~~^~~~~~~
>>
>> The function rte_raw_cksum_mbuf() may indeed return an error, and
>> in this case, csum won't be initialized. Fix it by initializing csum
>> to 0.
>
> After this fix if rte_raw_cksum_mbuf() returns error csum still will be
> wrong and since compiler warning suppressed it may be harder to find the
> root cause.
>
> For this case checking rte_raw_cksum_mbuf() return value seems better
> idea but I will cc the maintainer for decision.
Trying harder to add maintainer!
>
>>
>> Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload")
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>> ---
>> drivers/net/virtio/virtio_rxtx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
>> index 45a9c919a..cab3a1675 100644
>> --- a/drivers/net/virtio/virtio_rxtx.c
>> +++ b/drivers/net/virtio/virtio_rxtx.c
>> @@ -671,7 +671,7 @@ virtio_rx_offload(struct rte_mbuf *m, struct virtio_net_hdr *hdr)
>> * In case of SCTP, this will be wrong since it's a CRC
>> * but there's nothing we can do.
>> */
>> - uint16_t csum, off;
>> + uint16_t csum = 0, off;
>>
>> rte_raw_cksum_mbuf(m, hdr->csum_start,
>> rte_pktmbuf_pkt_len(m) - hdr->csum_start,
>>
>
next prev parent reply other threads:[~2017-10-05 23:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 15:13 [dpdk-dev] [PATCH 00/10] " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 01/10] net/bnxt: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 02/10] net/qede: " Olivier Matz
2017-09-11 18:22 ` Patil, Harish
2017-09-11 15:13 ` [dpdk-dev] [PATCH 03/10] net/virtio: " Olivier Matz
2017-10-05 23:17 ` Ferruh Yigit
2017-10-05 23:28 ` Ferruh Yigit [this message]
2017-10-06 6:43 ` Maxime Coquelin
2017-10-06 18:43 ` Ferruh Yigit
2017-09-11 15:13 ` [dpdk-dev] [PATCH 04/10] net/i40e: " Olivier Matz
2017-10-05 23:24 ` Ferruh Yigit
2017-10-11 6:20 ` Wu, Jingjing
2017-10-11 7:52 ` Olivier MATZ
2017-09-11 15:13 ` [dpdk-dev] [PATCH 05/10] uio: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 06/10] cmdline: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 07/10] metrics: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 08/10] lpm6: " Olivier Matz
2017-10-06 0:18 ` Ferruh Yigit
2017-10-26 10:42 ` Bruce Richardson
2017-10-26 18:54 ` Ferruh Yigit
2017-09-11 15:13 ` [dpdk-dev] [PATCH 09/10] app/test-crypto-perf: fix memory leak Olivier Matz
2017-10-05 9:29 ` De Lara Guarch, Pablo
2017-09-11 15:13 ` [dpdk-dev] [PATCH 10/10] app/test-crypto-perf: fix compilation with -Og Olivier Matz
2017-10-05 9:36 ` De Lara Guarch, Pablo
2017-09-11 15:28 ` [dpdk-dev] [PATCH 00/10] " Bruce Richardson
2017-10-06 0:26 ` Ferruh Yigit
2017-10-06 7:31 ` Olivier MATZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce278266-6d39-7acc-15bc-091ca56f7cb9@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).