DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [DPDK] net/e1000: add the VLAN capabilities of NIC
@ 2020-07-20  1:46 zhihongx.peng
  2020-07-20  1:59 ` Zhao1, Wei
  2020-07-20  6:48 ` [dpdk-dev] [DPDK v2] " zhihongx.peng
  0 siblings, 2 replies; 6+ messages in thread
From: zhihongx.peng @ 2020-07-20  1:46 UTC (permalink / raw)
  To: wei.zhao1, jia.guo; +Cc: dev, Peng Zhihong, wei.dai

From: Peng Zhihong <zhihongx.peng@intel.com>

The rte_eth_dev_set_vlan_offload function will check whether the NIC has
the set vlan feature. If it has not, it will return failure. So need
to add all the vlan feature flags of the NIC.

Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API")
Cc: wei.dai@intel.com

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 drivers/net/e1000/igb_rxtx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index 5717cdb70..966df3f20 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -1647,7 +1647,8 @@ igb_get_rx_port_offloads_capa(struct rte_eth_dev *dev)
 			  DEV_RX_OFFLOAD_JUMBO_FRAME |
 			  DEV_RX_OFFLOAD_KEEP_CRC    |
 			  DEV_RX_OFFLOAD_SCATTER     |
-			  DEV_RX_OFFLOAD_RSS_HASH;
+			  DEV_RX_OFFLOAD_RSS_HASH    |
+			  DEV_RX_OFFLOAD_VLAN_EXTEND;
 
 	return rx_offload_capa;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [DPDK] net/e1000: add the VLAN capabilities of NIC
  2020-07-20  1:46 [dpdk-dev] [DPDK] net/e1000: add the VLAN capabilities of NIC zhihongx.peng
@ 2020-07-20  1:59 ` Zhao1, Wei
  2020-07-20  6:48 ` [dpdk-dev] [DPDK v2] " zhihongx.peng
  1 sibling, 0 replies; 6+ messages in thread
From: Zhao1, Wei @ 2020-07-20  1:59 UTC (permalink / raw)
  To: Peng, ZhihongX, Guo, Jia; +Cc: dev, wei.dai

Hi, 

> -----Original Message-----
> From: Peng, ZhihongX <zhihongx.peng@intel.com>
> Sent: Monday, July 20, 2020 9:47 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Peng, ZhihongX <zhihongx.peng@intel.com>;
> wei.dai@intel.com
> Subject: [DPDK] net/e1000: add the VLAN capabilities of NIC
> 
> From: Peng Zhihong <zhihongx.peng@intel.com>
> 
> The rte_eth_dev_set_vlan_offload function will check whether the NIC has the
> set vlan feature. If it has not, it will return failure. So need to add all the vlan
> feature flags of the NIC.
> 
> Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API")
> Cc: wei.dai@intel.com


you should cc stable not wei.dai

> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  drivers/net/e1000/igb_rxtx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index
> 5717cdb70..966df3f20 100644
> --- a/drivers/net/e1000/igb_rxtx.c
> +++ b/drivers/net/e1000/igb_rxtx.c
> @@ -1647,7 +1647,8 @@ igb_get_rx_port_offloads_capa(struct rte_eth_dev
> *dev)
>  			  DEV_RX_OFFLOAD_JUMBO_FRAME |
>  			  DEV_RX_OFFLOAD_KEEP_CRC    |
>  			  DEV_RX_OFFLOAD_SCATTER     |
> -			  DEV_RX_OFFLOAD_RSS_HASH;
> +			  DEV_RX_OFFLOAD_RSS_HASH    |
> +			  DEV_RX_OFFLOAD_VLAN_EXTEND;
> 
>  	return rx_offload_capa;
>  }
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [DPDK v2] [DPDK] net/e1000: add the VLAN capabilities of NIC
  2020-07-20  1:46 [dpdk-dev] [DPDK] net/e1000: add the VLAN capabilities of NIC zhihongx.peng
  2020-07-20  1:59 ` Zhao1, Wei
@ 2020-07-20  6:48 ` zhihongx.peng
  2020-07-21  3:05   ` [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to capability zhihongx.peng
  1 sibling, 1 reply; 6+ messages in thread
From: zhihongx.peng @ 2020-07-20  6:48 UTC (permalink / raw)
  To: wei.zhao1, jia.guo; +Cc: dev, Peng Zhihong, stable

From: Peng Zhihong <zhihongx.peng@intel.com>

The rte_eth_dev_set_vlan_offload function will check whether the NIC has
the set vlan feature. If it has not, it will return failure. So need
to add all the vlan feature flags of the NIC.

Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API")
Cc: stable@dpdk.org

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 Changes:
	V2: modify commit log Cc to stable@dpdk.org.

 drivers/net/e1000/igb_rxtx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index 5717cdb70..966df3f20 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -1647,7 +1647,8 @@ igb_get_rx_port_offloads_capa(struct rte_eth_dev *dev)
 			  DEV_RX_OFFLOAD_JUMBO_FRAME |
 			  DEV_RX_OFFLOAD_KEEP_CRC    |
 			  DEV_RX_OFFLOAD_SCATTER     |
-			  DEV_RX_OFFLOAD_RSS_HASH;
+			  DEV_RX_OFFLOAD_RSS_HASH    |
+			  DEV_RX_OFFLOAD_VLAN_EXTEND;
 
 	return rx_offload_capa;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to capability
  2020-07-20  6:48 ` [dpdk-dev] [DPDK v2] " zhihongx.peng
@ 2020-07-21  3:05   ` zhihongx.peng
  2020-07-21  3:31     ` Zhao1, Wei
  0 siblings, 1 reply; 6+ messages in thread
From: zhihongx.peng @ 2020-07-21  3:05 UTC (permalink / raw)
  To: wei.zhao1, jia.guo; +Cc: dev, Peng Zhihong, stable

From: Peng Zhihong <zhihongx.peng@intel.com>

The rte_eth_dev_set_vlan_offload function will check vlan rx offload
capability, the i350/i210/i211 nics have vlan extend feature but
DEV_RX_OFFLOAD_VLAN_EXTEND is not set into the capability, that will
cause setting fail. So need to add this capability in
igb_get_rx_port_offloads_capa function.

Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API")
Cc: stable@dpdk.org

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 drivers/net/e1000/igb_rxtx.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index 5717cdb70..6411924e0 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -1637,8 +1637,10 @@ uint64_t
 igb_get_rx_port_offloads_capa(struct rte_eth_dev *dev)
 {
 	uint64_t rx_offload_capa;
+	struct e1000_hw *hw;
+
+	hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 
-	RTE_SET_USED(dev);
 	rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP  |
 			  DEV_RX_OFFLOAD_VLAN_FILTER |
 			  DEV_RX_OFFLOAD_IPV4_CKSUM  |
@@ -1649,6 +1651,11 @@ igb_get_rx_port_offloads_capa(struct rte_eth_dev *dev)
 			  DEV_RX_OFFLOAD_SCATTER     |
 			  DEV_RX_OFFLOAD_RSS_HASH;
 
+	if (hw->mac.type == e1000_i350 ||
+	    hw->mac.type == e1000_i210 ||
+	    hw->mac.type == e1000_i211)
+		rx_offload_capa |= DEV_RX_OFFLOAD_VLAN_EXTEND;
+
 	return rx_offload_capa;
 }
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to capability
  2020-07-21  3:05   ` [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to capability zhihongx.peng
@ 2020-07-21  3:31     ` Zhao1, Wei
  2020-07-21  5:05       ` Zhang, Qi Z
  0 siblings, 1 reply; 6+ messages in thread
From: Zhao1, Wei @ 2020-07-21  3:31 UTC (permalink / raw)
  To: Peng, ZhihongX, Guo, Jia; +Cc: dev, stable

Reviewed-by: Wei Zhao <wei.zhao1@intel.com>

> -----Original Message-----
> From: Peng, ZhihongX <zhihongx.peng@intel.com>
> Sent: Tuesday, July 21, 2020 11:05 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Peng, ZhihongX <zhihongx.peng@intel.com>;
> stable@dpdk.org
> Subject: [DPDK v3] net/e1000: add VLAN extend feature to capability
> 
> From: Peng Zhihong <zhihongx.peng@intel.com>
> 
> The rte_eth_dev_set_vlan_offload function will check vlan rx offload capability,
> the i350/i210/i211 nics have vlan extend feature but
> DEV_RX_OFFLOAD_VLAN_EXTEND is not set into the capability, that will cause
> setting fail. So need to add this capability in igb_get_rx_port_offloads_capa
> function.
> 
> Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  drivers/net/e1000/igb_rxtx.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index
> 5717cdb70..6411924e0 100644
> --- a/drivers/net/e1000/igb_rxtx.c
> +++ b/drivers/net/e1000/igb_rxtx.c
> @@ -1637,8 +1637,10 @@ uint64_t
>  igb_get_rx_port_offloads_capa(struct rte_eth_dev *dev)  {
>  	uint64_t rx_offload_capa;
> +	struct e1000_hw *hw;
> +
> +	hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> 
> -	RTE_SET_USED(dev);
>  	rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP  |
>  			  DEV_RX_OFFLOAD_VLAN_FILTER |
>  			  DEV_RX_OFFLOAD_IPV4_CKSUM  |
> @@ -1649,6 +1651,11 @@ igb_get_rx_port_offloads_capa(struct rte_eth_dev
> *dev)
>  			  DEV_RX_OFFLOAD_SCATTER     |
>  			  DEV_RX_OFFLOAD_RSS_HASH;
> 
> +	if (hw->mac.type == e1000_i350 ||
> +	    hw->mac.type == e1000_i210 ||
> +	    hw->mac.type == e1000_i211)
> +		rx_offload_capa |= DEV_RX_OFFLOAD_VLAN_EXTEND;
> +
>  	return rx_offload_capa;
>  }
> 
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to capability
  2020-07-21  3:31     ` Zhao1, Wei
@ 2020-07-21  5:05       ` Zhang, Qi Z
  0 siblings, 0 replies; 6+ messages in thread
From: Zhang, Qi Z @ 2020-07-21  5:05 UTC (permalink / raw)
  To: Zhao1, Wei, Peng, ZhihongX, Guo, Jia; +Cc: dev, stable



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Zhao1, Wei
> Sent: Tuesday, July 21, 2020 11:31 AM
> To: Peng, ZhihongX <zhihongx.peng@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to
> capability
> 
> Reviewed-by: Wei Zhao <wei.zhao1@intel.com>
> 
> > -----Original Message-----
> > From: Peng, ZhihongX <zhihongx.peng@intel.com>
> > Sent: Tuesday, July 21, 2020 11:05 AM
> > To: Zhao1, Wei <wei.zhao1@intel.com>; Guo, Jia <jia.guo@intel.com>
> > Cc: dev@dpdk.org; Peng, ZhihongX <zhihongx.peng@intel.com>;
> > stable@dpdk.org
> > Subject: [DPDK v3] net/e1000: add VLAN extend feature to capability
> >
> > From: Peng Zhihong <zhihongx.peng@intel.com>
> >
> > The rte_eth_dev_set_vlan_offload function will check vlan rx offload
> > capability, the i350/i210/i211 nics have vlan extend feature but
> > DEV_RX_OFFLOAD_VLAN_EXTEND is not set into the capability, that will
> > cause setting fail. So need to add this capability in
> > igb_get_rx_port_offloads_capa function.
> >
> > Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-07-21  5:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20  1:46 [dpdk-dev] [DPDK] net/e1000: add the VLAN capabilities of NIC zhihongx.peng
2020-07-20  1:59 ` Zhao1, Wei
2020-07-20  6:48 ` [dpdk-dev] [DPDK v2] " zhihongx.peng
2020-07-21  3:05   ` [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to capability zhihongx.peng
2020-07-21  3:31     ` Zhao1, Wei
2020-07-21  5:05       ` Zhang, Qi Z

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git