DPDK patches and discussions
 help / color / mirror / Atom feed
From: Helin Zhang <helin.zhang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 26/27] pci: support reading/writing sys files of 'extended_tag' and 'max_read_request_size'
Date: Thu,  5 Jun 2014 13:09:10 +0800	[thread overview]
Message-ID: <1401944951-23783-27-git-send-email-helin.zhang@intel.com> (raw)
In-Reply-To: <1401944951-23783-1-git-send-email-helin.zhang@intel.com>

Sys files of 'extended_tag' and 'max_read_request_size' are
supported by igb_uio. Reading or writing them to enable/disable
'Extended Tag' or reset 'Max Read Request Size' automatically
according to the configurations are added.

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
Signed-off-by: Jing Chen <jing.d.chen@intel.com>
Acked-by: Cunming Liang <cunming.liang@intel.com>
Acked-by: Jijiang Liu <jijiang.liu@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Tested-by: Waterman Cao <waterman.cao@intel.com>
---
 lib/librte_eal/linuxapp/eal/eal_pci.c | 99 +++++++++++++++++++++++++++++++++++
 1 file changed, 99 insertions(+)

diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
index ac2c1fe..17f5675 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
@@ -106,6 +106,9 @@ TAILQ_HEAD(uio_res_list, uio_resource);
 
 static struct uio_res_list *uio_res_list = NULL;
 static int pci_parse_sysfs_value(const char *filename, uint64_t *val);
+#ifdef RTE_PCI_CONFIG
+static void pci_config_space_set(struct rte_pci_device *dev);
+#endif
 
 /* unbind kernel driver for this device */
 static int
@@ -840,6 +843,13 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d
 		}
 
 		if (dr->drv_flags & RTE_PCI_DRV_NEED_IGB_UIO) {
+#ifdef RTE_PCI_CONFIG
+			/*
+			 * Set PCIe config space for high performance.
+			 * Return value can be ignored.
+			 */
+			pci_config_space_set(dev);
+#endif
 			/* map resources for devices that use igb_uio */
 			if (pci_uio_map_resource(dev) < 0)
 				return -1;
@@ -878,3 +888,92 @@ rte_eal_pci_init(void)
 	}
 	return 0;
 }
+
+#ifdef RTE_PCI_CONFIG
+static int
+pci_config_extended_tag(struct rte_pci_device *dev)
+{
+	struct rte_pci_addr *loc = &dev->addr;
+	char filename[PATH_MAX];
+	char buf[BUFSIZ];
+	FILE *f;
+
+	/* not configured, let it as is */
+	if (strncmp(RTE_PCI_EXTENDED_TAG, "on", 2) != 0 &&
+		strncmp(RTE_PCI_EXTENDED_TAG, "off", 3) != 0)
+		return 0;
+
+	rte_snprintf(filename, sizeof(filename),
+		SYSFS_PCI_DEVICES "/" PCI_PRI_FMT "/" "extended_tag",
+		loc->domain, loc->bus, loc->devid, loc->function);
+	f = fopen(filename, "rw+");
+	if (!f)
+		return -1;
+
+	fgets(buf, sizeof(buf), f);
+	if (strncmp(RTE_PCI_EXTENDED_TAG, "on", 2) == 0) {
+		/* enable Extended Tag*/
+		if (strncmp(buf, "on", 2) != 0) {
+			fseek(f, 0, SEEK_SET);
+			fputs("on", f);
+		}
+	} else {
+		/* disable Extended Tag */
+		if (strncmp(buf, "off", 3) != 0) {
+			fseek(f, 0, SEEK_SET);
+			fputs("off", f);
+		}
+	}
+	fclose(f);
+
+	return 0;
+}
+
+static int
+pci_config_max_read_request_size(struct rte_pci_device *dev)
+{
+	struct rte_pci_addr *loc = &dev->addr;
+	char filename[PATH_MAX];
+	char buf[BUFSIZ], param[BUFSIZ];
+	FILE *f;
+	uint32_t max_size = RTE_PCI_MAX_READ_REQUEST_SIZE;
+
+	/* not configured, let it as is */
+	if (!max_size)
+		return 0;
+
+	rte_snprintf(filename, sizeof(filename),
+		SYSFS_PCI_DEVICES "/" PCI_PRI_FMT "/" "max_read_request_size",
+			loc->domain, loc->bus, loc->devid, loc->function);
+	f = fopen(filename, "rw+");
+	if (!f)
+		return -1;
+
+	fgets(buf, sizeof(buf), f);
+	rte_snprintf(param, sizeof(param), "%d", max_size);
+
+	/* check if the size to be set is the same as current */
+	if (strcmp(buf, param) == 0) {
+		fclose(f);
+		return 0;
+	}
+	fseek(f, 0, SEEK_SET);
+	fputs(param, f);
+	fclose(f);
+
+	return 0;
+}
+
+static void
+pci_config_space_set(struct rte_pci_device *dev)
+{
+	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+		return;
+
+	/* configure extended tag */
+	pci_config_extended_tag(dev);
+
+	/* configure max read request size */
+	pci_config_max_read_request_size(dev);
+}
+#endif
-- 
1.8.1.4

  parent reply	other threads:[~2014-06-05  5:11 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05  5:08 [dpdk-dev] [PATCH v2 00/27] Add i40e PMD support Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 01/27] i40e: add basic shared code Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 02/27] i40e: add PMD source files Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 03/27] pci: add macros and pci device IDs to support i40e Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 04/27] igb_uio: add i40e support Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 05/27] mbuf: add new packet flags for i40e Helin Zhang
2014-06-05 15:30   ` Stephen Hemminger
     [not found]     ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A735ACB@SHSMSX104.ccr.corp.intel.com>
2014-06-12  1:38       ` Zhang, Helin
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 06/27] ethdev: add i40e support Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 07/27] ethdev: support setting maximum packet length to less than 1518 Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 08/27] vmxnet3: enlarge the hash flags of RSS to 64 bits Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 09/27] ixgbe: " Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 10/27] igb: " Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 11/27] mk: add i40e support Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 12/27] config: add configurations for i40e Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 13/27] app/test-pmd: support displaying 32 bytes RX descriptors Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 14/27] app/test-pmd: add command of 'tx_vlan set pvid port_id vlan_id (on|off)' Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 15/27] app/testpmd: enlarge the hash flags of RSS to 64 bits Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 16/27] app/test-pmd: add L3 packet type in offload flags Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 17/27] examples/dpdk_qat: use ETH_RSS_IP to replace IP hash flags of RSS Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 18/27] examples/ip_reassembly: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 19/27] examples/l3fwd-power: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 20/27] examples/l3fwd-vf: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 21/27] examples/l3fwd: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 22/27] examples/load_balancer: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 23/27] examples/multi_process: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 24/27] examples/qos_meter: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 25/27] igb_uio: add sys files to read/write specific bits in pci config space Helin Zhang
2014-06-05  5:09 ` Helin Zhang [this message]
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 27/27] config: add configurations for enabling 'Extended Tag' or resetting 'Max Read Request Size' Helin Zhang
2014-06-05  8:36 ` [dpdk-dev] [PATCH v2 00/27] Add i40e PMD support Zhu, Heqing
2014-06-17 16:27 ` Thomas Monjalon
2014-06-18  8:51   ` Zhang, Helin
2014-06-18  9:23     ` Thomas Monjalon
2014-06-19  6:24       ` Zhang, Helin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401944951-23783-27-git-send-email-helin.zhang@intel.com \
    --to=helin.zhang@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).