From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/5] ixgbe: don't print PCI address on link change
Date: Mon, 18 May 2015 10:32:39 +0100 [thread overview]
Message-ID: <20150518093238.GE1636@bricha3-MOBL3> (raw)
In-Reply-To: <1431709707-5281-3-git-send-email-stephen@networkplumber.org>
On Fri, May 15, 2015 at 10:08:24AM -0700, Stephen Hemminger wrote:
> Printing PCI information on link state change is unnecessary since
> the same information has already been displayed earlier in the log.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> index a585151..fa335f4 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> @@ -2315,11 +2315,6 @@ ixgbe_dev_link_status_print(struct rte_eth_dev *dev)
> PMD_INIT_LOG(INFO, "Port %u: Link Down",
> dev->data->port_id);
> }
> - PMD_INIT_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d",
> - dev->pci_dev->addr.domain,
> - dev->pci_dev->addr.bus,
> - dev->pci_dev->addr.devid,
> - dev->pci_dev->addr.function);
> }
>
> /*
> --
> 2.1.4
>
next prev parent reply other threads:[~2015-05-18 9:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 17:08 [dpdk-dev] [PATCH v2 0/5] ixgbe: logging patches Stephen Hemminger
2015-05-15 17:08 ` [dpdk-dev] [PATCH 1/5] ixgbe: remove unnecessary casts Stephen Hemminger
2015-05-18 9:24 ` Bruce Richardson
2015-05-15 17:08 ` [dpdk-dev] [PATCH 2/5] ixgbe: don't print PCI address on link change Stephen Hemminger
2015-05-18 9:32 ` Bruce Richardson [this message]
2015-05-15 17:08 ` [dpdk-dev] [PATCH 3/5] ixgbe: raise priority of significant events Stephen Hemminger
2015-05-18 9:27 ` Bruce Richardson
2015-05-15 17:08 ` [dpdk-dev] [PATCH 4/5] ixgbe: use RTE_LOG not rte_log Stephen Hemminger
2015-05-18 9:28 ` Bruce Richardson
2015-05-15 17:08 ` [dpdk-dev] [PATCH 5/5] ixgbe: silence noisy log messages Stephen Hemminger
2015-05-18 9:32 ` Bruce Richardson
2015-05-18 16:39 ` Stephen Hemminger
2015-05-19 7:46 ` David Marchand
2015-05-19 14:40 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518093238.GE1636@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).