DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
	Anand Rawat <anand.rawat@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal: remove exec-env directory
Date: Tue, 02 Apr 2019 12:03:14 +0200	[thread overview]
Message-ID: <10947252.tCyXudDSDa@xps> (raw)
Message-ID: <20190402100314.kI99mZ5xRJkpnrC-o6Me1lNruYfjwdY-JGPB78Ehu-4@z> (raw)
In-Reply-To: <CAJFAV8yn97fs9rbCdEnwrk5FzSxLsrpd61LmOmoffLXGtvxQEQ@mail.gmail.com>

02/04/2019 11:57, David Marchand:
> On Tue, Apr 2, 2019 at 1:07 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > Only one header file (rte_kni_common.h) was in the sub-directory
> >         include/exec-env/
> > This file was installed in a sub-directory of the same name.
> > Source and install directories are moved as below:
> >
> >    lib/librte_eal/linux/eal/include/exec-env/
> > -> lib/librte_eal/linux/eal/include/
> >
> >    build/include/exec-env/
> > -> build/include/
> >
> > The consequence is to have a file hierarchy a bit more flat.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> >  devtools/check-includes.sh                                     | 1 -
> >  kernel/linux/kni/kni_dev.h                                     | 2 +-
> >  kernel/linux/kni/kni_fifo.h                                    | 2 +-
> >  kernel/linux/kni/kni_misc.c                                    | 2 +-
> >  kernel/linux/kni/kni_net.c                                     | 2 +-
> >  lib/librte_eal/freebsd/eal/Makefile                            | 3 +--
> >  lib/librte_eal/linux/eal/Makefile                              | 3 +--
> >  .../linux/eal/include/{exec-env => }/rte_kni_common.h          | 0
> >  lib/librte_kni/rte_kni.c                                       | 2 +-
> >  lib/librte_kni/rte_kni.h                                       | 2 +-
> >  10 files changed, 8 insertions(+), 11 deletions(-)
> >  rename lib/librte_eal/linux/eal/include/{exec-env => }/rte_kni_common.h
> > (100%)
> >
> 
> Think you missed some bits in meson.
> lib/librte_eal/linux/eal/meson.build:install_subdir('include/exec-env',
> install_dir: get_option('includedir'))

You're right. I wonder how I have missed it!
In my poor understanding of meson, I think I just have to remove this line.




  parent reply	other threads:[~2019-04-02 10:03 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 23:07 Thomas Monjalon
2019-04-01 23:07 ` Thomas Monjalon
2019-04-02  9:39 ` Bruce Richardson
2019-04-02  9:39   ` Bruce Richardson
2019-04-02 14:43   ` Ferruh Yigit
2019-04-02 14:43     ` Ferruh Yigit
2019-04-02  9:57 ` David Marchand
2019-04-02  9:57   ` David Marchand
2019-04-02 10:03   ` Thomas Monjalon [this message]
2019-04-02 10:03     ` Thomas Monjalon
2019-04-02 15:13 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2019-04-02 15:13   ` Thomas Monjalon
2019-04-02 19:30 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2019-04-02 19:30   ` Thomas Monjalon
2019-04-02 19:46   ` David Marchand
2019-04-02 19:46     ` David Marchand
2019-04-02 19:50     ` Thomas Monjalon
2019-04-02 19:50       ` Thomas Monjalon
2019-04-03  8:41       ` David Marchand
2019-04-03  8:41         ` David Marchand
2019-04-02 19:52     ` Ferruh Yigit
2019-04-02 19:52       ` Ferruh Yigit
2019-04-02 19:55       ` David Marchand
2019-04-02 19:55         ` David Marchand
2019-04-02 19:57         ` Ferruh Yigit
2019-04-02 19:57           ` Ferruh Yigit
2019-04-02 20:04           ` David Marchand
2019-04-02 20:04             ` David Marchand
2019-04-02 20:09             ` Thomas Monjalon
2019-04-02 20:09               ` Thomas Monjalon
2019-04-03 13:34       ` Bruce Richardson
2019-04-03 13:34         ` Bruce Richardson
2019-04-02 19:50   ` Ferruh Yigit
2019-04-02 19:50     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10947252.tCyXudDSDa@xps \
    --to=thomas@monjalon.net \
    --cc=anand.rawat@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).