DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
	Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Bernard Iremonger <bernard.iremonger@intel.com>,
	WenjieX A Li <wenjiex.a.li@intel.com>
Subject: Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"
Date: Tue, 7 May 2019 11:09:28 +0100
Message-ID: <aa20ba88-b10d-821c-95cb-bfb3db102b8f@intel.com> (raw)
Message-ID: <20190507100928.pOyue5JiSaPL-NSHiueAU3HlgisgF9bYynJGpTjyvMw@z> (raw)
In-Reply-To: <34775dd7-e426-7464-02e9-8fa8730c0cfe@solarflare.com>

On 5/6/2019 9:09 AM, Andrew Rybchenko wrote:
> On 5/4/19 11:45 PM, Thomas Monjalon wrote:
>> 02/05/2019 22:27, Thomas Monjalon:
>>> 02/05/2019 20:31, Ferruh Yigit:
>>>> On 4/29/2019 10:52 AM, Thomas Monjalon wrote:
>>>>> 25/04/2019 17:27, Ferruh Yigit:
>>>>>> On 4/25/2019 2:29 PM, Thomas Monjalon wrote:
>>>>>>> 25/04/2019 13:47, Ferruh Yigit:
>>>>>>>> On 4/25/2019 9:19 AM, Thomas Monjalon wrote:
>>>>>>>>> 25/04/2019 00:03, Ferruh Yigit:
>>>>>>>>>> This reverts commit bdca79053b6aea504d02691d9319fa976062457f.
>>>>>>>>>>
>>>>>>>>>> Not all PMDs support the fixed link speed set, and link speed can be set
>>>>>>>>>> even with auto negotiation enabled. Reverting the patch to not break
>>>>>>>>>> existing usage.
>>>>>>>>> Which PMDs do not support this flag?
>>>>>>>>> Why not fixing the PMDs?
>>>>>>>>>
>>>>>>>> At least ixgbe and i40e is not supporting setting a fixed speed.
>>>>>>>> But I am not sure if this is something to fix, the command in testpmd is to set
>>>>>>>> the link speed, what is the problem with setting the link speed without
>>>>>>>> disabling the auto-negotiation?
>>>>>>> It means it will negotiate with only one speed proposed.
>>>>>> Yes.
>>>>>>
>>>>>>> The real issue is to not support the fixed flag.
>>>>>> I don't know if this is a real issue but
>>>>>> even it is, is it an issue in the scope of this testpmd command?
>>>>>>
>>>>>> right now we are first updating the command to set fixed speed flag, and
>>>>>> requesting PMDs to fix for it, I am suggesting not to update the command at all.
>>>>> I understand. But this change shows a broken behaviour.
>>>>> This is the intent of testpmd to show what works or not in PMDs.
>>>>> How hard is it to fix the PMDs in your opinion?
>>>>>
>>>> As far as I can see the the fixed link speed set is not supported in the PMD.
>>>>
>>>> It may be easy to add perhaps, I don't know, but is it really a "broken
>>>> behavior" to not have this support?
>>>> What defines that setting speed has to be "fixed speed", if this demand is not
>>>> there, should testpmd enforce it?
>>> I think a PMD should support both: fixed or not.
>>>
>>>> In mail thread we have talked that this testpmd command can get an extra
>>>> argument to define the speed fixed or not, this can be used to test fixed speed
>>>> by who wants to test/use fixed speed.
>>>>
>>>> I am for reverting this for the release, and adding a new version next release
>>>> with fixed speed argument, otherwise testpmd won't be used to set the speed for
>>>> some PMDs.
>>> OK
>> We could have an option in testpmd to test ETH_LINK_SPEED_FIXED.
>>
>> Revert applied.
> 
> I agree that revert is the best option for the release, but not long term.
> 
> Typical options are (in order):
>  1. Auto-negotiation of whatever port supports
>  2. Fixed exactly one speed with autoneg disabled
>  3. Auto-negotiation with limitations (and it is really the third option which
> makes sense if and only if interface allows to specify more than one speed to be
> negotiated)
> 
> Right now testpmd supports (1) and (3) with limitation to only one speed to be
> negotiated. I think it is wrong.

+1 to not leave this revert as it is for long term, what do you think for:

1) Implement 'fixed' link speed support in the missing drivers.
2) Send a new version of the testpmd patch with a "fixed" argument, so that we
can support all three above

  parent reply	other threads:[~2019-05-07 10:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 22:03 Ferruh Yigit
2019-04-24 22:03 ` Ferruh Yigit
2019-04-25  8:19 ` Thomas Monjalon
2019-04-25  8:19   ` Thomas Monjalon
2019-04-25 11:47   ` Ferruh Yigit
2019-04-25 11:47     ` Ferruh Yigit
2019-04-25 13:29     ` Thomas Monjalon
2019-04-25 13:29       ` Thomas Monjalon
2019-04-25 15:27       ` Ferruh Yigit
2019-04-25 15:27         ` Ferruh Yigit
2019-04-29  9:52         ` Thomas Monjalon
2019-04-29  9:52           ` Thomas Monjalon
2019-05-02 18:31           ` Ferruh Yigit
2019-05-02 18:31             ` Ferruh Yigit
2019-05-02 20:27             ` Thomas Monjalon
2019-05-02 20:27               ` Thomas Monjalon
2019-05-04 20:45               ` Thomas Monjalon
2019-05-04 20:45                 ` Thomas Monjalon
2019-05-06  8:09                 ` Andrew Rybchenko
2019-05-06  8:09                   ` Andrew Rybchenko
2019-05-07 10:09                   ` Ferruh Yigit [this message]
2019-05-07 10:09                     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa20ba88-b10d-821c-95cb-bfb3db102b8f@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=thomas@monjalon.net \
    --cc=wenjiex.a.li@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git