DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/procinfo: enhance port and mempool info
@ 2020-07-10 16:06 Hemant Agrawal
  2020-07-10 18:07 ` Stephen Hemminger
  2020-07-11  9:53 ` [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info Hemant Agrawal
  0 siblings, 2 replies; 10+ messages in thread
From: Hemant Agrawal @ 2020-07-10 16:06 UTC (permalink / raw)
  To: dev; +Cc: maryam.tahhan, reshma.pattan, Hemant Agrawal

This patch enhances the port info for more details about
the port and queues.
This patch also add support to get info about the mempool
ops.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 app/proc-info/main.c | 63 ++++++++++++++++++++++++++++++++++++--------
 1 file changed, 52 insertions(+), 11 deletions(-)

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index abeca4aab..2dda1e201 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -661,6 +661,7 @@ show_port(void)
 {
 	uint16_t i = 0;
 	int ret = 0, j, k;
+	int rxq_count;
 
 	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD %"PRIu64,
 			rte_get_tsc_hz());
@@ -672,12 +673,27 @@ show_port(void)
 		struct rte_eth_dev_info dev_info;
 		struct rte_eth_rxq_info queue_info;
 		struct rte_eth_rss_conf rss_conf;
+		struct rte_ether_addr ethaddr;
+		char name[RTE_ETH_NAME_MAX_LEN];
 
 		memset(&rss_conf, 0, sizeof(rss_conf));
 
-		snprintf(bdr_str, MAX_STRING_LEN, " Port (%u)", i);
+		rte_eth_dev_get_name_by_port(i, name);
+
+		snprintf(bdr_str, MAX_STRING_LEN, " Port (%u)(%s)", i, name);
 		STATS_BDR_STR(5, bdr_str);
 		printf("  - generic config\n");
+		ret = rte_eth_macaddr_get(i, &ethaddr);
+		if (ret != 0) {
+			printf("macaddr get failed (port %u): %s\n",
+			       i, rte_strerror(-ret));
+		} else {
+			printf("\t  MAC: %02" PRIx8 ":%02" PRIx8 ":%02" PRIx8
+				":%02" PRIx8 ":%02" PRIx8 ":%02" PRIx8"\n",
+				ethaddr.addr_bytes[0], ethaddr.addr_bytes[1],
+				ethaddr.addr_bytes[2], ethaddr.addr_bytes[3],
+				ethaddr.addr_bytes[4], ethaddr.addr_bytes[5]);
+		}
 
 		printf("\t  -- Socket %d\n", rte_eth_dev_socket_id(i));
 		ret = rte_eth_link_get(i, &link);
@@ -685,18 +701,21 @@ show_port(void)
 			printf("Link get failed (port %u): %s\n",
 			       i, rte_strerror(-ret));
 		} else {
-			printf("\t  -- link speed %d duplex %d,"
-					" auto neg %d status %d\n",
-					link.link_speed,
-					link.link_duplex,
-					link.link_autoneg,
-					link.link_status);
+			printf("\t  -- link speed: %d Mbps %s,"
+				":auto neg %d :status-%s\n",
+				link.link_speed,
+				(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
+				 ("full-duplex") : ("half-duplex"),
+				link.link_autoneg,
+				(link.link_status) ? ("up") : ("down"));
 		}
-		printf("\t  -- promiscuous (%d)\n",
-				rte_eth_promiscuous_get(i));
+		printf("\t  -- promiscuous: %s\n",
+			rte_eth_promiscuous_get(i) ? "enabled" : "disabled");
 		ret = rte_eth_dev_get_mtu(i, &mtu);
 		if (ret == 0)
 			printf("\t  -- mtu (%d)\n", mtu);
+		printf("\t  -- multicast mode: %s\n",
+			rte_eth_allmulticast_get(i) ? "enabled" : "disabled");
 
 		ret = rte_eth_dev_info_get(i, &dev_info);
 		if (ret != 0) {
@@ -704,7 +723,17 @@ show_port(void)
 				i, strerror(-ret));
 			return;
 		}
-
+		printf("\t  -- Driver name: %s\n", dev_info.driver_name);
+		if (dev_info.device->devargs && dev_info.device->devargs->args)
+			printf("\t  -- Devargs: %s\n",
+				dev_info.device->devargs->args);
+		printf("\t  -- min size of RX buf: %u\n",
+			dev_info.min_rx_bufsize);
+		printf("\t  -- max config length of RX pkt: %u\n",
+			dev_info.max_rx_pktlen);
+
+		printf("\t  -- num of RX queues: %u\n", dev_info.nb_rx_queues);
+		printf("\t  -- num of TX queues: %u\n", dev_info.nb_tx_queues);
 		printf("  - queue\n");
 		for (j = 0; j < dev_info.nb_rx_queues; j++) {
 			ret = rte_eth_rx_queue_info_get(i, j, &queue_info);
@@ -718,7 +747,15 @@ show_port(void)
 						queue_info.nb_desc,
 						queue_info.conf.offloads,
 						queue_info.mp->socket_id);
+				printf("\t  -- mempool name: %s\n",
+						(queue_info.mp == NULL) ?
+						"NULL" : queue_info.mp->name);
+
 			}
+			rxq_count = rte_eth_rx_queue_count(i, j);
+			if (rxq_count >= 0)
+				printf("\t  -- used rx desc count: %d\n",
+						rxq_count);
 		}
 
 		ret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf);
@@ -734,7 +771,7 @@ show_port(void)
 			}
 		}
 
-		printf("  - cyrpto context\n");
+		printf("  - crypto context\n");
 #ifdef RTE_LIBRTE_SECURITY
 		void *p_ctx = rte_eth_dev_get_sec_ctx(i);
 		printf("\t  -- security context - %p\n", p_ctx);
@@ -1176,8 +1213,10 @@ show_mempool(char *name)
 
 	if (name != NULL) {
 		struct rte_mempool *ptr = rte_mempool_lookup(name);
+		struct rte_mempool_ops *ops;
 		if (ptr != NULL) {
 			flags = ptr->flags;
+			ops = rte_mempool_get_ops(ptr->ops_index);
 			printf("  - Name: %s on socket %d\n"
 				"  - flags:\n"
 				"\t  -- No spread (%c)\n"
@@ -1207,6 +1246,8 @@ show_mempool(char *name)
 			printf("  - Count: avail (%u), in use (%u)\n",
 				rte_mempool_avail_count(ptr),
 				rte_mempool_in_use_count(ptr));
+			printf("  - ops_index %d ops_name %s\n",
+				ptr->ops_index, ops ? ops->name:"NA");
 
 			STATS_BDR_STR(50, "");
 			return;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] app/procinfo: enhance port and mempool info
  2020-07-10 16:06 [dpdk-dev] [PATCH] app/procinfo: enhance port and mempool info Hemant Agrawal
@ 2020-07-10 18:07 ` Stephen Hemminger
  2020-07-11  9:53 ` [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info Hemant Agrawal
  1 sibling, 0 replies; 10+ messages in thread
From: Stephen Hemminger @ 2020-07-10 18:07 UTC (permalink / raw)
  To: Hemant Agrawal; +Cc: dev, maryam.tahhan, reshma.pattan

On Fri, 10 Jul 2020 21:36:10 +0530
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:

> +			printf("\t  MAC: %02" PRIx8 ":%02" PRIx8 ":%02" PRIx8
> +				":%02" PRIx8 ":%02" PRIx8 ":%02" PRIx8"\n",
> +				ethaddr.addr_bytes[0], ethaddr.addr_bytes[1],
> +				ethaddr.addr_bytes[2], ethaddr.addr_bytes[3],
> +				ethaddr.addr_bytes[4], ethaddr.addr_bytes[5]);


Please use rte_ether_format_addr() here.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info
  2020-07-10 16:06 [dpdk-dev] [PATCH] app/procinfo: enhance port and mempool info Hemant Agrawal
  2020-07-10 18:07 ` Stephen Hemminger
@ 2020-07-11  9:53 ` Hemant Agrawal
  2020-07-12  3:12   ` Stephen Hemminger
                     ` (2 more replies)
  1 sibling, 3 replies; 10+ messages in thread
From: Hemant Agrawal @ 2020-07-11  9:53 UTC (permalink / raw)
  To: dev; +Cc: maryam.tahhan, reshma.pattan, Hemant Agrawal

This patch enhances the port info for more details about
the port and queues.
This patch also add support to get info about the mempool
ops and security context for crypto devices.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 app/proc-info/main.c | 84 +++++++++++++++++++++++++++++++++++++-------
 1 file changed, 72 insertions(+), 12 deletions(-)

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index abeca4aab..818c85d61 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -661,6 +661,7 @@ show_port(void)
 {
 	uint16_t i = 0;
 	int ret = 0, j, k;
+	int rxq_count;
 
 	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD %"PRIu64,
 			rte_get_tsc_hz());
@@ -672,12 +673,26 @@ show_port(void)
 		struct rte_eth_dev_info dev_info;
 		struct rte_eth_rxq_info queue_info;
 		struct rte_eth_rss_conf rss_conf;
+		struct rte_ether_addr ethaddr;
+		char name[RTE_ETH_NAME_MAX_LEN];
 
 		memset(&rss_conf, 0, sizeof(rss_conf));
 
-		snprintf(bdr_str, MAX_STRING_LEN, " Port (%u)", i);
+		rte_eth_dev_get_name_by_port(i, name);
+
+		snprintf(bdr_str, MAX_STRING_LEN, " Port (%u)(%s)", i, name);
 		STATS_BDR_STR(5, bdr_str);
 		printf("  - generic config\n");
+		ret = rte_eth_macaddr_get(i, &ethaddr);
+		if (ret != 0) {
+			printf("macaddr get failed (port %u): %s\n",
+			       i, rte_strerror(-ret));
+		} else {
+			char buf[RTE_ETHER_ADDR_FMT_SIZE];
+			rte_ether_format_addr(buf, RTE_ETHER_ADDR_FMT_SIZE,
+				&ethaddr);
+			printf("\t  -- MAC:%s\n", buf);
+		}
 
 		printf("\t  -- Socket %d\n", rte_eth_dev_socket_id(i));
 		ret = rte_eth_link_get(i, &link);
@@ -685,18 +700,21 @@ show_port(void)
 			printf("Link get failed (port %u): %s\n",
 			       i, rte_strerror(-ret));
 		} else {
-			printf("\t  -- link speed %d duplex %d,"
-					" auto neg %d status %d\n",
-					link.link_speed,
-					link.link_duplex,
-					link.link_autoneg,
-					link.link_status);
+			printf("\t  -- link speed: %d Mbps %s,"
+				":auto neg %d :status-%s\n",
+				link.link_speed,
+				(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
+				 ("full-duplex") : ("half-duplex"),
+				link.link_autoneg,
+				(link.link_status) ? ("up") : ("down"));
 		}
-		printf("\t  -- promiscuous (%d)\n",
-				rte_eth_promiscuous_get(i));
+		printf("\t  -- promiscuous: %s\n",
+			rte_eth_promiscuous_get(i) ? "enabled" : "disabled");
 		ret = rte_eth_dev_get_mtu(i, &mtu);
 		if (ret == 0)
 			printf("\t  -- mtu (%d)\n", mtu);
+		printf("\t  -- multicast mode: %s\n",
+			rte_eth_allmulticast_get(i) ? "enabled" : "disabled");
 
 		ret = rte_eth_dev_info_get(i, &dev_info);
 		if (ret != 0) {
@@ -704,7 +722,17 @@ show_port(void)
 				i, strerror(-ret));
 			return;
 		}
-
+		printf("\t  -- Driver name: %s\n", dev_info.driver_name);
+		if (dev_info.device->devargs && dev_info.device->devargs->args)
+			printf("\t  -- Devargs: %s\n",
+				dev_info.device->devargs->args);
+		printf("\t  -- min size of RX buf: %u\n",
+			dev_info.min_rx_bufsize);
+		printf("\t  -- max config length of RX pkt: %u\n",
+			dev_info.max_rx_pktlen);
+
+		printf("\t  -- num of RX queues: %u\n", dev_info.nb_rx_queues);
+		printf("\t  -- num of TX queues: %u\n", dev_info.nb_tx_queues);
 		printf("  - queue\n");
 		for (j = 0; j < dev_info.nb_rx_queues; j++) {
 			ret = rte_eth_rx_queue_info_get(i, j, &queue_info);
@@ -718,7 +746,15 @@ show_port(void)
 						queue_info.nb_desc,
 						queue_info.conf.offloads,
 						queue_info.mp->socket_id);
+				printf("\t  -- mempool name: %s\n",
+						(queue_info.mp == NULL) ?
+						"NULL" : queue_info.mp->name);
+
 			}
+			rxq_count = rte_eth_rx_queue_count(i, j);
+			if (rxq_count >= 0)
+				printf("\t  -- used rx desc count: %d\n",
+						rxq_count);
 		}
 
 		ret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf);
@@ -734,7 +770,7 @@ show_port(void)
 			}
 		}
 
-		printf("  - cyrpto context\n");
+		printf("  - crypto context\n");
 #ifdef RTE_LIBRTE_SECURITY
 		void *p_ctx = rte_eth_dev_get_sec_ctx(i);
 		printf("\t  -- security context - %p\n", p_ctx);
@@ -1064,7 +1100,7 @@ display_crypto_feature_info(uint64_t x)
 	printf("\t\t  + AESNI: CPU (%c), HW (%c)\n",
 		(x & RTE_CRYPTODEV_FF_CPU_AESNI) ? 'y' : 'n',
 		(x & RTE_CRYPTODEV_FF_HW_ACCELERATED) ? 'y' : 'n');
-	printf("\t\t  + INLINE (%c)\n",
+	printf("\t\t  + SECURITY OFFLOAD(%c)\n",
 		(x & RTE_CRYPTODEV_FF_SECURITY) ? 'y' : 'n');
 	printf("\t\t  + ARM: NEON (%c), CE (%c)\n",
 		(x & RTE_CRYPTODEV_FF_CPU_NEON) ? 'y' : 'n',
@@ -1122,6 +1158,26 @@ show_crypto(void)
 				stats.dequeued_count,
 				stats.dequeue_err_count);
 		}
+#ifdef RTE_LIBRTE_SECURITY
+		void *p_ctx = rte_cryptodev_get_sec_ctx(i);
+		printf("\t  -- security context - %p\n", p_ctx);
+
+		if (p_ctx) {
+			printf("\t  -- size %u\n",
+					rte_security_session_get_size(p_ctx));
+			const struct rte_security_capability *s_cap =
+				rte_security_capabilities_get(p_ctx);
+			if (s_cap) {
+				printf("\t  -- action (0x%x), protocol (0x%x),"
+						" offload flags (0x%x)\n",
+						s_cap->action,
+						s_cap->protocol,
+						s_cap->ol_flags);
+				printf("\t  -- capabilities - oper type %x\n",
+						s_cap->crypto_capabilities->op);
+			}
+		}
+#endif
 	}
 
 	STATS_BDR_STR(50, "");
@@ -1176,8 +1232,10 @@ show_mempool(char *name)
 
 	if (name != NULL) {
 		struct rte_mempool *ptr = rte_mempool_lookup(name);
+		struct rte_mempool_ops *ops;
 		if (ptr != NULL) {
 			flags = ptr->flags;
+			ops = rte_mempool_get_ops(ptr->ops_index);
 			printf("  - Name: %s on socket %d\n"
 				"  - flags:\n"
 				"\t  -- No spread (%c)\n"
@@ -1207,6 +1265,8 @@ show_mempool(char *name)
 			printf("  - Count: avail (%u), in use (%u)\n",
 				rte_mempool_avail_count(ptr),
 				rte_mempool_in_use_count(ptr));
+			printf("  - ops_index %d ops_name %s\n",
+				ptr->ops_index, ops ? ops->name:"NA");
 
 			STATS_BDR_STR(50, "");
 			return;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info
  2020-07-11  9:53 ` [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info Hemant Agrawal
@ 2020-07-12  3:12   ` Stephen Hemminger
  2020-07-13  3:49     ` Hemant Agrawal
  2020-07-13  9:57   ` Pattan, Reshma
  2020-07-13 13:15   ` [dpdk-dev] [PATCH v3 1/2] app/proc-info: enhance mempool to print ops name Hemant Agrawal
  2 siblings, 1 reply; 10+ messages in thread
From: Stephen Hemminger @ 2020-07-12  3:12 UTC (permalink / raw)
  To: Hemant Agrawal; +Cc: dev, maryam.tahhan, reshma.pattan

On Sat, 11 Jul 2020 15:23:43 +0530
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:

> This patch enhances the port info for more details about
> the port and queues.
> This patch also add support to get info about the mempool
> ops and security context for crypto devices.
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

What ever happened to my procinfo patch series.


https://patchwork.dpdk.org/patch/69877/

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info
  2020-07-12  3:12   ` Stephen Hemminger
@ 2020-07-13  3:49     ` Hemant Agrawal
  2020-07-15  0:07       ` Stephen Hemminger
  0 siblings, 1 reply; 10+ messages in thread
From: Hemant Agrawal @ 2020-07-13  3:49 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, maryam.tahhan, reshma.pattan


-----Original Message-----
From: Stephen Hemminger <stephen@networkplumber.org> 
Sent: Sunday, July 12, 2020 8:42 AM
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org; maryam.tahhan@intel.com; reshma.pattan@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info
Importance: High

On Sat, 11 Jul 2020 15:23:43 +0530
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:

> This patch enhances the port info for more details about the port and 
> queues.
> This patch also add support to get info about the mempool ops and 
> security context for crypto devices.
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

What ever happened to my procinfo patch series.


[Hemant] I will review and rebase my patch over your series. 
You could have informed me about it during v1 review.

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.dpdk.org%2Fpatch%2F69877%2F&amp;data=02%7C01%7Chemant.agrawal%40nxp.com%7Cd616d57af9fc4dadc4d808d8261169c9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637301203517775492&amp;sdata=LZDTf1w%2B%2Bc%2BM%2BC4Ytkm2Ug6DTMCYPFartS%2FT6KwFtcQ%3D&amp;reserved=0

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info
  2020-07-11  9:53 ` [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info Hemant Agrawal
  2020-07-12  3:12   ` Stephen Hemminger
@ 2020-07-13  9:57   ` Pattan, Reshma
  2020-07-13 13:15   ` [dpdk-dev] [PATCH v3 1/2] app/proc-info: enhance mempool to print ops name Hemant Agrawal
  2 siblings, 0 replies; 10+ messages in thread
From: Pattan, Reshma @ 2020-07-13  9:57 UTC (permalink / raw)
  To: Hemant Agrawal, dev; +Cc: Tahhan, Maryam



> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> +			printf("  - ops_index %d ops_name %s\n",
> +				ptr->ops_index, ops ? ops->name:"NA");
> 

Nitpick, patch looks ok.
ERROR: spaces required around that ':' (ctx:VxV)
#233: FILE: app/proc-info/main.c:1269:
+                               ptr->ops_index, ops ? ops->name:"NA");

Thanks,
Reshma

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-dev] [PATCH v3 1/2] app/proc-info: enhance mempool to print ops name
  2020-07-11  9:53 ` [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info Hemant Agrawal
  2020-07-12  3:12   ` Stephen Hemminger
  2020-07-13  9:57   ` Pattan, Reshma
@ 2020-07-13 13:15   ` Hemant Agrawal
  2020-07-13 13:15     ` [dpdk-dev] [PATCH v3 2/2] app/proc-info: add crypto security context info Hemant Agrawal
  2 siblings, 1 reply; 10+ messages in thread
From: Hemant Agrawal @ 2020-07-13 13:15 UTC (permalink / raw)
  To: dev; +Cc: maryam.tahhan, reshma.pattan, Hemant Agrawal

Enhance the mempool details to also print the ops index and name

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
These patches are built over Stephen's series:
https://patches.dpdk.org/cover/69876/
But they can be applied independently as well.

 app/proc-info/main.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index e0b61b366..a5d16765b 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1276,7 +1276,10 @@ show_mempool(char *name)
 	if (name != NULL) {
 		struct rte_mempool *ptr = rte_mempool_lookup(name);
 		if (ptr != NULL) {
+			struct rte_mempool_ops *ops;
+
 			flags = ptr->flags;
+			ops = rte_mempool_get_ops(ptr->ops_index);
 			printf("  - Name: %s on socket %d\n"
 				"  - flags:\n"
 				"\t  -- No spread (%c)\n"
@@ -1306,6 +1309,8 @@ show_mempool(char *name)
 			printf("  - Count: avail (%u), in use (%u)\n",
 				rte_mempool_avail_count(ptr),
 				rte_mempool_in_use_count(ptr));
+			printf("  - ops_index %d ops_name %s\n",
+				ptr->ops_index, ops ? ops->name : "NA");
 
 			return;
 		}
-- 
2.17.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-dev] [PATCH v3 2/2] app/proc-info: add crypto security context info
  2020-07-13 13:15   ` [dpdk-dev] [PATCH v3 1/2] app/proc-info: enhance mempool to print ops name Hemant Agrawal
@ 2020-07-13 13:15     ` Hemant Agrawal
  0 siblings, 0 replies; 10+ messages in thread
From: Hemant Agrawal @ 2020-07-13 13:15 UTC (permalink / raw)
  To: dev; +Cc: maryam.tahhan, reshma.pattan, Hemant Agrawal

This patch adds the crypto based security context info.
Also improve the flag printing to SECURITY OFFLOAD from
INLINE.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 app/proc-info/main.c | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index a5d16765b..34acea12a 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1169,7 +1169,7 @@ display_crypto_feature_info(uint64_t x)
 	printf("\t\t  + AESNI: CPU (%c), HW (%c)\n",
 		(x & RTE_CRYPTODEV_FF_CPU_AESNI) ? 'y' : 'n',
 		(x & RTE_CRYPTODEV_FF_HW_ACCELERATED) ? 'y' : 'n');
-	printf("\t\t  + INLINE (%c)\n",
+	printf("\t\t  + SECURITY OFFLOAD (%c)\n",
 		(x & RTE_CRYPTODEV_FF_SECURITY) ? 'y' : 'n');
 	printf("\t\t  + ARM: NEON (%c), CE (%c)\n",
 		(x & RTE_CRYPTODEV_FF_CPU_NEON) ? 'y' : 'n',
@@ -1226,6 +1226,26 @@ show_crypto(void)
 				stats.dequeued_count,
 				stats.dequeue_err_count);
 		}
+#ifdef RTE_LIBRTE_SECURITY
+		void *p_ctx = rte_eth_dev_get_sec_ctx(i);
+		printf("\t  -- security context - %p\n", p_ctx);
+
+		if (p_ctx) {
+			printf("\t  -- size %u\n",
+					rte_security_session_get_size(p_ctx));
+			const struct rte_security_capability *s_cap =
+				rte_security_capabilities_get(p_ctx);
+			if (s_cap) {
+				printf("\t  -- action (0x%x), protocol (0x%x),"
+						" offload flags (0x%x)\n",
+						s_cap->action,
+						s_cap->protocol,
+						s_cap->ol_flags);
+				printf("\t  -- capabilities - oper type %x\n",
+						s_cap->crypto_capabilities->op);
+			}
+		}
+#endif
 	}
 }
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info
  2020-07-13  3:49     ` Hemant Agrawal
@ 2020-07-15  0:07       ` Stephen Hemminger
  2020-07-15  0:43         ` Hemant Agrawal
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Hemminger @ 2020-07-15  0:07 UTC (permalink / raw)
  To: Hemant Agrawal; +Cc: dev, maryam.tahhan, reshma.pattan

On Mon, 13 Jul 2020 03:49:30 +0000
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org> 
> Sent: Sunday, July 12, 2020 8:42 AM
> To: Hemant Agrawal <hemant.agrawal@nxp.com>
> Cc: dev@dpdk.org; maryam.tahhan@intel.com; reshma.pattan@intel.com
> Subject: Re: [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info
> Importance: High
> 
> On Sat, 11 Jul 2020 15:23:43 +0530
> Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> 
> > This patch enhances the port info for more details about the port and 
> > queues.
> > This patch also add support to get info about the mempool ops and 
> > security context for crypto devices.
> > 
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>  
> 
> What ever happened to my procinfo patch series.
> 
> 
> [Hemant] I will review and rebase my patch over your series. 
> You could have informed me about it during v1 review.
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.dpdk.org%2Fpatch%2F69877%2F&amp;data=02%7C01%7Chemant.agrawal%40nxp.com%7Cd616d57af9fc4dadc4d808d8261169c9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637301203517775492&amp;sdata=LZDTf1w%2B%2Bc%2BM%2BC4Ytkm2Ug6DTMCYPFartS%2FT6KwFtcQ%3D&amp;reserved=0

How about I make one series with yours added, it will be easier to merge

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info
  2020-07-15  0:07       ` Stephen Hemminger
@ 2020-07-15  0:43         ` Hemant Agrawal
  0 siblings, 0 replies; 10+ messages in thread
From: Hemant Agrawal @ 2020-07-15  0:43 UTC (permalink / raw)
  To: stephen; +Cc: dev, maryam.tahhan, reshma.pattan

Yes. Please create one series.

Get BlueMail for Android<http://www.bluemail.me/r?b=15860>
On 15 Jul 2020, at 5:37 AM, Stephen Hemminger <stephen@networkplumber.org<mailto:stephen@networkplumber.org>> wrote:

On Mon, 13 Jul 2020 03:49:30 +0000
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:

 -----Original Message-----
 From: Stephen Hemminger <stephen@networkplumber.org>
 Sent: Sunday, July 12, 2020 8:42 AM
 To: Hemant Agrawal <hemant.agrawal@nxp.com>
 Cc: dev@dpdk.org; maryam.tahhan@intel.com; reshma.pattan@intel.com
 Subject: Re: [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info
 Importance: High

 On Sat, 11 Jul 2020 15:23:43 +0530
 Hemant Agrawal <hemant.agrawal@nxp.com> wrote:

 This patch enhances the port info for more details about the port and
 queues.
 This patch also add support to get info about the mempool ops and
 security context for crypto devices.

 Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

 What ever happened to my procinfo patch series.


 [Hemant] I will review and rebase my patch over your series.
 You could have informed me about it during v1 review.

 https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.dpdk.org%2Fpatch%2F69877%2F&amp;data=02%7C01%7Chemant.agrawal%40nxp.com%7C4fecf7458e2b48b0a34e08d828531b83%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637303684690631766&amp;sdata=oZltIDgCgHTDJm4Mgs9VCrHbpUZVIREmgscZW7r2XSw%3D&amp;reserved=0

How about I make one series with yours added, it will be easier to merge

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-07-15  0:43 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-10 16:06 [dpdk-dev] [PATCH] app/procinfo: enhance port and mempool info Hemant Agrawal
2020-07-10 18:07 ` Stephen Hemminger
2020-07-11  9:53 ` [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info Hemant Agrawal
2020-07-12  3:12   ` Stephen Hemminger
2020-07-13  3:49     ` Hemant Agrawal
2020-07-15  0:07       ` Stephen Hemminger
2020-07-15  0:43         ` Hemant Agrawal
2020-07-13  9:57   ` Pattan, Reshma
2020-07-13 13:15   ` [dpdk-dev] [PATCH v3 1/2] app/proc-info: enhance mempool to print ops name Hemant Agrawal
2020-07-13 13:15     ` [dpdk-dev] [PATCH v3 2/2] app/proc-info: add crypto security context info Hemant Agrawal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).