DPDK patches and discussions
 help / color / mirror / Atom feed
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Luca Boccassi <bluca@debian.org>,
	John Alexander <John.Alexander@datapath.co.uk>
Subject: Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings
Date: Mon, 2 Nov 2020 20:05:12 -0800
Message-ID: <20201103040512.GA21662@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20201029225505.30093-1-dmitry.kozliuk@gmail.com>

On Fri, Oct 30, 2020 at 01:55:05AM +0300, Dmitry Kozlyuk wrote:
> MSBuild XML files have to use CRLF line-endings, otherwise any change
> results in the whole file being rewritten with CRLF line-endings by
> Visual Studio. However, it's inconvenient to have such files checked-out
> with CLRF in Unix environments.
> 
> Add suggested git configuration to top-level README, so that Unix
> developers don't miss it. Remove .gitattributes, because core.autocrlf
> overrides eol= attribute. Convert line-endings of the existing files in
> the repository.
> 
> Suggested-by: John Alexander <John.Alexander@datapath.co.uk>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
>  README                              |   5 +
>  windows/.gitattributes              |   4 -
>  windows/virt2phys/virt2phys.sln     |  54 ++--
>  windows/virt2phys/virt2phys.vcxproj | 454 ++++++++++++++--------------
>  4 files changed, 259 insertions(+), 258 deletions(-)
>  delete mode 100644 windows/.gitattributes
> 
> diff --git a/README b/README
> index e71dbba..0aaf58e 100644
> --- a/README
> +++ b/README
> @@ -8,3 +8,8 @@ Now the preference is to contribute kernel modules to the upstream project
>  if possible, otherwise to host kernel code in dpdk-kmods.git.
>  
>  The license can be BSD-3-Clause or GPL-2.0.
> +
> +Some Windows files use have to use CRLF line-endings.
> +Unix developers can configure git to get only LF on checkout:
> +
> +    git config core.autocrlf input

Doesn't the 'input' option gets you original (unmodified) line endings on checkout?
If a file in the repo has CRLF endings, Unix devs will get it as-is (with CRLF), right?
Regardless, this is the best option for Unix and since we're normalizing line endings for 
existing files, Unix devs should get LF on checkout.
I will send a patch to normalize netuio as well.

> diff --git a/windows/.gitattributes b/windows/.gitattributes
> deleted file mode 100644
> index 13482db..0000000
> --- a/windows/.gitattributes
> +++ /dev/null
> @@ -1,4 +0,0 @@
> -* text=auto
> -
> -*.sln text eol=crlf
> -*.vcxproj text eol=crlf
> diff --git a/windows/virt2phys/virt2phys.sln b/windows/virt2phys/virt2phys.sln
> index 0f5ecdc..ea4eec4 100644
> --- a/windows/virt2phys/virt2phys.sln
> +++ b/windows/virt2phys/virt2phys.sln
> @@ -1,27 +1,27 @@
> -
> -Microsoft Visual Studio Solution File, Format Version 12.00
> -# Visual Studio Version 16
> -VisualStudioVersion = 16.0.29613.14
> -MinimumVisualStudioVersion = 10.0.40219.1
> -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "virt2phys", "virt2phys.vcxproj", "{0EEF826B-9391-43A8-A722-BDD6F6115137}"
> -EndProject
> -Global
> -	GlobalSection(SolutionConfigurationPlatforms) = preSolution
> -		Debug|x64 = Debug|x64
> -		Release|x64 = Release|x64
> -	EndGlobalSection
> -	GlobalSection(ProjectConfigurationPlatforms) = postSolution
> -		{0EEF826B-9391-43A8-A722-BDD6F6115137}.Debug|x64.ActiveCfg = Debug|x64
> -		{0EEF826B-9391-43A8-A722-BDD6F6115137}.Debug|x64.Build.0 = Debug|x64
> -		{0EEF826B-9391-43A8-A722-BDD6F6115137}.Debug|x64.Deploy.0 = Debug|x64
> -		{0EEF826B-9391-43A8-A722-BDD6F6115137}.Release|x64.ActiveCfg = Release|x64
> -		{0EEF826B-9391-43A8-A722-BDD6F6115137}.Release|x64.Build.0 = Release|x64
> -		{0EEF826B-9391-43A8-A722-BDD6F6115137}.Release|x64.Deploy.0 = Release|x64
> -	EndGlobalSection
> -	GlobalSection(SolutionProperties) = preSolution
> -		HideSolutionNode = FALSE
> -	EndGlobalSection
> -	GlobalSection(ExtensibilityGlobals) = postSolution
> -		SolutionGuid = {845012FB-4471-4A12-A1C4-FF7E05C40E8E}
> -	EndGlobalSection
> -EndGlobal
> +
> +Microsoft Visual Studio Solution File, Format Version 12.00
> +# Visual Studio Version 16
> +VisualStudioVersion = 16.0.29613.14
> +MinimumVisualStudioVersion = 10.0.40219.1
> +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "virt2phys", "virt2phys.vcxproj", "{0EEF826B-9391-43A8-A722-BDD6F6115137}"
> +EndProject
> +Global
> +	GlobalSection(SolutionConfigurationPlatforms) = preSolution
> +		Debug|x64 = Debug|x64
> +		Release|x64 = Release|x64
> +	EndGlobalSection
> +	GlobalSection(ProjectConfigurationPlatforms) = postSolution
> +		{0EEF826B-9391-43A8-A722-BDD6F6115137}.Debug|x64.ActiveCfg = Debug|x64
> +		{0EEF826B-9391-43A8-A722-BDD6F6115137}.Debug|x64.Build.0 = Debug|x64
> +		{0EEF826B-9391-43A8-A722-BDD6F6115137}.Debug|x64.Deploy.0 = Debug|x64
> +		{0EEF826B-9391-43A8-A722-BDD6F6115137}.Release|x64.ActiveCfg = Release|x64
> +		{0EEF826B-9391-43A8-A722-BDD6F6115137}.Release|x64.Build.0 = Release|x64
> +		{0EEF826B-9391-43A8-A722-BDD6F6115137}.Release|x64.Deploy.0 = Release|x64
> +	EndGlobalSection
> +	GlobalSection(SolutionProperties) = preSolution
> +		HideSolutionNode = FALSE
> +	EndGlobalSection
> +	GlobalSection(ExtensibilityGlobals) = postSolution
> +		SolutionGuid = {845012FB-4471-4A12-A1C4-FF7E05C40E8E}
> +	EndGlobalSection
> +EndGlobal
> diff --git a/windows/virt2phys/virt2phys.vcxproj b/windows/virt2phys/virt2phys.vcxproj
> index fa51916..69af150 100644
> --- a/windows/virt2phys/virt2phys.vcxproj
> +++ b/windows/virt2phys/virt2phys.vcxproj
> @@ -1,228 +1,228 @@
> -<?xml version="1.0" encoding="utf-8"?>
> -<Project DefaultTargets="Build" ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
> -  <ItemGroup Label="ProjectConfigurations">
> -    <ProjectConfiguration Include="Debug|Win32">
> -      <Configuration>Debug</Configuration>
> -      <Platform>Win32</Platform>
> -    </ProjectConfiguration>
> -    <ProjectConfiguration Include="Release|Win32">
> -      <Configuration>Release</Configuration>
> -      <Platform>Win32</Platform>
> -    </ProjectConfiguration>
> -    <ProjectConfiguration Include="Debug|x64">
> -      <Configuration>Debug</Configuration>
> -      <Platform>x64</Platform>
> -    </ProjectConfiguration>
> -    <ProjectConfiguration Include="Release|x64">
> -      <Configuration>Release</Configuration>
> -      <Platform>x64</Platform>
> -    </ProjectConfiguration>
> -    <ProjectConfiguration Include="Debug|ARM">
> -      <Configuration>Debug</Configuration>
> -      <Platform>ARM</Platform>
> -    </ProjectConfiguration>
> -    <ProjectConfiguration Include="Release|ARM">
> -      <Configuration>Release</Configuration>
> -      <Platform>ARM</Platform>
> -    </ProjectConfiguration>
> -    <ProjectConfiguration Include="Debug|ARM64">
> -      <Configuration>Debug</Configuration>
> -      <Platform>ARM64</Platform>
> -    </ProjectConfiguration>
> -    <ProjectConfiguration Include="Release|ARM64">
> -      <Configuration>Release</Configuration>
> -      <Platform>ARM64</Platform>
> -    </ProjectConfiguration>
> -  </ItemGroup>
> -  <ItemGroup>
> -    <ClCompile Include="virt2phys.c" />
> -  </ItemGroup>
> -  <ItemGroup>
> -    <ClInclude Include="virt2phys.h" />
> -  </ItemGroup>
> -  <ItemGroup>
> -    <Inf Include="virt2phys.inf" />
> -  </ItemGroup>
> -  <PropertyGroup Label="Globals">
> -    <ProjectGuid>{0EEF826B-9391-43A8-A722-BDD6F6115137}</ProjectGuid>
> -    <TemplateGuid>{497e31cb-056b-4f31-abb8-447fd55ee5a5}</TemplateGuid>
> -    <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
> -    <MinimumVisualStudioVersion>12.0</MinimumVisualStudioVersion>
> -    <Configuration>Debug</Configuration>
> -    <Platform Condition="'$(Platform)' == ''">Win32</Platform>
> -    <RootNamespace>virt2phys</RootNamespace>
> -  </PropertyGroup>
> -  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
> -    <TargetVersion>Windows10</TargetVersion>
> -    <UseDebugLibraries>true</UseDebugLibraries>
> -    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> -    <ConfigurationType>Driver</ConfigurationType>
> -    <DriverType>KMDF</DriverType>
> -    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="Configuration">
> -    <TargetVersion>Windows10</TargetVersion>
> -    <UseDebugLibraries>false</UseDebugLibraries>
> -    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> -    <ConfigurationType>Driver</ConfigurationType>
> -    <DriverType>KMDF</DriverType>
> -    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="Configuration">
> -    <TargetVersion>Windows10</TargetVersion>
> -    <UseDebugLibraries>true</UseDebugLibraries>
> -    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> -    <ConfigurationType>Driver</ConfigurationType>
> -    <DriverType>KMDF</DriverType>
> -    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="Configuration">
> -    <TargetVersion>Windows10</TargetVersion>
> -    <UseDebugLibraries>false</UseDebugLibraries>
> -    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> -    <ConfigurationType>Driver</ConfigurationType>
> -    <DriverType>KMDF</DriverType>
> -    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM'" Label="Configuration">
> -    <TargetVersion>Windows10</TargetVersion>
> -    <UseDebugLibraries>true</UseDebugLibraries>
> -    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> -    <ConfigurationType>Driver</ConfigurationType>
> -    <DriverType>KMDF</DriverType>
> -    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM'" Label="Configuration">
> -    <TargetVersion>Windows10</TargetVersion>
> -    <UseDebugLibraries>false</UseDebugLibraries>
> -    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> -    <ConfigurationType>Driver</ConfigurationType>
> -    <DriverType>KMDF</DriverType>
> -    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'" Label="Configuration">
> -    <TargetVersion>Windows10</TargetVersion>
> -    <UseDebugLibraries>true</UseDebugLibraries>
> -    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> -    <ConfigurationType>Driver</ConfigurationType>
> -    <DriverType>KMDF</DriverType>
> -    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'" Label="Configuration">
> -    <TargetVersion>Windows10</TargetVersion>
> -    <UseDebugLibraries>false</UseDebugLibraries>
> -    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> -    <ConfigurationType>Driver</ConfigurationType>
> -    <DriverType>KMDF</DriverType>
> -    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> -  </PropertyGroup>
> -  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
> -  <ImportGroup Label="ExtensionSettings">
> -  </ImportGroup>
> -  <ImportGroup Label="PropertySheets">
> -    <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
> -  </ImportGroup>
> -  <PropertyGroup Label="UserMacros" />
> -  <PropertyGroup />
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
> -    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
> -    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
> -    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
> -    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM'">
> -    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM'">
> -    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">
> -    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> -  </PropertyGroup>
> -  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">
> -    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> -  </PropertyGroup>
> -  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
> -    <ClCompile>
> -      <WppEnabled>true</WppEnabled>
> -      <WppRecorderEnabled>true</WppRecorderEnabled>
> -      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> -      <WppKernelMode>true</WppKernelMode>
> -    </ClCompile>
> -  </ItemDefinitionGroup>
> -  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
> -    <ClCompile>
> -      <WppEnabled>true</WppEnabled>
> -      <WppRecorderEnabled>true</WppRecorderEnabled>
> -      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> -      <WppKernelMode>true</WppKernelMode>
> -    </ClCompile>
> -  </ItemDefinitionGroup>
> -  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
> -    <ClCompile>
> -      <WppEnabled>false</WppEnabled>
> -      <WppRecorderEnabled>true</WppRecorderEnabled>
> -      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> -      <WppKernelMode>true</WppKernelMode>
> -    </ClCompile>
> -    <Link>
> -      <AdditionalDependencies>$(DDK_LIB_PATH)wdmsec.lib;%(AdditionalDependencies)</AdditionalDependencies>
> -    </Link>
> -    <Inf>
> -      <TimeStamp>0.1</TimeStamp>
> -    </Inf>
> -  </ItemDefinitionGroup>
> -  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
> -    <ClCompile>
> -      <WppEnabled>true</WppEnabled>
> -      <WppRecorderEnabled>true</WppRecorderEnabled>
> -      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> -      <WppKernelMode>true</WppKernelMode>
> -    </ClCompile>
> -  </ItemDefinitionGroup>
> -  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM'">
> -    <ClCompile>
> -      <WppEnabled>true</WppEnabled>
> -      <WppRecorderEnabled>true</WppRecorderEnabled>
> -      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> -      <WppKernelMode>true</WppKernelMode>
> -    </ClCompile>
> -  </ItemDefinitionGroup>
> -  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM'">
> -    <ClCompile>
> -      <WppEnabled>true</WppEnabled>
> -      <WppRecorderEnabled>true</WppRecorderEnabled>
> -      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> -      <WppKernelMode>true</WppKernelMode>
> -    </ClCompile>
> -  </ItemDefinitionGroup>
> -  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">
> -    <ClCompile>
> -      <WppEnabled>true</WppEnabled>
> -      <WppRecorderEnabled>true</WppRecorderEnabled>
> -      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> -      <WppKernelMode>true</WppKernelMode>
> -    </ClCompile>
> -  </ItemDefinitionGroup>
> -  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">
> -    <ClCompile>
> -      <WppEnabled>true</WppEnabled>
> -      <WppRecorderEnabled>true</WppRecorderEnabled>
> -      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> -      <WppKernelMode>true</WppKernelMode>
> -    </ClCompile>
> -  </ItemDefinitionGroup>
> -  <ItemGroup>
> -    <FilesToPackage Include="$(TargetPath)" />
> -  </ItemGroup>
> -  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
> -  <ImportGroup Label="ExtensionTargets">
> -  </ImportGroup>
> +<?xml version="1.0" encoding="utf-8"?>
> +<Project DefaultTargets="Build" ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
> +  <ItemGroup Label="ProjectConfigurations">
> +    <ProjectConfiguration Include="Debug|Win32">
> +      <Configuration>Debug</Configuration>
> +      <Platform>Win32</Platform>
> +    </ProjectConfiguration>
> +    <ProjectConfiguration Include="Release|Win32">
> +      <Configuration>Release</Configuration>
> +      <Platform>Win32</Platform>
> +    </ProjectConfiguration>
> +    <ProjectConfiguration Include="Debug|x64">
> +      <Configuration>Debug</Configuration>
> +      <Platform>x64</Platform>
> +    </ProjectConfiguration>
> +    <ProjectConfiguration Include="Release|x64">
> +      <Configuration>Release</Configuration>
> +      <Platform>x64</Platform>
> +    </ProjectConfiguration>
> +    <ProjectConfiguration Include="Debug|ARM">
> +      <Configuration>Debug</Configuration>
> +      <Platform>ARM</Platform>
> +    </ProjectConfiguration>
> +    <ProjectConfiguration Include="Release|ARM">
> +      <Configuration>Release</Configuration>
> +      <Platform>ARM</Platform>
> +    </ProjectConfiguration>
> +    <ProjectConfiguration Include="Debug|ARM64">
> +      <Configuration>Debug</Configuration>
> +      <Platform>ARM64</Platform>
> +    </ProjectConfiguration>
> +    <ProjectConfiguration Include="Release|ARM64">
> +      <Configuration>Release</Configuration>
> +      <Platform>ARM64</Platform>
> +    </ProjectConfiguration>
> +  </ItemGroup>
> +  <ItemGroup>
> +    <ClCompile Include="virt2phys.c" />
> +  </ItemGroup>
> +  <ItemGroup>
> +    <ClInclude Include="virt2phys.h" />
> +  </ItemGroup>
> +  <ItemGroup>
> +    <Inf Include="virt2phys.inf" />
> +  </ItemGroup>
> +  <PropertyGroup Label="Globals">
> +    <ProjectGuid>{0EEF826B-9391-43A8-A722-BDD6F6115137}</ProjectGuid>
> +    <TemplateGuid>{497e31cb-056b-4f31-abb8-447fd55ee5a5}</TemplateGuid>
> +    <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
> +    <MinimumVisualStudioVersion>12.0</MinimumVisualStudioVersion>
> +    <Configuration>Debug</Configuration>
> +    <Platform Condition="'$(Platform)' == ''">Win32</Platform>
> +    <RootNamespace>virt2phys</RootNamespace>
> +  </PropertyGroup>
> +  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
> +    <TargetVersion>Windows10</TargetVersion>
> +    <UseDebugLibraries>true</UseDebugLibraries>
> +    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> +    <ConfigurationType>Driver</ConfigurationType>
> +    <DriverType>KMDF</DriverType>
> +    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="Configuration">
> +    <TargetVersion>Windows10</TargetVersion>
> +    <UseDebugLibraries>false</UseDebugLibraries>
> +    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> +    <ConfigurationType>Driver</ConfigurationType>
> +    <DriverType>KMDF</DriverType>
> +    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="Configuration">
> +    <TargetVersion>Windows10</TargetVersion>
> +    <UseDebugLibraries>true</UseDebugLibraries>
> +    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> +    <ConfigurationType>Driver</ConfigurationType>
> +    <DriverType>KMDF</DriverType>
> +    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="Configuration">
> +    <TargetVersion>Windows10</TargetVersion>
> +    <UseDebugLibraries>false</UseDebugLibraries>
> +    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> +    <ConfigurationType>Driver</ConfigurationType>
> +    <DriverType>KMDF</DriverType>
> +    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM'" Label="Configuration">
> +    <TargetVersion>Windows10</TargetVersion>
> +    <UseDebugLibraries>true</UseDebugLibraries>
> +    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> +    <ConfigurationType>Driver</ConfigurationType>
> +    <DriverType>KMDF</DriverType>
> +    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM'" Label="Configuration">
> +    <TargetVersion>Windows10</TargetVersion>
> +    <UseDebugLibraries>false</UseDebugLibraries>
> +    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> +    <ConfigurationType>Driver</ConfigurationType>
> +    <DriverType>KMDF</DriverType>
> +    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'" Label="Configuration">
> +    <TargetVersion>Windows10</TargetVersion>
> +    <UseDebugLibraries>true</UseDebugLibraries>
> +    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> +    <ConfigurationType>Driver</ConfigurationType>
> +    <DriverType>KMDF</DriverType>
> +    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'" Label="Configuration">
> +    <TargetVersion>Windows10</TargetVersion>
> +    <UseDebugLibraries>false</UseDebugLibraries>
> +    <PlatformToolset>WindowsKernelModeDriver10.0</PlatformToolset>
> +    <ConfigurationType>Driver</ConfigurationType>
> +    <DriverType>KMDF</DriverType>
> +    <DriverTargetPlatform>Universal</DriverTargetPlatform>
> +  </PropertyGroup>
> +  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
> +  <ImportGroup Label="ExtensionSettings">
> +  </ImportGroup>
> +  <ImportGroup Label="PropertySheets">
> +    <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
> +  </ImportGroup>
> +  <PropertyGroup Label="UserMacros" />
> +  <PropertyGroup />
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
> +    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
> +    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
> +    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
> +    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM'">
> +    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM'">
> +    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">
> +    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> +  </PropertyGroup>
> +  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">
> +    <DebuggerFlavor>DbgengKernelDebugger</DebuggerFlavor>
> +  </PropertyGroup>
> +  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
> +    <ClCompile>
> +      <WppEnabled>true</WppEnabled>
> +      <WppRecorderEnabled>true</WppRecorderEnabled>
> +      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> +      <WppKernelMode>true</WppKernelMode>
> +    </ClCompile>
> +  </ItemDefinitionGroup>
> +  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
> +    <ClCompile>
> +      <WppEnabled>true</WppEnabled>
> +      <WppRecorderEnabled>true</WppRecorderEnabled>
> +      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> +      <WppKernelMode>true</WppKernelMode>
> +    </ClCompile>
> +  </ItemDefinitionGroup>
> +  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
> +    <ClCompile>
> +      <WppEnabled>false</WppEnabled>
> +      <WppRecorderEnabled>true</WppRecorderEnabled>
> +      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> +      <WppKernelMode>true</WppKernelMode>
> +    </ClCompile>
> +    <Link>
> +      <AdditionalDependencies>$(DDK_LIB_PATH)wdmsec.lib;%(AdditionalDependencies)</AdditionalDependencies>
> +    </Link>
> +    <Inf>
> +      <TimeStamp>0.1</TimeStamp>
> +    </Inf>
> +  </ItemDefinitionGroup>
> +  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
> +    <ClCompile>
> +      <WppEnabled>true</WppEnabled>
> +      <WppRecorderEnabled>true</WppRecorderEnabled>
> +      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> +      <WppKernelMode>true</WppKernelMode>
> +    </ClCompile>
> +  </ItemDefinitionGroup>
> +  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM'">
> +    <ClCompile>
> +      <WppEnabled>true</WppEnabled>
> +      <WppRecorderEnabled>true</WppRecorderEnabled>
> +      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> +      <WppKernelMode>true</WppKernelMode>
> +    </ClCompile>
> +  </ItemDefinitionGroup>
> +  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM'">
> +    <ClCompile>
> +      <WppEnabled>true</WppEnabled>
> +      <WppRecorderEnabled>true</WppRecorderEnabled>
> +      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> +      <WppKernelMode>true</WppKernelMode>
> +    </ClCompile>
> +  </ItemDefinitionGroup>
> +  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">
> +    <ClCompile>
> +      <WppEnabled>true</WppEnabled>
> +      <WppRecorderEnabled>true</WppRecorderEnabled>
> +      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> +      <WppKernelMode>true</WppKernelMode>
> +    </ClCompile>
> +  </ItemDefinitionGroup>
> +  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">
> +    <ClCompile>
> +      <WppEnabled>true</WppEnabled>
> +      <WppRecorderEnabled>true</WppRecorderEnabled>
> +      <WppScanConfigurationData Condition="'%(ClCompile.ScanConfigurationData)' == ''">trace.h</WppScanConfigurationData>
> +      <WppKernelMode>true</WppKernelMode>
> +    </ClCompile>
> +  </ItemDefinitionGroup>
> +  <ItemGroup>
> +    <FilesToPackage Include="$(TargetPath)" />
> +  </ItemGroup>
> +  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
> +  <ImportGroup Label="ExtensionTargets">
> +  </ImportGroup>
>  </Project>
> \ No newline at end of file
> -- 
> 2.28.0

  reply	other threads:[~2020-11-03  4:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 22:55 Dmitry Kozlyuk
2020-11-03  4:05 ` Narcisa Ana Maria Vasile [this message]
2020-11-03  7:42   ` Dmitry Kozlyuk
2020-11-03 10:05     ` Luca Boccassi
2020-11-11 15:02       ` Luca Boccassi
2020-11-11 15:11       ` Dmitry Kozlyuk
2020-11-03 20:49 ` Narcisa Ana Maria Vasile
2020-11-11 15:02 ` Thomas Monjalon
2020-11-11 15:03   ` Luca Boccassi
2020-11-11 15:09     ` Luca Boccassi
2020-11-12 20:16       ` Luca Boccassi
2020-11-12 20:15 ` [dpdk-dev] [kmods PATCH v2] " luca.boccassi
2020-11-12 23:17   ` Thomas Monjalon
2020-11-13  7:06   ` Dmitry Kozlyuk
2020-11-13  9:43     ` Thomas Monjalon
2020-11-13  9:52       ` Luca Boccassi
2020-11-13  9:50 ` [dpdk-dev] [kmods PATCH v3 1/2] windows: remove .gitattributes luca.boccassi
2020-11-13  9:50   ` [dpdk-dev] [kmods PATCH v3 2/2] windows: normalize line-endings luca.boccassi
2020-11-13 15:12     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103040512.GA21662@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=navasile@linux.microsoft.com \
    --cc=John.Alexander@datapath.co.uk \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git