[dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init

[dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init

[Changsheng Wu]

The testsuite_setup function in the compressdev_autotest test case, 
the rte_compressdev_count() return 0 due to the lack of device init. 
It is considered that there is no equitment to skip execution. 
So add rte_vdev_init init compress_zlib device. 

Signed-off-by: Changsheng Wu <wuchangsheng2@huawei.com>
---
 app/test/test_compressdev.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
index a1b9f06250..f15fbe7f2d 100644
--- a/app/test/test_compressdev.c
+++ b/app/test/test_compressdev.c
@@ -14,6 +14,7 @@
 #include <rte_mbuf.h>
 #include <rte_compressdev.h>
 #include <rte_string_fns.h>
+#include <rte_bus_vdev.h>
 
 #include "test_compressdev_test_buffer.h"
 #include "test.h"
@@ -197,6 +198,11 @@ testsuite_setup(void)
 	uint32_t max_buf_size = 0;
 	unsigned int i;
 
+	if (rte_vdev_init("compress_zlib", NULL) != 0) {
+		RTE_LOG(WARNING, USER1, "not find compress_zlib device\n");
+		return TEST_SKIPPED;
+	}
+
 	if (rte_compressdev_count() == 0) {
 		RTE_LOG(WARNING, USER1, "Need at least one compress device\n");
 		return TEST_SKIPPED;
-- 
2.27.0

RE: [EXT] [dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init

[Akhil Goyal]

> The testsuite_setup function in the compressdev_autotest test case,
> the rte_compressdev_count() return 0 due to the lack of device init.
> It is considered that there is no equitment to skip execution.
> So add rte_vdev_init init compress_zlib device.

Why? Devices can be added as command line argument.
* Use ``--vdev="compress_isal"`` in the EAL options, which will call ``rte_vdev_init()`` internally.
See documentation of compressdevs.

And if at all it is required, why only the zlib, there are other devices as well.


> 
> Signed-off-by: Changsheng Wu <wuchangsheng2@huawei.com>
> ---
>  app/test/test_compressdev.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> index a1b9f06250..f15fbe7f2d 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -14,6 +14,7 @@
>  #include <rte_mbuf.h>
>  #include <rte_compressdev.h>
>  #include <rte_string_fns.h>
> +#include <rte_bus_vdev.h>
> 
>  #include "test_compressdev_test_buffer.h"
>  #include "test.h"
> @@ -197,6 +198,11 @@ testsuite_setup(void)
>  	uint32_t max_buf_size = 0;
>  	unsigned int i;
> 
> +	if (rte_vdev_init("compress_zlib", NULL) != 0) {
> +		RTE_LOG(WARNING, USER1, "not find compress_zlib
> device\n");
> +		return TEST_SKIPPED;
> +	}
> +
>  	if (rte_compressdev_count() == 0) {
>  		RTE_LOG(WARNING, USER1, "Need at least one compress
> device\n");
>  		return TEST_SKIPPED;
> --
> 2.27.0

RE: [EXT] [dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init

[Akhil Goyal]

> > The testsuite_setup function in the compressdev_autotest test case,
> > the rte_compressdev_count() return 0 due to the lack of device init.
> > It is considered that there is no equitment to skip execution.
> > So add rte_vdev_init init compress_zlib device.
> 
> Why? Devices can be added as command line argument.
> * Use ``--vdev="compress_isal"`` in the EAL options, which will call
> ``rte_vdev_init()`` internally.
> See documentation of compressdevs.
> 
> And if at all it is required, why only the zlib, there are other devices as well.
> 
Please mark your previous versions of patches as superseded in patchworks.
It creates confusion when you change the title of the patch.