DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction
@ 2016-09-16 16:02 Karmarkar Suyash
  2016-09-21 17:08 ` Karmarkar Suyash
  0 siblings, 1 reply; 12+ messages in thread
From: Karmarkar Suyash @ 2016-09-16 16:02 UTC (permalink / raw)
  To: dev; +Cc: thomas.monjalon, rsanford, reshma.pattan, Karmarkar Suyash

For Periodic timers ,if the lag gets introduced, the current code 
added additional delay when the next peridoc timer was initialized 
by not taking into account the delay added, with this fix the code 
would start the next occurrence of timer keeping in account the 
lag added.Corrected the behavior.

Fixes:ba885531ac26 ("rte_timer: timer lag issue")

Karmarkar Suyash (1):
  Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com>

 lib/librte_timer/rte_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 
---
 lib/librte_timer/rte_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
index 43da836..18782fa 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -613,7 +613,7 @@ void rte_timer_manage(void)
 			status.owner = (int16_t)lcore_id;
 			rte_wmb();
 			tim->status.u32 = status.u32;
-			__rte_timer_reset(tim, cur_time + tim->period,
+			__rte_timer_reset(tim, tim->expire + tim->period,
 				tim->period, lcore_id, tim->f, tim->arg, 1);
 			rte_spinlock_unlock(&priv_timer[lcore_id].list_lock);
 		}

-- 
2.9.3.windows.1

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction
@ 2016-09-16 15:58 Karmarkar Suyash
  0 siblings, 0 replies; 12+ messages in thread
From: Karmarkar Suyash @ 2016-09-16 15:58 UTC (permalink / raw)
  To: dev; +Cc: Karmarkar Suyash

For Periodic timers ,if the lag gets introduced, the current code 
added additional delay when the next peridoc timer was initialized 
by not taking into account the delay added, with this fix the code 
would start the next occurrence of timer keeping in account the 
lag added.Corrected the behavior.

Fixes:ba885531ac26 ("rte_timer: timer lag issue")

Karmarkar Suyash (1):
  Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com>

 lib/librte_timer/rte_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 
---
 lib/librte_timer/rte_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
index 43da836..18782fa 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -613,7 +613,7 @@ void rte_timer_manage(void)
 			status.owner = (int16_t)lcore_id;
 			rte_wmb();
 			tim->status.u32 = status.u32;
-			__rte_timer_reset(tim, cur_time + tim->period,
+			__rte_timer_reset(tim, tim->expire + tim->period,
 				tim->period, lcore_id, tim->f, tim->arg, 1);
 			rte_spinlock_unlock(&priv_timer[lcore_id].list_lock);
 		}

-- 
2.9.3.windows.1

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2016-10-05 10:06 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-16 16:02 [dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction Karmarkar Suyash
2016-09-21 17:08 ` Karmarkar Suyash
2016-09-21 20:03   ` Thomas Monjalon
2016-09-21 20:54   ` Karmarkar Suyash
2016-09-29 14:27     ` Karmarkar Suyash
2016-10-04 19:31       ` Karmarkar Suyash
2016-10-04 20:51         ` Sanford, Robert
2016-10-04 21:39       ` Sanford, Robert
2016-10-04 22:36         ` Karmarkar Suyash
2016-10-05  9:34           ` Pattan, Reshma
2016-10-05 10:06         ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2016-09-16 15:58 Karmarkar Suyash

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).