DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ivan Malov <Ivan.Malov@oktetlabs.ru>,
	dev@dpdk.org, Andrey Vesnovaty <andreyv@nvidia.com>
Cc: Xueming Li <xuemingl@nvidia.com>, Ori Kam <orika@nvidia.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf
Date: Tue, 3 Nov 2020 15:52:40 +0000
Message-ID: <3bcf1f2f-869c-590b-9c03-c2dc9b32d97b@intel.com> (raw)
In-Reply-To: <7a9b6c06-ac7e-e1f7-e6e9-6856d2bb90a3@oktetlabs.ru>

On 11/3/2020 2:10 PM, Ivan Malov wrote:
> Hi Ferruh,
> 
> On 02/11/2020 21:54, Ferruh Yigit wrote:
>> On 11/2/2020 11:43 AM, Ivan Malov wrote:
>>> In a flow rule, attribute "transfer" means operation level
>>> at which both traffic is matched and actions are conducted.
>>>
>>> Add the very same attribute to shared action configuration.
>>> If a driver needs to prepare HW resources in two different
>>> ways, depending on the operation level, in order to set up
>>> an action, then this new attribute will indicate the level.
>>> Also, when handling a flow rule insertion, the driver will
>>> be able to turn down a shared action if its level is unfit.
>>>
>>> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
>>> Acked-by: Ori Kam <orika@nvidia.com>
>>> ---
>>>   lib/librte_ethdev/rte_flow.h | 8 ++++++++
>>>   1 file changed, 8 insertions(+)
>>>
>>> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
>>> index a8eac4deb..8b970ba0b 100644
>>> --- a/lib/librte_ethdev/rte_flow.h
>>> +++ b/lib/librte_ethdev/rte_flow.h
>>> @@ -3487,6 +3487,14 @@ struct rte_flow_shared_action_conf {
>>>       /**< Action valid for rules applied to ingress traffic. */
>>>       uint32_t egress:1;
>>>       /**< Action valid for rules applied to egress traffic. */
>>> +
>>> +    /**
>>> +     * When set to 1, indicates that the action is valid for
>>> +     * transfer traffic; otherwise, for non-transfer traffic.
>>> +     *
>>> +     * See struct rte_flow_attr.
>>> +     */
>>> +    uint32_t transfer:1;
>>
>> Is this require any documentation update?
>>
>> Also cc'ed Andrey, as he is author of the shared action feature, @Andrey can 
>> you please review this update?
> 
> Many-many thanks to you for reviewing the patch. And thanks for inviting 
> @Andrey. I should've done that from the very beginning.
> 
> What's for documentation update, = I did take a look at 
> "doc/guides/prog_guide/rte_flow.rst" after Ori had suggested to do so. As far as 
> I can learn from the file, the convention is to describe the action structure 
> itself, i.e. not any auxiliary structures.
> 
> For example, direct input to action SHARED is "struct rte_flow_shared_action". 
> And it's already described by an empty table ("table:: SHARED") in the doc file.
> 
> On the other hand, documentation of "struct rte_flow_shared_action_conf" belongs 
> in a place where the API rte_flow_shared_action_create() is documented. This API 
> is only mentioned by "doc/guides/prog_guide/rte_flow.rst", and it looks like 
> it's not documented anywhere but in the header file itself 
> ("lib/librte_ethdev/rte_flow.h").
> 
> So, it looks like this particular patch does not need to provide an update to 
> documentation other that the existing comment before the field in the structure.
> 

I missed that Ori requested same before, and I agree on your documentation 
analysis above, there is not clear location to put this other than doxygen 
comment, so OK to proceed as it is.

  reply	other threads:[~2020-11-03 15:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 11:46 [dpdk-dev] [PATCH " Ivan Malov
2020-10-29 11:46 ` [dpdk-dev] [PATCH 2/2] app/testpmd: support shared flow action attribute transfer Ivan Malov
2020-10-29 12:37 ` [dpdk-dev] [PATCH 1/2] ethdev: introduce transfer attribute to shared action conf Ferruh Yigit
2020-10-29 12:54   ` Andrew Rybchenko
2020-10-30 15:49 ` Xueming(Steven) Li
2020-10-30 20:35   ` Ivan Malov
2020-11-01  8:11     ` Ori Kam
2020-11-01  9:35       ` Ori Kam
2020-11-02  9:37         ` Ori Kam
2020-11-02 11:35 ` [dpdk-dev] [PATCH v2 " Ivan Malov
2020-11-02 11:35   ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: support shared flow action attribute transfer Ivan Malov
2020-11-02 11:43 ` [dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf Ivan Malov
2020-11-02 11:43   ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: support shared flow action attribute transfer Ivan Malov
2020-11-02 14:04     ` Ori Kam
2020-11-02 13:15   ` [dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf Andrew Rybchenko
2020-11-02 21:44     ` Ajit Khaparde
2020-11-02 18:54   ` Ferruh Yigit
2020-11-03 14:10     ` Ivan Malov
2020-11-03 15:52       ` Ferruh Yigit [this message]
2020-11-03 14:20     ` Andrey Vesnovaty
2020-11-03 16:05       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bcf1f2f-869c-590b-9c03-c2dc9b32d97b@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=Ivan.Malov@oktetlabs.ru \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=andreyv@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=orika@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git