Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf

[Andrey Vesnovaty <andreyv@nvidia.com>]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, November 2, 2020 8:55 PM
> To: Ivan Malov <ivan.malov@oktetlabs.ru>; dev@dpdk.org; Andrey Vesnovaty
> <andreyv@nvidia.com>
> Cc: Xueming(Steven) Li <xuemingl@nvidia.com>; Ori Kam <orika@nvidia.com>;
> NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>
> Subject: Re: [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action
> conf
> 
> On 11/2/2020 11:43 AM, Ivan Malov wrote:
> > In a flow rule, attribute "transfer" means operation level
> > at which both traffic is matched and actions are conducted.
> >
> > Add the very same attribute to shared action configuration.
> > If a driver needs to prepare HW resources in two different
> > ways, depending on the operation level, in order to set up
> > an action, then this new attribute will indicate the level.
> > Also, when handling a flow rule insertion, the driver will
> > be able to turn down a shared action if its level is unfit.
> >
> > Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> > Acked-by: Ori Kam <orika@nvidia.com>
> > ---
> >   lib/librte_ethdev/rte_flow.h | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> > index a8eac4deb..8b970ba0b 100644
> > --- a/lib/librte_ethdev/rte_flow.h
> > +++ b/lib/librte_ethdev/rte_flow.h
> > @@ -3487,6 +3487,14 @@ struct rte_flow_shared_action_conf {
> >   	/**< Action valid for rules applied to ingress traffic. */
> >   	uint32_t egress:1;
> >   	/**< Action valid for rules applied to egress traffic. */
> > +
> > +	/**
> > +	 * When set to 1, indicates that the action is valid for
> > +	 * transfer traffic; otherwise, for non-transfer traffic.
> > +	 *
> > +	 * See struct rte_flow_attr.
> > +	 */
> > +	uint32_t transfer:1;
> 
> Is this require any documentation update?
> 
> Also cc'ed Andrey, as he is author of the shared action feature, @Andrey can
> you
> please review this update?

Acked-by: Andrey Vesnovaty <andreyv@nvidia.com>