DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Fiona Trahe <fiona.trahe@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
	"tomaszx.jozwiak@intel.com" <tomaszx.jozwiak@intel.com>,
	"arkadiuszx.kusztal@intel.com" <arkadiuszx.kusztal@intel.com>
Subject: Re: [dpdk-dev] [PATCH v6] compress/qat: enable dynamic huffman encoding
Date: Thu, 25 Oct 2018 07:34:39 +0000	[thread overview]
Message-ID: <790af281-10eb-9a61-bddd-7051490f8e1b@nxp.com> (raw)
In-Reply-To: <1540431029-9742-1-git-send-email-fiona.trahe@intel.com>

Hi Fiona,

On 10/25/2018 7:00 AM, Fiona Trahe wrote:
> Enable dynamic huffman encoding in the QAT comp PMD.
>
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> Acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---

The patch is still failing in i686 and armv7

**************** Testing i686 ***********************
In file included from 
/home/b35197/dpdk/drivers/common/qat/qat_device.h:10:0,
                  from 
/home/b35197/dpdk/drivers/compress/qat/qat_comp_pmd.h:13,
                  from 
/home/b35197/dpdk/drivers/compress/qat/qat_comp_pmd.c:6:
/home/b35197/dpdk/drivers/compress/qat/qat_comp_pmd.c: In function 
âqat_comp_setup_inter_buffersâ:
/home/b35197/dpdk/drivers/common/qat/qat_logs.h:13:4: error: format 
â%ldâ expects argument of type âlong intâ, but argument 9 has type 
âsize_t {aka const unsigned int}â [-Werror=format=]
     "%s(): " fmt "\n", __func__, ## args)
     ^
/home/b35197/dpdk/drivers/compress/qat/qat_comp_pmd.c:194:2: note: in 
expansion of macro âQAT_LOGâ
   QAT_LOG(DEBUG, "Memzone %s: addr = %p, phys = 0x%"PRIx64
   ^~~~~~~
/home/b35197/dpdk/drivers/compress/qat/qat_comp_pmd.c:195:40: note: 
format string is defined here
     ", size required %d, size created %ld",
                                       ~~^
                                       %d
cc1: all warnings being treated as errors
make[5]: *** [qat_comp_pmd.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [common/qat] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [drivers] Error 2
make[2]: *** [all] Error 2
make[1]: *** [pre_install] Error 2
make: *** [install] Error 2
Error in BUILD
**************** Testing armv7 ***********************
/home/b35197/dpdk/drivers/compress/qat/qat_comp.c: In function 
'qat_comp_build_request':
/home/b35197/dpdk/drivers/compress/qat/qat_comp.c:33:6: warning: cast 
increases required alignment of target type [-Wcast-align]
       (struct icp_qat_fw_comp_req *)out_msg;
       ^
/home/b35197/dpdk/drivers/compress/qat/qat_comp.c: In function 
'qat_comp_process_response':
/home/b35197/dpdk/drivers/compress/qat/qat_comp.c:112:4: warning: cast 
increases required alignment of target type [-Wcast-align]
     (struct icp_qat_fw_comp_resp *)resp;
     ^
/home/b35197/dpdk/drivers/compress/qat/qat_comp.c:146:6: warning: cast 
increases required alignment of target type [-Wcast-align]
     *((uint16_t *)(&resp_msg->comn_resp.comn_error));
       ^
In file included from 
/home/b35197/dpdk/drivers/common/qat/qat_device.h:10:0,
                  from 
/home/b35197/dpdk/drivers/compress/qat/qat_comp_pmd.h:13,
                  from 
/home/b35197/dpdk/drivers/compress/qat/qat_comp_pmd.c:6:
/home/b35197/dpdk/drivers/compress/qat/qat_comp_pmd.c: In function 
'qat_comp_setup_inter_buffers':
/home/b35197/dpdk/drivers/common/qat/qat_logs.h:13:4: error: format 
'%ld' expects argument of type 'long int', but argument 9 has type 
'size_t {aka const unsigned int}' [-Werror=format=]
     "%s(): " fmt "\n", __func__, ## args)
     ^
/home/b35197/dpdk/drivers/compress/qat/qat_comp_pmd.c:194:2: note: in 
expansion of macro 'QAT_LOG'
   QAT_LOG(DEBUG, "Memzone %s: addr = %p, phys = 0x%"PRIx64
   ^
/home/b35197/dpdk/drivers/compress/qat/qat_comp_pmd.c:199:22: warning: 
cast increases required alignment of target type [-Wcast-align]
   array_of_pointers = (struct array_of_ptrs *)mz_start;
                       ^
/home/b35197/dpdk/drivers/compress/qat/qat_comp_pmd.c:204:7: warning: 
cast increases required alignment of target type [-Wcast-align]
        (struct qat_inter_sgl *)(mz_start + curr_sgl_offset);
        ^
cc1: all warnings being treated as errors
make[5]: *** [qat_comp_pmd.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [common/qat] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [drivers] Error 2
make[2]: *** [all] Error 2
make[1]: *** [pre_install] Error 2
make: *** [install] Error 2
Error in BUILD



  reply	other threads:[~2018-10-25  7:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 17:46 [dpdk-dev] [PATCH] " Fiona Trahe
2018-10-05 16:18 ` [dpdk-dev] [PATCH v2] " Fiona Trahe
2018-10-09 11:01   ` Akhil Goyal
2018-10-09 14:09     ` Trahe, Fiona
2018-10-12 11:39       ` Akhil Goyal
2018-10-11 17:03   ` [dpdk-dev] [PATCH v3] " Fiona Trahe
2018-10-15 23:16     ` [dpdk-dev] [PATCH v4] " Fiona Trahe
2018-10-17 10:29       ` Kusztal, ArkadiuszX
2018-10-17 20:48       ` [dpdk-dev] [PATCH v5] " Fiona Trahe
2018-10-24 14:15         ` Akhil Goyal
2018-10-24 21:30           ` Thomas Monjalon
2018-10-25  0:40             ` Trahe, Fiona
2018-10-25  6:45               ` Thomas Monjalon
2018-10-25  1:30         ` [dpdk-dev] [PATCH v6] " Fiona Trahe
2018-10-25  7:34           ` Akhil Goyal [this message]
2018-10-26 18:18           ` [dpdk-dev] [PATCH v7] " Fiona Trahe
2018-10-27  0:06             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=790af281-10eb-9a61-bddd-7051490f8e1b@nxp.com \
    --to=akhil.goyal@nxp.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=thomas@monjalon.net \
    --cc=tomaszx.jozwiak@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).