DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: do not select legacy MPW implicitly
@ 2020-06-11 17:42 Alexander Kozyrev
  2020-06-12 19:59 ` Slava Ovsiienko
  2020-06-15  8:51 ` Raslan Darawsheh
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Kozyrev @ 2020-06-11 17:42 UTC (permalink / raw)
  To: dev; +Cc: stable, rasland, viacheslavo

The Legacy MPW (multi-packet write) should not be engaged implicitly.
We should exclude this function form a Tx burst routine selection process
unless it is requested specifically by setting the txq_mpw_en devarg.
Exclude this function from the selection process the same way it is done
for the Enhanced MPW in the mlx5_select_tx_function() routine.

Fixes: eb8121ab9dac ("net/mlx5: introduce Tx burst routine template")
Cc: stable@dpdk.org

Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxtx.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 6a17a9a..df58af5 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -5542,6 +5542,9 @@ enum mlx5_txcmp_code {
 			/* Does not meet requested offloads at all. */
 			continue;
 		}
+		if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_MPW)
+			/* Do not enable legacy MPW if not configured. */
+			continue;
 		if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_EMPW)
 			/* Do not enable eMPW if not configured. */
 			continue;
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: do not select legacy MPW implicitly
  2020-06-11 17:42 [dpdk-dev] [PATCH] net/mlx5: do not select legacy MPW implicitly Alexander Kozyrev
@ 2020-06-12 19:59 ` Slava Ovsiienko
  2020-06-15  8:51 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Slava Ovsiienko @ 2020-06-12 19:59 UTC (permalink / raw)
  To: Alexander Kozyrev, dev; +Cc: stable, Raslan Darawsheh

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@mellanox.com>
> Sent: Thursday, June 11, 2020 20:42
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>; Slava
> Ovsiienko <viacheslavo@mellanox.com>
> Subject: [PATCH] net/mlx5: do not select legacy MPW implicitly
> 
> The Legacy MPW (multi-packet write) should not be engaged implicitly.
> We should exclude this function form a Tx burst routine selection process
> unless it is requested specifically by setting the txq_mpw_en devarg.
> Exclude this function from the selection process the same way it is done for
> the Enhanced MPW in the mlx5_select_tx_function() routine.
> 
> Fixes: eb8121ab9dac ("net/mlx5: introduce Tx burst routine template")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

> ---
>  drivers/net/mlx5/mlx5_rxtx.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 6a17a9a..df58af5 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -5542,6 +5542,9 @@ enum mlx5_txcmp_code {
>  			/* Does not meet requested offloads at all. */
>  			continue;
>  		}
> +		if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_MPW)
> +			/* Do not enable legacy MPW if not configured. */
> +			continue;
>  		if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_EMPW)
>  			/* Do not enable eMPW if not configured. */
>  			continue;
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: do not select legacy MPW implicitly
  2020-06-11 17:42 [dpdk-dev] [PATCH] net/mlx5: do not select legacy MPW implicitly Alexander Kozyrev
  2020-06-12 19:59 ` Slava Ovsiienko
@ 2020-06-15  8:51 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2020-06-15  8:51 UTC (permalink / raw)
  To: Alexander Kozyrev, dev; +Cc: stable, Slava Ovsiienko

Hi,

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@mellanox.com>
> Sent: Thursday, June 11, 2020 8:42 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>; Slava
> Ovsiienko <viacheslavo@mellanox.com>
> Subject: [PATCH] net/mlx5: do not select legacy MPW implicitly
> 
> The Legacy MPW (multi-packet write) should not be engaged implicitly.
> We should exclude this function form a Tx burst routine selection process
> unless it is requested specifically by setting the txq_mpw_en devarg.
> Exclude this function from the selection process the same way it is done
> for the Enhanced MPW in the mlx5_select_tx_function() routine.
> 
> Fixes: eb8121ab9dac ("net/mlx5: introduce Tx burst routine template")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_rxtx.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 6a17a9a..df58af5 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -5542,6 +5542,9 @@ enum mlx5_txcmp_code {
>  			/* Does not meet requested offloads at all. */
>  			continue;
>  		}
> +		if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_MPW)
> +			/* Do not enable legacy MPW if not configured. */
> +			continue;
>  		if ((olx ^ tmp) & MLX5_TXOFF_CONFIG_EMPW)
>  			/* Do not enable eMPW if not configured. */
>  			continue;
> --
> 1.8.3.1


Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-15  8:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11 17:42 [dpdk-dev] [PATCH] net/mlx5: do not select legacy MPW implicitly Alexander Kozyrev
2020-06-12 19:59 ` Slava Ovsiienko
2020-06-15  8:51 ` Raslan Darawsheh

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git