* Re: [PATCH v1] config/arm: correct cpu arch for cross build
2023-08-22 7:47 [PATCH v1] config/arm: correct cpu arch for cross build Joyce Kong
@ 2023-10-17 19:41 ` Thomas Monjalon
2023-10-18 5:40 ` Joyce Kong
2023-11-07 3:26 ` [PATCH v2] " Joyce Kong
` (2 subsequent siblings)
3 siblings, 1 reply; 28+ messages in thread
From: Thomas Monjalon @ 2023-10-17 19:41 UTC (permalink / raw)
To: Joyce Kong; +Cc: Ruifeng Wang, Bruce Richardson, dev, nd
22/08/2023 09:47, Joyce Kong:
> The cn10k cross build file sets cpu to 'armv8.6-a' while
> N2 is armv8.5-a arch.
> The cpu field in the cross file doesn't take effect as
> config/arm/meson.build controls machine_args for march.
> Then correct the value in arm cross files to 'auto'.
I don't get it.
Why setting a value if it has no impact?
Looks like something is overcomplicated.
^ permalink raw reply [flat|nested] 28+ messages in thread* RE: [PATCH v1] config/arm: correct cpu arch for cross build
2023-10-17 19:41 ` Thomas Monjalon
@ 2023-10-18 5:40 ` Joyce Kong
2023-11-06 14:10 ` Thomas Monjalon
0 siblings, 1 reply; 28+ messages in thread
From: Joyce Kong @ 2023-10-18 5:40 UTC (permalink / raw)
To: thomas; +Cc: Ruifeng Wang, Bruce Richardson, dev, nd
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, October 18, 2023 3:42 AM
> To: Joyce Kong <Joyce.Kong@arm.com>
> Cc: Ruifeng Wang <Ruifeng.Wang@arm.com>; Bruce Richardson
> <bruce.richardson@intel.com>; dev@dpdk.org; nd <nd@arm.com>
> Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build
>
> 22/08/2023 09:47, Joyce Kong:
> > The cn10k cross build file sets cpu to 'armv8.6-a' while
> > N2 is armv8.5-a arch.
> > The cpu field in the cross file doesn't take effect as
> > config/arm/meson.build controls machine_args for march.
> > Then correct the value in arm cross files to 'auto'.
>
> I don't get it.
> Why setting a value if it has no impact?
> Looks like something is overcomplicated.
>
We still have to declare them here because meson would check the 'cpu' line in the config file, otherwise it would report missing {'cpu'}.
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v1] config/arm: correct cpu arch for cross build
2023-10-18 5:40 ` Joyce Kong
@ 2023-11-06 14:10 ` Thomas Monjalon
2023-11-06 14:31 ` Joyce Kong
0 siblings, 1 reply; 28+ messages in thread
From: Thomas Monjalon @ 2023-11-06 14:10 UTC (permalink / raw)
To: Ruifeng Wang, Joyce Kong; +Cc: dev, Bruce Richardson, dev, nd, Paul Szczepanek
18/10/2023 07:40, Joyce Kong:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > 22/08/2023 09:47, Joyce Kong:
> > > The cn10k cross build file sets cpu to 'armv8.6-a' while
> > > N2 is armv8.5-a arch.
> > > The cpu field in the cross file doesn't take effect as
> > > config/arm/meson.build controls machine_args for march.
> > > Then correct the value in arm cross files to 'auto'.
> >
> > I don't get it.
> > Why setting a value if it has no impact?
> > Looks like something is overcomplicated.
> >
> We still have to declare them here because meson would check the 'cpu' line in the config file, otherwise it would report missing {'cpu'}.
OK
Then why not all cross files are set to auto?
^ permalink raw reply [flat|nested] 28+ messages in thread* RE: [PATCH v1] config/arm: correct cpu arch for cross build
2023-11-06 14:10 ` Thomas Monjalon
@ 2023-11-06 14:31 ` Joyce Kong
2023-11-06 15:38 ` Thomas Monjalon
0 siblings, 1 reply; 28+ messages in thread
From: Joyce Kong @ 2023-11-06 14:31 UTC (permalink / raw)
To: thomas, Ruifeng Wang; +Cc: dev, Bruce Richardson, dev, nd, Paul Szczepanek
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, November 6, 2023 10:10 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Joyce Kong
> <Joyce.Kong@arm.com>
> Cc: dev@dpdk.org; Bruce Richardson <bruce.richardson@intel.com>;
> dev@dpdk.org; nd <nd@arm.com>; Paul Szczepanek
> <Paul.Szczepanek@arm.com>
> Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build
>
> 18/10/2023 07:40, Joyce Kong:
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > 22/08/2023 09:47, Joyce Kong:
> > > > The cn10k cross build file sets cpu to 'armv8.6-a' while
> > > > N2 is armv8.5-a arch.
> > > > The cpu field in the cross file doesn't take effect as
> > > > config/arm/meson.build controls machine_args for march.
> > > > Then correct the value in arm cross files to 'auto'.
> > >
> > > I don't get it.
> > > Why setting a value if it has no impact?
> > > Looks like something is overcomplicated.
> > >
> > We still have to declare them here because meson would check the 'cpu'
> line in the config file, otherwise it would report missing {'cpu'}.
>
> OK
>
> Then why not all cross files are set to auto?
>
Actually, I set all the Arm cross files to auto in this patch. Maybe I have to figure it out in the commit line?
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v1] config/arm: correct cpu arch for cross build
2023-11-06 14:31 ` Joyce Kong
@ 2023-11-06 15:38 ` Thomas Monjalon
2023-11-07 2:42 ` Joyce Kong
0 siblings, 1 reply; 28+ messages in thread
From: Thomas Monjalon @ 2023-11-06 15:38 UTC (permalink / raw)
To: Ruifeng Wang; +Cc: dev, Bruce Richardson, nd, Paul Szczepanek, Joyce Kong
06/11/2023 15:31, Joyce Kong:
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Monday, November 6, 2023 10:10 PM
> > To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Joyce Kong
> > <Joyce.Kong@arm.com>
> > Cc: dev@dpdk.org; Bruce Richardson <bruce.richardson@intel.com>;
> > dev@dpdk.org; nd <nd@arm.com>; Paul Szczepanek
> > <Paul.Szczepanek@arm.com>
> > Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build
> >
> > 18/10/2023 07:40, Joyce Kong:
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 22/08/2023 09:47, Joyce Kong:
> > > > > The cn10k cross build file sets cpu to 'armv8.6-a' while
> > > > > N2 is armv8.5-a arch.
> > > > > The cpu field in the cross file doesn't take effect as
> > > > > config/arm/meson.build controls machine_args for march.
> > > > > Then correct the value in arm cross files to 'auto'.
> > > >
> > > > I don't get it.
> > > > Why setting a value if it has no impact?
> > > > Looks like something is overcomplicated.
> > > >
> > > We still have to declare them here because meson would check the 'cpu'
> > line in the config file, otherwise it would report missing {'cpu'}.
> >
> > OK
> >
> > Then why not all cross files are set to auto?
> >
> Actually, I set all the Arm cross files to auto in this patch. Maybe I have to figure it out in the commit line?
What about these ones?
git grep 'cpu = ' config/arm | grep -v auto
config/arm/arm64_altra_linux_gcc:cpu = 'armv8.2-a'
config/arm/arm64_ampereone_linux_gcc:cpu = 'armv8.6-a'
config/arm/arm64_bluefield3_linux_gcc:cpu = 'armv8.4-a'
config/arm/arm64_cdx_linux_gcc:cpu = 'armv8-a'
config/arm/arm64_hip10_linux_gcc:cpu = 'armv8-a'
^ permalink raw reply [flat|nested] 28+ messages in thread* RE: [PATCH v1] config/arm: correct cpu arch for cross build
2023-11-06 15:38 ` Thomas Monjalon
@ 2023-11-07 2:42 ` Joyce Kong
0 siblings, 0 replies; 28+ messages in thread
From: Joyce Kong @ 2023-11-07 2:42 UTC (permalink / raw)
To: thomas, Ruifeng Wang; +Cc: dev, Bruce Richardson, Paul Szczepanek, nd
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, November 6, 2023 11:38 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Cc: dev@dpdk.org; Bruce Richardson <bruce.richardson@intel.com>; nd
> <nd@arm.com>; Paul Szczepanek <Paul.Szczepanek@arm.com>; Joyce Kong
> <Joyce.Kong@arm.com>
> Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build
>
> 06/11/2023 15:31, Joyce Kong:
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Monday, November 6, 2023 10:10 PM
> > > To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Joyce Kong
> > > <Joyce.Kong@arm.com>
> > > Cc: dev@dpdk.org; Bruce Richardson <bruce.richardson@intel.com>;
> > > dev@dpdk.org; nd <nd@arm.com>; Paul Szczepanek
> > > <Paul.Szczepanek@arm.com>
> > > Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build
> > >
> > > 18/10/2023 07:40, Joyce Kong:
> > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > 22/08/2023 09:47, Joyce Kong:
> > > > > > The cn10k cross build file sets cpu to 'armv8.6-a' while
> > > > > > N2 is armv8.5-a arch.
> > > > > > The cpu field in the cross file doesn't take effect as
> > > > > > config/arm/meson.build controls machine_args for march.
> > > > > > Then correct the value in arm cross files to 'auto'.
> > > > >
> > > > > I don't get it.
> > > > > Why setting a value if it has no impact?
> > > > > Looks like something is overcomplicated.
> > > > >
> > > > We still have to declare them here because meson would check the 'cpu'
> > > line in the config file, otherwise it would report missing {'cpu'}.
> > >
> > > OK
> > >
> > > Then why not all cross files are set to auto?
> > >
> > Actually, I set all the Arm cross files to auto in this patch. Maybe I have to
> figure it out in the commit line?
>
> What about these ones?
>
> git grep 'cpu = ' config/arm | grep -v auto
>
> config/arm/arm64_altra_linux_gcc:cpu = 'armv8.2-a'
> config/arm/arm64_ampereone_linux_gcc:cpu = 'armv8.6-a'
> config/arm/arm64_bluefield3_linux_gcc:cpu = 'armv8.4-a'
> config/arm/arm64_cdx_linux_gcc:cpu = 'armv8-a'
> config/arm/arm64_hip10_linux_gcc:cpu = 'armv8-a'
>
>
Really sorry for missing them as I didn't update the version, I shall correct them in next patch.
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v2] config/arm: correct cpu arch for cross build
2023-08-22 7:47 [PATCH v1] config/arm: correct cpu arch for cross build Joyce Kong
2023-10-17 19:41 ` Thomas Monjalon
@ 2023-11-07 3:26 ` Joyce Kong
2023-11-12 12:53 ` Thomas Monjalon
2023-11-20 9:24 ` [PATCH v3] " Joyce Kong
2023-12-05 3:52 ` [PATCH v4 0/2] config changes " Joyce Kong
3 siblings, 1 reply; 28+ messages in thread
From: Joyce Kong @ 2023-11-07 3:26 UTC (permalink / raw)
To: thomas, ruifeng.wang, bruce.richardson; +Cc: dev, nd, Joyce Kong
The cn10k cross build file sets cpu to 'armv8.6-a' while
it is armv8.5-a arch.
The cpu field in the cross file doesn't take effect as
config/arm/meson.build controls machine_args for march.
Then correct the value in arm cross files to 'auto'.
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
config/arm/arm32_armv8_linux_gcc | 2 +-
config/arm/arm64_altra_linux_gcc | 2 +-
config/arm/arm64_ampereone_linux_gcc | 2 +-
config/arm/arm64_armada_linux_gcc | 2 +-
config/arm/arm64_armv8_linux_clang_ubuntu | 2 +-
config/arm/arm64_armv8_linux_gcc | 2 +-
config/arm/arm64_bluefield3_linux_gcc | 2 +-
config/arm/arm64_bluefield_linux_gcc | 2 +-
config/arm/arm64_cdx_linux_gcc | 2 +-
config/arm/arm64_centriq2400_linux_gcc | 2 +-
config/arm/arm64_cn10k_linux_gcc | 2 +-
config/arm/arm64_cn9k_linux_gcc | 2 +-
config/arm/arm64_dpaa_linux_gcc | 2 +-
config/arm/arm64_emag_linux_gcc | 2 +-
config/arm/arm64_ft2000plus_linux_gcc | 2 +-
config/arm/arm64_graviton2_linux_gcc | 2 +-
config/arm/arm64_graviton3_linux_gcc | 2 +-
config/arm/arm64_hip10_linux_gcc | 2 +-
config/arm/arm64_kunpeng920_linux_gcc | 2 +-
config/arm/arm64_kunpeng930_linux_gcc | 2 +-
config/arm/arm64_n1sdp_linux_gcc | 2 +-
config/arm/arm64_n2_linux_gcc | 2 +-
config/arm/arm64_stingray_linux_gcc | 2 +-
config/arm/arm64_thunderx2_linux_gcc | 2 +-
config/arm/arm64_thunderxt83_linux_gcc | 2 +-
config/arm/arm64_thunderxt88_linux_gcc | 2 +-
config/arm/arm64_tys2500_linux_gcc | 2 +-
27 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/config/arm/arm32_armv8_linux_gcc b/config/arm/arm32_armv8_linux_gcc
index 269a60ba19..af1c8b68c3 100644
--- a/config/arm/arm32_armv8_linux_gcc
+++ b/config/arm/arm32_armv8_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch32'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_altra_linux_gcc b/config/arm/arm64_altra_linux_gcc
index ce0667ebe2..972de20614 100644
--- a/config/arm/arm64_altra_linux_gcc
+++ b/config/arm/arm64_altra_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.2-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_ampereone_linux_gcc b/config/arm/arm64_ampereone_linux_gcc
index 8964432a74..f1235993d8 100644
--- a/config/arm/arm64_ampereone_linux_gcc
+++ b/config/arm/arm64_ampereone_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.6-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_armada_linux_gcc b/config/arm/arm64_armada_linux_gcc
index 635b4946a3..7f9090bb44 100644
--- a/config/arm/arm64_armada_linux_gcc
+++ b/config/arm/arm64_armada_linux_gcc
@@ -10,7 +10,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu b/config/arm/arm64_armv8_linux_clang_ubuntu
index 86ae43937b..3d52a5e32e 100644
--- a/config/arm/arm64_armv8_linux_clang_ubuntu
+++ b/config/arm/arm64_armv8_linux_clang_ubuntu
@@ -10,7 +10,7 @@ pkgconfig = 'aarch64-linux-gnu-pkg-config'
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_armv8_linux_gcc b/config/arm/arm64_armv8_linux_gcc
index 529694b49d..98efa7fd2d 100644
--- a/config/arm/arm64_armv8_linux_gcc
+++ b/config/arm/arm64_armv8_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_bluefield3_linux_gcc b/config/arm/arm64_bluefield3_linux_gcc
index 775cf5883d..cf58b4aa6b 100644
--- a/config/arm/arm64_bluefield3_linux_gcc
+++ b/config/arm/arm64_bluefield3_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.4-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_bluefield_linux_gcc b/config/arm/arm64_bluefield_linux_gcc
index 1286227915..d38922fea5 100644
--- a/config/arm/arm64_bluefield_linux_gcc
+++ b/config/arm/arm64_bluefield_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_cdx_linux_gcc b/config/arm/arm64_cdx_linux_gcc
index 8e6d619dae..be2aa56430 100644
--- a/config/arm/arm64_cdx_linux_gcc
+++ b/config/arm/arm64_cdx_linux_gcc
@@ -10,7 +10,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_centriq2400_linux_gcc b/config/arm/arm64_centriq2400_linux_gcc
index bc8737e072..ad08b2b83c 100644
--- a/config/arm/arm64_centriq2400_linux_gcc
+++ b/config/arm/arm64_centriq2400_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_cn10k_linux_gcc b/config/arm/arm64_cn10k_linux_gcc
index fa904af5d0..ad403c3aa0 100644
--- a/config/arm/arm64_cn10k_linux_gcc
+++ b/config/arm/arm64_cn10k_linux_gcc
@@ -10,7 +10,7 @@ cmake = 'cmake'
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.6-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_cn9k_linux_gcc b/config/arm/arm64_cn9k_linux_gcc
index 646ce4b5d3..f2947e94c0 100644
--- a/config/arm/arm64_cn9k_linux_gcc
+++ b/config/arm/arm64_cn9k_linux_gcc
@@ -10,7 +10,7 @@ cmake = 'cmake'
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_dpaa_linux_gcc b/config/arm/arm64_dpaa_linux_gcc
index 8465b5097b..e60edbaafb 100644
--- a/config/arm/arm64_dpaa_linux_gcc
+++ b/config/arm/arm64_dpaa_linux_gcc
@@ -10,7 +10,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_emag_linux_gcc b/config/arm/arm64_emag_linux_gcc
index 248169ed68..10e2e83b56 100644
--- a/config/arm/arm64_emag_linux_gcc
+++ b/config/arm/arm64_emag_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_ft2000plus_linux_gcc b/config/arm/arm64_ft2000plus_linux_gcc
index ae9f779056..8d65d18b8d 100644
--- a/config/arm/arm64_ft2000plus_linux_gcc
+++ b/config/arm/arm64_ft2000plus_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_graviton2_linux_gcc b/config/arm/arm64_graviton2_linux_gcc
index fdb298bb11..adc96598e0 100644
--- a/config/arm/arm64_graviton2_linux_gcc
+++ b/config/arm/arm64_graviton2_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_graviton3_linux_gcc b/config/arm/arm64_graviton3_linux_gcc
index 19b422075d..805566ae85 100644
--- a/config/arm/arm64_graviton3_linux_gcc
+++ b/config/arm/arm64_graviton3_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_hip10_linux_gcc b/config/arm/arm64_hip10_linux_gcc
index 2943e4abbf..5a769d27d2 100644
--- a/config/arm/arm64_hip10_linux_gcc
+++ b/config/arm/arm64_hip10_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_kunpeng920_linux_gcc b/config/arm/arm64_kunpeng920_linux_gcc
index 193fb48a61..ea0f3f96d6 100644
--- a/config/arm/arm64_kunpeng920_linux_gcc
+++ b/config/arm/arm64_kunpeng920_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_kunpeng930_linux_gcc b/config/arm/arm64_kunpeng930_linux_gcc
index e4281ceb4f..3a928ee998 100644
--- a/config/arm/arm64_kunpeng930_linux_gcc
+++ b/config/arm/arm64_kunpeng930_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_n1sdp_linux_gcc b/config/arm/arm64_n1sdp_linux_gcc
index 2806a4241b..6eef27291a 100644
--- a/config/arm/arm64_n1sdp_linux_gcc
+++ b/config/arm/arm64_n1sdp_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_n2_linux_gcc b/config/arm/arm64_n2_linux_gcc
index 7404bd197b..111ae52c5f 100644
--- a/config/arm/arm64_n2_linux_gcc
+++ b/config/arm/arm64_n2_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_stingray_linux_gcc b/config/arm/arm64_stingray_linux_gcc
index 08148b5c3d..41903aaa1f 100644
--- a/config/arm/arm64_stingray_linux_gcc
+++ b/config/arm/arm64_stingray_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_thunderx2_linux_gcc b/config/arm/arm64_thunderx2_linux_gcc
index 32ae938e95..eb07a59da0 100644
--- a/config/arm/arm64_thunderx2_linux_gcc
+++ b/config/arm/arm64_thunderx2_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_thunderxt83_linux_gcc b/config/arm/arm64_thunderxt83_linux_gcc
index e9d9e62d44..cd4f9c2acb 100644
--- a/config/arm/arm64_thunderxt83_linux_gcc
+++ b/config/arm/arm64_thunderxt83_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_thunderxt88_linux_gcc b/config/arm/arm64_thunderxt88_linux_gcc
index c6e5a5656a..b9e0d554a4 100644
--- a/config/arm/arm64_thunderxt88_linux_gcc
+++ b/config/arm/arm64_thunderxt88_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_tys2500_linux_gcc b/config/arm/arm64_tys2500_linux_gcc
index fce85fb0d8..994803d363 100644
--- a/config/arm/arm64_tys2500_linux_gcc
+++ b/config/arm/arm64_tys2500_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
--
2.25.1
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] config/arm: correct cpu arch for cross build
2023-11-07 3:26 ` [PATCH v2] " Joyce Kong
@ 2023-11-12 12:53 ` Thomas Monjalon
2023-11-20 8:51 ` Joyce Kong
0 siblings, 1 reply; 28+ messages in thread
From: Thomas Monjalon @ 2023-11-12 12:53 UTC (permalink / raw)
To: ruifeng.wang, Joyce Kong; +Cc: bruce.richardson, dev, nd
07/11/2023 04:26, Joyce Kong:
> The cn10k cross build file sets cpu to 'armv8.6-a' while
> it is armv8.5-a arch.
> The cpu field in the cross file doesn't take effect as
> config/arm/meson.build controls machine_args for march.
> Then correct the value in arm cross files to 'auto'.
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
It generates this error:
config/meson.build:178:8: ERROR: Problem encountered:
Compiler does not support "native" arch flag.
^ permalink raw reply [flat|nested] 28+ messages in thread
* RE: [PATCH v2] config/arm: correct cpu arch for cross build
2023-11-12 12:53 ` Thomas Monjalon
@ 2023-11-20 8:51 ` Joyce Kong
0 siblings, 0 replies; 28+ messages in thread
From: Joyce Kong @ 2023-11-20 8:51 UTC (permalink / raw)
To: thomas, Ruifeng Wang; +Cc: bruce.richardson, dev, nd
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Sunday, November 12, 2023 8:54 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Joyce Kong
> <Joyce.Kong@arm.com>
> Cc: bruce.richardson@intel.com; dev@dpdk.org; nd <nd@arm.com>
> Subject: Re: [PATCH v2] config/arm: correct cpu arch for cross build
>
> 07/11/2023 04:26, Joyce Kong:
> > The cn10k cross build file sets cpu to 'armv8.6-a' while it is
> > armv8.5-a arch.
> > The cpu field in the cross file doesn't take effect as
> > config/arm/meson.build controls machine_args for march.
> > Then correct the value in arm cross files to 'auto'.
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
> It generates this error:
>
> config/meson.build:178:8: ERROR: Problem encountered:
> Compiler does not support "native" arch flag.
>
Hi Thomas, are there any changes for CI recently?
I checked the log, it seemed CI triggering a wrong configuration for cross compiling, not related to this patch.
I shall rebase the patch and send out V3, and we can see whether CI still fails.
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v3] config/arm: correct cpu arch for cross build
2023-08-22 7:47 [PATCH v1] config/arm: correct cpu arch for cross build Joyce Kong
2023-10-17 19:41 ` Thomas Monjalon
2023-11-07 3:26 ` [PATCH v2] " Joyce Kong
@ 2023-11-20 9:24 ` Joyce Kong
2023-11-20 16:54 ` Thomas Monjalon
2023-12-05 3:52 ` [PATCH v4 0/2] config changes " Joyce Kong
3 siblings, 1 reply; 28+ messages in thread
From: Joyce Kong @ 2023-11-20 9:24 UTC (permalink / raw)
To: thomas, ruifeng.wang, bruce.richardson; +Cc: dev, nd, Joyce Kong
The cn10k cross build file sets cpu to 'armv8.6-a' while
it is armv8.5-a arch.
Meanwhile, the cpu field in the cross file doesn't take
effect as config/arm/meson.build controls machine_args
for march. Then change the 'cpu' value in all arm cross
files to 'auto'.
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
config/arm/arm32_armv8_linux_gcc | 2 +-
config/arm/arm64_altra_linux_gcc | 2 +-
config/arm/arm64_ampereone_linux_gcc | 2 +-
config/arm/arm64_armada_linux_gcc | 2 +-
config/arm/arm64_armv8_linux_clang_ubuntu | 2 +-
config/arm/arm64_armv8_linux_gcc | 2 +-
config/arm/arm64_bluefield3_linux_gcc | 2 +-
config/arm/arm64_bluefield_linux_gcc | 2 +-
config/arm/arm64_cdx_linux_gcc | 2 +-
config/arm/arm64_centriq2400_linux_gcc | 2 +-
config/arm/arm64_cn10k_linux_gcc | 2 +-
config/arm/arm64_cn9k_linux_gcc | 2 +-
config/arm/arm64_dpaa_linux_gcc | 2 +-
config/arm/arm64_emag_linux_gcc | 2 +-
config/arm/arm64_ft2000plus_linux_gcc | 2 +-
config/arm/arm64_graviton2_linux_gcc | 2 +-
config/arm/arm64_graviton3_linux_gcc | 2 +-
config/arm/arm64_hip10_linux_gcc | 2 +-
config/arm/arm64_kunpeng920_linux_gcc | 2 +-
config/arm/arm64_kunpeng930_linux_gcc | 2 +-
config/arm/arm64_n1sdp_linux_gcc | 2 +-
config/arm/arm64_n2_linux_gcc | 2 +-
config/arm/arm64_stingray_linux_gcc | 2 +-
config/arm/arm64_thunderx2_linux_gcc | 2 +-
config/arm/arm64_thunderxt83_linux_gcc | 2 +-
config/arm/arm64_thunderxt88_linux_gcc | 2 +-
config/arm/arm64_tys2500_linux_gcc | 2 +-
27 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/config/arm/arm32_armv8_linux_gcc b/config/arm/arm32_armv8_linux_gcc
index 269a60ba19..af1c8b68c3 100644
--- a/config/arm/arm32_armv8_linux_gcc
+++ b/config/arm/arm32_armv8_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch32'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_altra_linux_gcc b/config/arm/arm64_altra_linux_gcc
index ce0667ebe2..972de20614 100644
--- a/config/arm/arm64_altra_linux_gcc
+++ b/config/arm/arm64_altra_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.2-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_ampereone_linux_gcc b/config/arm/arm64_ampereone_linux_gcc
index 8964432a74..f1235993d8 100644
--- a/config/arm/arm64_ampereone_linux_gcc
+++ b/config/arm/arm64_ampereone_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.6-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_armada_linux_gcc b/config/arm/arm64_armada_linux_gcc
index 635b4946a3..7f9090bb44 100644
--- a/config/arm/arm64_armada_linux_gcc
+++ b/config/arm/arm64_armada_linux_gcc
@@ -10,7 +10,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu b/config/arm/arm64_armv8_linux_clang_ubuntu
index 86ae43937b..3d52a5e32e 100644
--- a/config/arm/arm64_armv8_linux_clang_ubuntu
+++ b/config/arm/arm64_armv8_linux_clang_ubuntu
@@ -10,7 +10,7 @@ pkgconfig = 'aarch64-linux-gnu-pkg-config'
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_armv8_linux_gcc b/config/arm/arm64_armv8_linux_gcc
index 529694b49d..98efa7fd2d 100644
--- a/config/arm/arm64_armv8_linux_gcc
+++ b/config/arm/arm64_armv8_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_bluefield3_linux_gcc b/config/arm/arm64_bluefield3_linux_gcc
index 775cf5883d..cf58b4aa6b 100644
--- a/config/arm/arm64_bluefield3_linux_gcc
+++ b/config/arm/arm64_bluefield3_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.4-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_bluefield_linux_gcc b/config/arm/arm64_bluefield_linux_gcc
index 1286227915..d38922fea5 100644
--- a/config/arm/arm64_bluefield_linux_gcc
+++ b/config/arm/arm64_bluefield_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_cdx_linux_gcc b/config/arm/arm64_cdx_linux_gcc
index 8e6d619dae..be2aa56430 100644
--- a/config/arm/arm64_cdx_linux_gcc
+++ b/config/arm/arm64_cdx_linux_gcc
@@ -10,7 +10,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_centriq2400_linux_gcc b/config/arm/arm64_centriq2400_linux_gcc
index bc8737e072..ad08b2b83c 100644
--- a/config/arm/arm64_centriq2400_linux_gcc
+++ b/config/arm/arm64_centriq2400_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_cn10k_linux_gcc b/config/arm/arm64_cn10k_linux_gcc
index fa904af5d0..ad403c3aa0 100644
--- a/config/arm/arm64_cn10k_linux_gcc
+++ b/config/arm/arm64_cn10k_linux_gcc
@@ -10,7 +10,7 @@ cmake = 'cmake'
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.6-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_cn9k_linux_gcc b/config/arm/arm64_cn9k_linux_gcc
index 646ce4b5d3..f2947e94c0 100644
--- a/config/arm/arm64_cn9k_linux_gcc
+++ b/config/arm/arm64_cn9k_linux_gcc
@@ -10,7 +10,7 @@ cmake = 'cmake'
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_dpaa_linux_gcc b/config/arm/arm64_dpaa_linux_gcc
index 8465b5097b..e60edbaafb 100644
--- a/config/arm/arm64_dpaa_linux_gcc
+++ b/config/arm/arm64_dpaa_linux_gcc
@@ -10,7 +10,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_emag_linux_gcc b/config/arm/arm64_emag_linux_gcc
index 248169ed68..10e2e83b56 100644
--- a/config/arm/arm64_emag_linux_gcc
+++ b/config/arm/arm64_emag_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_ft2000plus_linux_gcc b/config/arm/arm64_ft2000plus_linux_gcc
index ae9f779056..8d65d18b8d 100644
--- a/config/arm/arm64_ft2000plus_linux_gcc
+++ b/config/arm/arm64_ft2000plus_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_graviton2_linux_gcc b/config/arm/arm64_graviton2_linux_gcc
index fdb298bb11..adc96598e0 100644
--- a/config/arm/arm64_graviton2_linux_gcc
+++ b/config/arm/arm64_graviton2_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_graviton3_linux_gcc b/config/arm/arm64_graviton3_linux_gcc
index 19b422075d..805566ae85 100644
--- a/config/arm/arm64_graviton3_linux_gcc
+++ b/config/arm/arm64_graviton3_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_hip10_linux_gcc b/config/arm/arm64_hip10_linux_gcc
index 2943e4abbf..5a769d27d2 100644
--- a/config/arm/arm64_hip10_linux_gcc
+++ b/config/arm/arm64_hip10_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_kunpeng920_linux_gcc b/config/arm/arm64_kunpeng920_linux_gcc
index 193fb48a61..ea0f3f96d6 100644
--- a/config/arm/arm64_kunpeng920_linux_gcc
+++ b/config/arm/arm64_kunpeng920_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_kunpeng930_linux_gcc b/config/arm/arm64_kunpeng930_linux_gcc
index e4281ceb4f..3a928ee998 100644
--- a/config/arm/arm64_kunpeng930_linux_gcc
+++ b/config/arm/arm64_kunpeng930_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_n1sdp_linux_gcc b/config/arm/arm64_n1sdp_linux_gcc
index 2806a4241b..6eef27291a 100644
--- a/config/arm/arm64_n1sdp_linux_gcc
+++ b/config/arm/arm64_n1sdp_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_n2_linux_gcc b/config/arm/arm64_n2_linux_gcc
index 7404bd197b..111ae52c5f 100644
--- a/config/arm/arm64_n2_linux_gcc
+++ b/config/arm/arm64_n2_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_stingray_linux_gcc b/config/arm/arm64_stingray_linux_gcc
index 08148b5c3d..41903aaa1f 100644
--- a/config/arm/arm64_stingray_linux_gcc
+++ b/config/arm/arm64_stingray_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_thunderx2_linux_gcc b/config/arm/arm64_thunderx2_linux_gcc
index 32ae938e95..eb07a59da0 100644
--- a/config/arm/arm64_thunderx2_linux_gcc
+++ b/config/arm/arm64_thunderx2_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_thunderxt83_linux_gcc b/config/arm/arm64_thunderxt83_linux_gcc
index e9d9e62d44..cd4f9c2acb 100644
--- a/config/arm/arm64_thunderxt83_linux_gcc
+++ b/config/arm/arm64_thunderxt83_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_thunderxt88_linux_gcc b/config/arm/arm64_thunderxt88_linux_gcc
index c6e5a5656a..b9e0d554a4 100644
--- a/config/arm/arm64_thunderxt88_linux_gcc
+++ b/config/arm/arm64_thunderxt88_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_tys2500_linux_gcc b/config/arm/arm64_tys2500_linux_gcc
index fce85fb0d8..994803d363 100644
--- a/config/arm/arm64_tys2500_linux_gcc
+++ b/config/arm/arm64_tys2500_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
--
2.25.1
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3] config/arm: correct cpu arch for cross build
2023-11-20 9:24 ` [PATCH v3] " Joyce Kong
@ 2023-11-20 16:54 ` Thomas Monjalon
2023-11-22 7:10 ` Joyce Kong
0 siblings, 1 reply; 28+ messages in thread
From: Thomas Monjalon @ 2023-11-20 16:54 UTC (permalink / raw)
To: Joyce Kong; +Cc: ruifeng.wang, bruce.richardson, dev, nd
20/11/2023 10:24, Joyce Kong:
> The cn10k cross build file sets cpu to 'armv8.6-a' while
> it is armv8.5-a arch.
> Meanwhile, the cpu field in the cross file doesn't take
> effect as config/arm/meson.build controls machine_args
> for march. Then change the 'cpu' value in all arm cross
> files to 'auto'.
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
What did you change compared to v2?
Please take care of providing a changelog after "---"
I still see the same error on my machine:
config/meson.build:178:8: ERROR: Problem encountered:
Compiler does not support "native" arch flag.
^ permalink raw reply [flat|nested] 28+ messages in thread
* RE: [PATCH v3] config/arm: correct cpu arch for cross build
2023-11-20 16:54 ` Thomas Monjalon
@ 2023-11-22 7:10 ` Joyce Kong
0 siblings, 0 replies; 28+ messages in thread
From: Joyce Kong @ 2023-11-22 7:10 UTC (permalink / raw)
To: thomas; +Cc: Ruifeng Wang, bruce.richardson, dev, nd
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, November 21, 2023 12:55 AM
> To: Joyce Kong <Joyce.Kong@arm.com>
> Cc: Ruifeng Wang <Ruifeng.Wang@arm.com>; bruce.richardson@intel.com;
> dev@dpdk.org; nd <nd@arm.com>
> Subject: Re: [PATCH v3] config/arm: correct cpu arch for cross build
>
> 20/11/2023 10:24, Joyce Kong:
> > The cn10k cross build file sets cpu to 'armv8.6-a' while it is
> > armv8.5-a arch.
> > Meanwhile, the cpu field in the cross file doesn't take effect as
> > config/arm/meson.build controls machine_args for march. Then change
> > the 'cpu' value in all arm cross files to 'auto'.
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
> What did you change compared to v2?
> Please take care of providing a changelog after "---"
>
> I still see the same error on my machine:
> config/meson.build:178:8: ERROR: Problem encountered:
> Compiler does not support "native" arch flag.
>
The patch "config: verify machine arch flag (b7676fcccab4) " introduces a verification for specified cpu_instruction_set.
When cpu set to 'auto' as my patch, the below code in config/meson.build changes it to 'native' and triggers the verification error. However, the platform couldn't be 'native' or 'generic' for cross build. Changing cpu_instruction_set from 'auto' to 'native' is unreasonable here. I would like to send a patch to move the below code to not cross build path.
"if platform == 'native'
if cpu_instruction_set == 'auto'
cpu_instruction_set = 'native'
endif
elif platform == 'generic'
if cpu_instruction_set == 'auto'
cpu_instruction_set = 'generic'
endif
endif"
And I would like to update cpu value in the cross file to aarch64 instead of auto, to avoid any further possible verification.
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v4 0/2] config changes for cross build
2023-08-22 7:47 [PATCH v1] config/arm: correct cpu arch for cross build Joyce Kong
` (2 preceding siblings ...)
2023-11-20 9:24 ` [PATCH v3] " Joyce Kong
@ 2023-12-05 3:52 ` Joyce Kong
2023-12-05 3:52 ` [PATCH v4 1/2] config: correct cpu instruction set " Joyce Kong
2023-12-05 3:52 ` [PATCH v4 2/2] config/arm: use common cpu arch for cross files Joyce Kong
3 siblings, 2 replies; 28+ messages in thread
From: Joyce Kong @ 2023-12-05 3:52 UTC (permalink / raw)
To: thomas, ruifeng.wang, bruce.richardson; +Cc: dev, nd, Joyce Kong
The patch series implement two changes for cross build.
The first one is to correct cpu instruction set. And the
second one is to use a common cpu arch for cross files.
---
V4:
* Add patch to correct cpu instruction set for cross build.
v3:
* Rebase the patch to use a common cpu arch for cross files.
v2:
* Add the missing cross files which are not changed to use
the common cpu arch in v1.
---
Joyce Kong (2):
config: correct cpu instruction set for cross build
config/arm: use common cpu arch for cross files
config/arm/arm32_armv8_linux_gcc | 2 +-
config/arm/arm64_altra_linux_gcc | 2 +-
config/arm/arm64_ampereone_linux_gcc | 2 +-
config/arm/arm64_armada_linux_gcc | 2 +-
config/arm/arm64_armv8_linux_clang_ubuntu | 2 +-
config/arm/arm64_armv8_linux_gcc | 2 +-
config/arm/arm64_bluefield3_linux_gcc | 2 +-
config/arm/arm64_bluefield_linux_gcc | 2 +-
config/arm/arm64_cdx_linux_gcc | 2 +-
config/arm/arm64_centriq2400_linux_gcc | 2 +-
config/arm/arm64_cn10k_linux_gcc | 2 +-
config/arm/arm64_cn9k_linux_gcc | 2 +-
config/arm/arm64_dpaa_linux_gcc | 2 +-
config/arm/arm64_emag_linux_gcc | 2 +-
config/arm/arm64_ft2000plus_linux_gcc | 2 +-
config/arm/arm64_graviton2_linux_gcc | 2 +-
config/arm/arm64_graviton3_linux_gcc | 2 +-
config/arm/arm64_hip10_linux_gcc | 2 +-
config/arm/arm64_kunpeng920_linux_gcc | 2 +-
config/arm/arm64_kunpeng930_linux_gcc | 2 +-
config/arm/arm64_n1sdp_linux_gcc | 2 +-
config/arm/arm64_n2_linux_gcc | 2 +-
config/arm/arm64_stingray_linux_gcc | 2 +-
config/arm/arm64_thunderx2_linux_gcc | 2 +-
config/arm/arm64_thunderxt83_linux_gcc | 2 +-
config/arm/arm64_thunderxt88_linux_gcc | 2 +-
config/arm/arm64_tys2500_linux_gcc | 2 +-
config/meson.build | 11 ++++++-----
28 files changed, 33 insertions(+), 32 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 28+ messages in thread* [PATCH v4 1/2] config: correct cpu instruction set for cross build
2023-12-05 3:52 ` [PATCH v4 0/2] config changes " Joyce Kong
@ 2023-12-05 3:52 ` Joyce Kong
2023-12-07 22:41 ` Stephen Hemminger
2023-12-05 3:52 ` [PATCH v4 2/2] config/arm: use common cpu arch for cross files Joyce Kong
1 sibling, 1 reply; 28+ messages in thread
From: Joyce Kong @ 2023-12-05 3:52 UTC (permalink / raw)
To: thomas, ruifeng.wang, bruce.richardson; +Cc: dev, nd, Joyce Kong, stable
The platform value would be 'native' only when not cross build.
Move the operation about modifying cpu_instruction_set while
platform equals 'native' to the not cross build branch.
Fixes: bf66003b51ec ("build: use platform for generic and native builds")
Cc: stable@dpdk.org
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
config/meson.build | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/config/meson.build b/config/meson.build
index a9ccd56deb..0f37bc733c 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -121,13 +121,14 @@ else
cpu_instruction_set = 'generic'
endif
endif
+ if platform == 'native'
+ if cpu_instruction_set == 'auto'
+ cpu_instruction_set = 'native'
+ endif
+ endif
endif
-if platform == 'native'
- if cpu_instruction_set == 'auto'
- cpu_instruction_set = 'native'
- endif
-elif platform == 'generic'
+if platform == 'generic'
if cpu_instruction_set == 'auto'
cpu_instruction_set = 'generic'
endif
--
2.25.1
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v4 1/2] config: correct cpu instruction set for cross build
2023-12-05 3:52 ` [PATCH v4 1/2] config: correct cpu instruction set " Joyce Kong
@ 2023-12-07 22:41 ` Stephen Hemminger
2023-12-08 2:51 ` Joyce Kong
0 siblings, 1 reply; 28+ messages in thread
From: Stephen Hemminger @ 2023-12-07 22:41 UTC (permalink / raw)
To: Joyce Kong; +Cc: thomas, ruifeng.wang, bruce.richardson, dev, nd, stable
On Tue, 5 Dec 2023 03:52:58 +0000
Joyce Kong <joyce.kong@arm.com> wrote:
> The platform value would be 'native' only when not cross build.
> Move the operation about modifying cpu_instruction_set while
> platform equals 'native' to the not cross build branch.
>
> Fixes: bf66003b51ec ("build: use platform for generic and native builds")
> Cc: stable@dpdk.org
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Looks right, what is the impact on existing users doing current cross builds?
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 28+ messages in thread* RE: [PATCH v4 1/2] config: correct cpu instruction set for cross build
2023-12-07 22:41 ` Stephen Hemminger
@ 2023-12-08 2:51 ` Joyce Kong
2024-01-19 19:39 ` Pavan Nikhilesh Bhagavatula
0 siblings, 1 reply; 28+ messages in thread
From: Joyce Kong @ 2023-12-08 2:51 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: thomas, Ruifeng Wang, bruce.richardson, dev, nd, stable
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Friday, December 8, 2023 6:41 AM
> To: Joyce Kong <Joyce.Kong@arm.com>
> Cc: thomas@monjalon.net; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> bruce.richardson@intel.com; dev@dpdk.org; nd <nd@arm.com>;
> stable@dpdk.org
> Subject: Re: [PATCH v4 1/2] config: correct cpu instruction set for cross build
>
> On Tue, 5 Dec 2023 03:52:58 +0000
> Joyce Kong <joyce.kong@arm.com> wrote:
>
> > The platform value would be 'native' only when not cross build.
> > Move the operation about modifying cpu_instruction_set while platform
> > equals 'native' to the not cross build branch.
> >
> > Fixes: bf66003b51ec ("build: use platform for generic and native
> > builds")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
> Looks right, what is the impact on existing users doing current cross builds?
The original operation changes cpu_instruction_set to 'native' when both 'platform == native' and 'cpu_instruction_set == auto'.
There was no impact on the existing users for current cross build, as the cross files set cpu field to a specific arch, such as 'armv8-a', and this didn't trigger the modification for cpu_instruction_set.
However, if we want to use a common arch in cross files like 'auto', the modification operation would override 'native' value to cpu_instruction_set and b7676fcccab4 ("config: verify machine arch flag") would break the build as it tries to test -march=native.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 28+ messages in thread* RE: [PATCH v4 1/2] config: correct cpu instruction set for cross build
2023-12-08 2:51 ` Joyce Kong
@ 2024-01-19 19:39 ` Pavan Nikhilesh Bhagavatula
2024-03-06 14:43 ` Thomas Monjalon
0 siblings, 1 reply; 28+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2024-01-19 19:39 UTC (permalink / raw)
To: Joyce Kong, Stephen Hemminger
Cc: thomas, Ruifeng Wang, bruce.richardson, dev, nd, stable, Jerin Jacob
> -----Original Message-----
> From: Joyce Kong <Joyce.Kong@arm.com>
> Sent: Friday, December 8, 2023 8:21 AM
> To: Stephen Hemminger <stephen@networkplumber.org>
> Cc: thomas@monjalon.net; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> bruce.richardson@intel.com; dev@dpdk.org; nd <nd@arm.com>;
> stable@dpdk.org
> Subject: [EXT] RE: [PATCH v4 1/2] config: correct cpu instruction set for cross
> build
>
> External Email
>
> ----------------------------------------------------------------------
> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Friday, December 8, 2023 6:41 AM
> > To: Joyce Kong <Joyce.Kong@arm.com>
> > Cc: thomas@monjalon.net; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> > bruce.richardson@intel.com; dev@dpdk.org; nd <nd@arm.com>;
> > stable@dpdk.org
> > Subject: Re: [PATCH v4 1/2] config: correct cpu instruction set for cross
> build
> >
> > On Tue, 5 Dec 2023 03:52:58 +0000
> > Joyce Kong <joyce.kong@arm.com> wrote:
> >
> > > The platform value would be 'native' only when not cross build.
> > > Move the operation about modifying cpu_instruction_set while platform
> > > equals 'native' to the not cross build branch.
> > >
> > > Fixes: bf66003b51ec ("build: use platform for generic and native
> > > builds")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> >
> > Looks right, what is the impact on existing users doing current cross builds?
>
> The original operation changes cpu_instruction_set to 'native' when both
> 'platform == native' and 'cpu_instruction_set == auto'.
> There was no impact on the existing users for current cross build, as the cross
> files set cpu field to a specific arch, such as 'armv8-a', and this didn't trigger
> the modification for cpu_instruction_set.
> However, if we want to use a common arch in cross files like 'auto', the
> modification operation would override 'native' value to cpu_instruction_set
> and b7676fcccab4 ("config: verify machine arch flag") would break the build
> as it tries to test -march=native.
>
> >
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Tested-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v4 1/2] config: correct cpu instruction set for cross build
2024-01-19 19:39 ` Pavan Nikhilesh Bhagavatula
@ 2024-03-06 14:43 ` Thomas Monjalon
0 siblings, 0 replies; 28+ messages in thread
From: Thomas Monjalon @ 2024-03-06 14:43 UTC (permalink / raw)
To: Joyce Kong
Cc: Stephen Hemminger, stable, Ruifeng Wang, bruce.richardson, dev,
nd, stable, Jerin Jacob, Pavan Nikhilesh Bhagavatula,
paul.szczepanek
> > > > The platform value would be 'native' only when not cross build.
> > > > Move the operation about modifying cpu_instruction_set while platform
> > > > equals 'native' to the not cross build branch.
> > > >
> > > > Fixes: bf66003b51ec ("build: use platform for generic and native
> > > > builds")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > >
> > > Looks right, what is the impact on existing users doing current cross builds?
> >
> > The original operation changes cpu_instruction_set to 'native' when both
> > 'platform == native' and 'cpu_instruction_set == auto'.
> > There was no impact on the existing users for current cross build, as the cross
> > files set cpu field to a specific arch, such as 'armv8-a', and this didn't trigger
> > the modification for cpu_instruction_set.
> > However, if we want to use a common arch in cross files like 'auto', the
> > modification operation would override 'native' value to cpu_instruction_set
> > and b7676fcccab4 ("config: verify machine arch flag") would break the build
> > as it tries to test -march=native.
> >
> > >
> > > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Tested-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Applied without the second patch of the series, thanks.
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v4 2/2] config/arm: use common cpu arch for cross files
2023-12-05 3:52 ` [PATCH v4 0/2] config changes " Joyce Kong
2023-12-05 3:52 ` [PATCH v4 1/2] config: correct cpu instruction set " Joyce Kong
@ 2023-12-05 3:52 ` Joyce Kong
2023-12-07 22:41 ` Stephen Hemminger
2024-02-18 17:56 ` Thomas Monjalon
1 sibling, 2 replies; 28+ messages in thread
From: Joyce Kong @ 2023-12-05 3:52 UTC (permalink / raw)
To: thomas, ruifeng.wang, bruce.richardson
Cc: dev, nd, Joyce Kong, Honnappa Nagarahalli
The cpu info in some cross files is inconsistent with
that in SoC flags. The mismatch doesn't cause any issue
because the cpu field in the cross file takes no effect
and machine_args in config/arm/meson.build actually works.
Use a common one in cross files to remove any confusion.
Reported-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
config/arm/arm32_armv8_linux_gcc | 2 +-
config/arm/arm64_altra_linux_gcc | 2 +-
config/arm/arm64_ampereone_linux_gcc | 2 +-
config/arm/arm64_armada_linux_gcc | 2 +-
config/arm/arm64_armv8_linux_clang_ubuntu | 2 +-
config/arm/arm64_armv8_linux_gcc | 2 +-
config/arm/arm64_bluefield3_linux_gcc | 2 +-
config/arm/arm64_bluefield_linux_gcc | 2 +-
config/arm/arm64_cdx_linux_gcc | 2 +-
config/arm/arm64_centriq2400_linux_gcc | 2 +-
config/arm/arm64_cn10k_linux_gcc | 2 +-
config/arm/arm64_cn9k_linux_gcc | 2 +-
config/arm/arm64_dpaa_linux_gcc | 2 +-
config/arm/arm64_emag_linux_gcc | 2 +-
config/arm/arm64_ft2000plus_linux_gcc | 2 +-
config/arm/arm64_graviton2_linux_gcc | 2 +-
config/arm/arm64_graviton3_linux_gcc | 2 +-
config/arm/arm64_hip10_linux_gcc | 2 +-
config/arm/arm64_kunpeng920_linux_gcc | 2 +-
config/arm/arm64_kunpeng930_linux_gcc | 2 +-
config/arm/arm64_n1sdp_linux_gcc | 2 +-
config/arm/arm64_n2_linux_gcc | 2 +-
config/arm/arm64_stingray_linux_gcc | 2 +-
config/arm/arm64_thunderx2_linux_gcc | 2 +-
config/arm/arm64_thunderxt83_linux_gcc | 2 +-
config/arm/arm64_thunderxt88_linux_gcc | 2 +-
config/arm/arm64_tys2500_linux_gcc | 2 +-
27 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/config/arm/arm32_armv8_linux_gcc b/config/arm/arm32_armv8_linux_gcc
index 269a60ba19..af1c8b68c3 100644
--- a/config/arm/arm32_armv8_linux_gcc
+++ b/config/arm/arm32_armv8_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch32'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_altra_linux_gcc b/config/arm/arm64_altra_linux_gcc
index ce0667ebe2..972de20614 100644
--- a/config/arm/arm64_altra_linux_gcc
+++ b/config/arm/arm64_altra_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.2-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_ampereone_linux_gcc b/config/arm/arm64_ampereone_linux_gcc
index 8964432a74..f1235993d8 100644
--- a/config/arm/arm64_ampereone_linux_gcc
+++ b/config/arm/arm64_ampereone_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.6-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_armada_linux_gcc b/config/arm/arm64_armada_linux_gcc
index 635b4946a3..aca498a3db 100644
--- a/config/arm/arm64_armada_linux_gcc
+++ b/config/arm/arm64_armada_linux_gcc
@@ -10,7 +10,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'aarch64'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu b/config/arm/arm64_armv8_linux_clang_ubuntu
index 86ae43937b..3d52a5e32e 100644
--- a/config/arm/arm64_armv8_linux_clang_ubuntu
+++ b/config/arm/arm64_armv8_linux_clang_ubuntu
@@ -10,7 +10,7 @@ pkgconfig = 'aarch64-linux-gnu-pkg-config'
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_armv8_linux_gcc b/config/arm/arm64_armv8_linux_gcc
index 529694b49d..98efa7fd2d 100644
--- a/config/arm/arm64_armv8_linux_gcc
+++ b/config/arm/arm64_armv8_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_bluefield3_linux_gcc b/config/arm/arm64_bluefield3_linux_gcc
index 775cf5883d..cf58b4aa6b 100644
--- a/config/arm/arm64_bluefield3_linux_gcc
+++ b/config/arm/arm64_bluefield3_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.4-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_bluefield_linux_gcc b/config/arm/arm64_bluefield_linux_gcc
index 1286227915..d38922fea5 100644
--- a/config/arm/arm64_bluefield_linux_gcc
+++ b/config/arm/arm64_bluefield_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_cdx_linux_gcc b/config/arm/arm64_cdx_linux_gcc
index 8e6d619dae..be2aa56430 100644
--- a/config/arm/arm64_cdx_linux_gcc
+++ b/config/arm/arm64_cdx_linux_gcc
@@ -10,7 +10,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_centriq2400_linux_gcc b/config/arm/arm64_centriq2400_linux_gcc
index bc8737e072..ad08b2b83c 100644
--- a/config/arm/arm64_centriq2400_linux_gcc
+++ b/config/arm/arm64_centriq2400_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_cn10k_linux_gcc b/config/arm/arm64_cn10k_linux_gcc
index fa904af5d0..ad403c3aa0 100644
--- a/config/arm/arm64_cn10k_linux_gcc
+++ b/config/arm/arm64_cn10k_linux_gcc
@@ -10,7 +10,7 @@ cmake = 'cmake'
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8.6-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_cn9k_linux_gcc b/config/arm/arm64_cn9k_linux_gcc
index 646ce4b5d3..f2947e94c0 100644
--- a/config/arm/arm64_cn9k_linux_gcc
+++ b/config/arm/arm64_cn9k_linux_gcc
@@ -10,7 +10,7 @@ cmake = 'cmake'
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_dpaa_linux_gcc b/config/arm/arm64_dpaa_linux_gcc
index 8465b5097b..e60edbaafb 100644
--- a/config/arm/arm64_dpaa_linux_gcc
+++ b/config/arm/arm64_dpaa_linux_gcc
@@ -10,7 +10,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_emag_linux_gcc b/config/arm/arm64_emag_linux_gcc
index 248169ed68..10e2e83b56 100644
--- a/config/arm/arm64_emag_linux_gcc
+++ b/config/arm/arm64_emag_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_ft2000plus_linux_gcc b/config/arm/arm64_ft2000plus_linux_gcc
index ae9f779056..8d65d18b8d 100644
--- a/config/arm/arm64_ft2000plus_linux_gcc
+++ b/config/arm/arm64_ft2000plus_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_graviton2_linux_gcc b/config/arm/arm64_graviton2_linux_gcc
index fdb298bb11..adc96598e0 100644
--- a/config/arm/arm64_graviton2_linux_gcc
+++ b/config/arm/arm64_graviton2_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_graviton3_linux_gcc b/config/arm/arm64_graviton3_linux_gcc
index 19b422075d..805566ae85 100644
--- a/config/arm/arm64_graviton3_linux_gcc
+++ b/config/arm/arm64_graviton3_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_hip10_linux_gcc b/config/arm/arm64_hip10_linux_gcc
index 2943e4abbf..46764941b6 100644
--- a/config/arm/arm64_hip10_linux_gcc
+++ b/config/arm/arm64_hip10_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'aarch64'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_kunpeng920_linux_gcc b/config/arm/arm64_kunpeng920_linux_gcc
index 193fb48a61..ea0f3f96d6 100644
--- a/config/arm/arm64_kunpeng920_linux_gcc
+++ b/config/arm/arm64_kunpeng920_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_kunpeng930_linux_gcc b/config/arm/arm64_kunpeng930_linux_gcc
index e4281ceb4f..3a928ee998 100644
--- a/config/arm/arm64_kunpeng930_linux_gcc
+++ b/config/arm/arm64_kunpeng930_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_n1sdp_linux_gcc b/config/arm/arm64_n1sdp_linux_gcc
index 2806a4241b..6eef27291a 100644
--- a/config/arm/arm64_n1sdp_linux_gcc
+++ b/config/arm/arm64_n1sdp_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_n2_linux_gcc b/config/arm/arm64_n2_linux_gcc
index 7404bd197b..111ae52c5f 100644
--- a/config/arm/arm64_n2_linux_gcc
+++ b/config/arm/arm64_n2_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_stingray_linux_gcc b/config/arm/arm64_stingray_linux_gcc
index 08148b5c3d..41903aaa1f 100644
--- a/config/arm/arm64_stingray_linux_gcc
+++ b/config/arm/arm64_stingray_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_thunderx2_linux_gcc b/config/arm/arm64_thunderx2_linux_gcc
index 32ae938e95..eb07a59da0 100644
--- a/config/arm/arm64_thunderx2_linux_gcc
+++ b/config/arm/arm64_thunderx2_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_thunderxt83_linux_gcc b/config/arm/arm64_thunderxt83_linux_gcc
index e9d9e62d44..cd4f9c2acb 100644
--- a/config/arm/arm64_thunderxt83_linux_gcc
+++ b/config/arm/arm64_thunderxt83_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_thunderxt88_linux_gcc b/config/arm/arm64_thunderxt88_linux_gcc
index c6e5a5656a..b9e0d554a4 100644
--- a/config/arm/arm64_thunderxt88_linux_gcc
+++ b/config/arm/arm64_thunderxt88_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
diff --git a/config/arm/arm64_tys2500_linux_gcc b/config/arm/arm64_tys2500_linux_gcc
index fce85fb0d8..994803d363 100644
--- a/config/arm/arm64_tys2500_linux_gcc
+++ b/config/arm/arm64_tys2500_linux_gcc
@@ -9,7 +9,7 @@ pcap-config = ''
[host_machine]
system = 'linux'
cpu_family = 'aarch64'
-cpu = 'armv8-a'
+cpu = 'auto'
endian = 'little'
[properties]
--
2.25.1
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v4 2/2] config/arm: use common cpu arch for cross files
2023-12-05 3:52 ` [PATCH v4 2/2] config/arm: use common cpu arch for cross files Joyce Kong
@ 2023-12-07 22:41 ` Stephen Hemminger
2024-01-19 19:40 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-02-18 17:56 ` Thomas Monjalon
1 sibling, 1 reply; 28+ messages in thread
From: Stephen Hemminger @ 2023-12-07 22:41 UTC (permalink / raw)
To: Joyce Kong
Cc: thomas, ruifeng.wang, bruce.richardson, dev, nd, Honnappa Nagarahalli
On Tue, 5 Dec 2023 03:52:59 +0000
Joyce Kong <joyce.kong@arm.com> wrote:
> The cpu info in some cross files is inconsistent with
> that in SoC flags. The mismatch doesn't cause any issue
> because the cpu field in the cross file takes no effect
> and machine_args in config/arm/meson.build actually works.
> Use a common one in cross files to remove any confusion.
>
> Reported-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Good to see consolidation instead of copy/paste.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 28+ messages in thread
* RE: [EXT] Re: [PATCH v4 2/2] config/arm: use common cpu arch for cross files
2023-12-07 22:41 ` Stephen Hemminger
@ 2024-01-19 19:40 ` Pavan Nikhilesh Bhagavatula
0 siblings, 0 replies; 28+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2024-01-19 19:40 UTC (permalink / raw)
To: Stephen Hemminger, Joyce Kong
Cc: thomas, ruifeng.wang, bruce.richardson, dev, nd,
Honnappa Nagarahalli, Jerin Jacob
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Friday, December 8, 2023 4:12 AM
> To: Joyce Kong <joyce.kong@arm.com>
> Cc: thomas@monjalon.net; ruifeng.wang@arm.com;
> bruce.richardson@intel.com; dev@dpdk.org; nd@arm.com; Honnappa
> Nagarahalli <honnappa.nagarahalli@arm.com>
> Subject: [EXT] Re: [PATCH v4 2/2] config/arm: use common cpu arch for cross
> files
>
> External Email
>
> ----------------------------------------------------------------------
> On Tue, 5 Dec 2023 03:52:59 +0000
> Joyce Kong <joyce.kong@arm.com> wrote:
>
> > The cpu info in some cross files is inconsistent with
> > that in SoC flags. The mismatch doesn't cause any issue
> > because the cpu field in the cross file takes no effect
> > and machine_args in config/arm/meson.build actually works.
> > Use a common one in cross files to remove any confusion.
> >
> > Reported-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
> Good to see consolidation instead of copy/paste.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Tested-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v4 2/2] config/arm: use common cpu arch for cross files
2023-12-05 3:52 ` [PATCH v4 2/2] config/arm: use common cpu arch for cross files Joyce Kong
2023-12-07 22:41 ` Stephen Hemminger
@ 2024-02-18 17:56 ` Thomas Monjalon
2024-02-22 21:38 ` Wathsala Wathawana Vithanage
1 sibling, 1 reply; 28+ messages in thread
From: Thomas Monjalon @ 2024-02-18 17:56 UTC (permalink / raw)
To: Joyce Kong; +Cc: ruifeng.wang, bruce.richardson, dev, nd, Honnappa Nagarahalli
05/12/2023 04:52, Joyce Kong:
> The cpu info in some cross files is inconsistent with
> that in SoC flags. The mismatch doesn't cause any issue
> because the cpu field in the cross file takes no effect
> and machine_args in config/arm/meson.build actually works.
> Use a common one in cross files to remove any confusion.
>
> Reported-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
[...]
> --- a/config/arm/arm64_armada_linux_gcc
> +++ b/config/arm/arm64_armada_linux_gcc
> @@ -10,7 +10,7 @@ pcap-config = ''
> [host_machine]
> system = 'linux'
> cpu_family = 'aarch64'
> -cpu = 'armv8-a'
> +cpu = 'aarch64'
Why aarch64 here and below?
> --- a/config/arm/arm64_armv8_linux_clang_ubuntu
> +++ b/config/arm/arm64_armv8_linux_clang_ubuntu
> @@ -10,7 +10,7 @@ pkgconfig = 'aarch64-linux-gnu-pkg-config'
> [host_machine]
> system = 'linux'
> cpu_family = 'aarch64'
> -cpu = 'armv8-a'
> +cpu = 'auto'
[...]
> --- a/config/arm/arm64_hip10_linux_gcc
> +++ b/config/arm/arm64_hip10_linux_gcc
> @@ -9,7 +9,7 @@ pcap-config = ''
> [host_machine]
> system = 'linux'
> cpu_family = 'aarch64'
> -cpu = 'armv8-a'
> +cpu = 'aarch64'
^ permalink raw reply [flat|nested] 28+ messages in thread
* RE: [PATCH v4 2/2] config/arm: use common cpu arch for cross files
2024-02-18 17:56 ` Thomas Monjalon
@ 2024-02-22 21:38 ` Wathsala Wathawana Vithanage
2024-03-06 14:43 ` Thomas Monjalon
0 siblings, 1 reply; 28+ messages in thread
From: Wathsala Wathawana Vithanage @ 2024-02-22 21:38 UTC (permalink / raw)
To: thomas; +Cc: Ruifeng Wang, bruce.richardson, dev, nd, Honnappa Nagarahalli, nd
Hi Thomas,
> > [host_machine]
> > system = 'linux'
> > cpu_family = 'aarch64'
> > -cpu = 'armv8-a'
> > +cpu = 'aarch64'
>
> Why aarch64 here and below?
Joyce is no longer with Arm, and we have not been able to figure out
this patch. I think the first patch of this series makes sense.
This second patch to us looks like a nice to have, rather than something
that fixes an issue. Therefore, we would like to pull this patch out of the
series and leave first patch intact.
Any concerns/comments on that?
>
> > --- a/config/arm/arm64_armv8_linux_clang_ubuntu
> > +++ b/config/arm/arm64_armv8_linux_clang_ubuntu
> > @@ -10,7 +10,7 @@ pkgconfig = 'aarch64-linux-gnu-pkg-config'
> > [host_machine]
> > system = 'linux'
> > cpu_family = 'aarch64'
> > -cpu = 'armv8-a'
> > +cpu = 'auto'
>
> [...]
> > --- a/config/arm/arm64_hip10_linux_gcc
> > +++ b/config/arm/arm64_hip10_linux_gcc
> > @@ -9,7 +9,7 @@ pcap-config = ''
> > [host_machine]
> > system = 'linux'
> > cpu_family = 'aarch64'
> > -cpu = 'armv8-a'
> > +cpu = 'aarch64'
>
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v4 2/2] config/arm: use common cpu arch for cross files
2024-02-22 21:38 ` Wathsala Wathawana Vithanage
@ 2024-03-06 14:43 ` Thomas Monjalon
2024-03-06 15:01 ` Wathsala Wathawana Vithanage
0 siblings, 1 reply; 28+ messages in thread
From: Thomas Monjalon @ 2024-03-06 14:43 UTC (permalink / raw)
To: Wathsala Wathawana Vithanage
Cc: dev, Ruifeng Wang, bruce.richardson, nd, Honnappa Nagarahalli,
nd, paul.szczepanek
22/02/2024 22:38, Wathsala Wathawana Vithanage:
> Hi Thomas,
>
> > > [host_machine]
> > > system = 'linux'
> > > cpu_family = 'aarch64'
> > > -cpu = 'armv8-a'
> > > +cpu = 'aarch64'
> >
> > Why aarch64 here and below?
>
> Joyce is no longer with Arm, and we have not been able to figure out
> this patch. I think the first patch of this series makes sense.
> This second patch to us looks like a nice to have, rather than something
> that fixes an issue. Therefore, we would like to pull this patch out of the
> series and leave first patch intact.
> Any concerns/comments on that?
OK
What will become this second patch?
^ permalink raw reply [flat|nested] 28+ messages in thread
* RE: [PATCH v4 2/2] config/arm: use common cpu arch for cross files
2024-03-06 14:43 ` Thomas Monjalon
@ 2024-03-06 15:01 ` Wathsala Wathawana Vithanage
2024-03-06 15:04 ` Wathsala Wathawana Vithanage
0 siblings, 1 reply; 28+ messages in thread
From: Wathsala Wathawana Vithanage @ 2024-03-06 15:01 UTC (permalink / raw)
To: thomas
Cc: dev, Ruifeng Wang, bruce.richardson, nd, Honnappa Nagarahalli,
nd, Paul Szczepanek, nd
> > Joyce is no longer with Arm, and we have not been able to figure out
> > this patch. I think the first patch of this series makes sense.
> > This second patch to us looks like a nice to have, rather than
> > something that fixes an issue. Therefore, we would like to pull this
> > patch out of the series and leave first patch intact.
> > Any concerns/comments on that?
>
> OK
> What will become this second patch?
>
I will suppress patch 2/2.
Thanks.
^ permalink raw reply [flat|nested] 28+ messages in thread
* RE: [PATCH v4 2/2] config/arm: use common cpu arch for cross files
2024-03-06 15:01 ` Wathsala Wathawana Vithanage
@ 2024-03-06 15:04 ` Wathsala Wathawana Vithanage
2024-03-06 15:35 ` Thomas Monjalon
0 siblings, 1 reply; 28+ messages in thread
From: Wathsala Wathawana Vithanage @ 2024-03-06 15:04 UTC (permalink / raw)
To: Wathsala Wathawana Vithanage, thomas
Cc: dev, Ruifeng Wang, bruce.richardson, nd, Honnappa Nagarahalli,
nd, Paul Szczepanek, nd, nd
> >
> > OK
> > What will become this second patch?
> >
> I will suppress patch 2/2.
> Thanks.
I'm not allowed to suppress it, perhaps someone with admin privileges could do it.
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v4 2/2] config/arm: use common cpu arch for cross files
2024-03-06 15:04 ` Wathsala Wathawana Vithanage
@ 2024-03-06 15:35 ` Thomas Monjalon
0 siblings, 0 replies; 28+ messages in thread
From: Thomas Monjalon @ 2024-03-06 15:35 UTC (permalink / raw)
To: Wathsala Wathawana Vithanage
Cc: dev, Ruifeng Wang, bruce.richardson, Honnappa Nagarahalli,
Paul Szczepanek
06/03/2024 16:04, Wathsala Wathawana Vithanage:
> > >
> > > OK
> > > What will become this second patch?
> > >
> > I will suppress patch 2/2.
> > Thanks.
> I'm not allowed to suppress it, perhaps someone with admin privileges could do it.
We don't suppress anything :)
I can change the status to rejected but why not continuing this cleanup?
^ permalink raw reply [flat|nested] 28+ messages in thread