From: "Wang, ShougangX" <shougangx.wang@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
"Guo, Jia" <jia.guo@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table
Date: Fri, 24 Jul 2020 02:34:41 +0000 [thread overview]
Message-ID: <BYAPR11MB3477A02730D77D5AC29B4E6088770@BYAPR11MB3477.namprd11.prod.outlook.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E7061154864F86@SHSMSX103.ccr.corp.intel.com>
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Thursday, July 23, 2020 8:53 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Wang, ShougangX
> <shougangx.wang@intel.com>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang,
> ShougangX <shougangx.wang@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table
>
>
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Yang, Qiming
> > Sent: Thursday, July 23, 2020 9:57 AM
> > To: Wang, ShougangX <shougangx.wang@intel.com>; dev@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia
> > <jia.guo@intel.com>; Wang, ShougangX <shougangx.wang@intel.com>;
> > stable@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look
> > up table
> >
> > I don't understand why you add new function and new function mostly do
> > the same thing.
> > Why don't add fix in original code.
> >
<snip>
> > > static int
> > > i40e_pf_config_mq_rx(struct i40e_pf *pf) {
> > > - int ret = 0;
> > > + int ret;
> > > enum rte_eth_rx_mq_mode mq_mode = pf->dev_data-
> > > >dev_conf.rxmode.mq_mode;
> > >
> > > + /* Initialize hash look up table */
> > > + ret = i40e_pf_init_rss_lut(pf);
> > > + if (ret)
> > > + return ret;
> > > +
> > > /* RSS setup */
> > > if (mq_mode & ETH_MQ_RX_RSS_FLAG)
>
> I agree with Qiming, if we move this check into i40e_pf_config_rss, dose that
> looks we don't need to create a new function?
Indeed, I will do like this.
>
> > > ret = i40e_pf_config_rss(pf);
> > > --
> > > 2.17.1
>
next prev parent reply other threads:[~2020-07-24 2:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 6:35 [dpdk-dev] [PATCH] " Shougang Wang
2020-07-15 9:07 ` Chen, BoX C
2020-07-18 4:07 ` Jeff Guo
2020-07-21 5:49 ` [dpdk-dev] [PATCH v2] " Shougang Wang
2020-07-21 6:41 ` Xie, WeiX
2020-07-22 5:50 ` Jeff Guo
2020-07-22 6:39 ` Wang, ShougangX
2020-07-22 5:31 ` Zhang, Qi Z
2020-07-22 6:20 ` Wang, ShougangX
2020-07-22 8:15 ` [dpdk-dev] [PATCH v3] " Shougang Wang
2020-07-23 1:57 ` Yang, Qiming
2020-07-23 12:53 ` Zhang, Qi Z
2020-07-24 2:34 ` Wang, ShougangX [this message]
2020-07-24 2:47 ` [dpdk-dev] [PATCH v4] " Shougang Wang
2020-07-24 3:57 ` Jeff Guo
2020-07-24 4:49 ` Wang, ShougangX
2020-07-24 5:07 ` Yang, Qiming
2020-07-24 5:42 ` Wang, ShougangX
2020-07-24 8:12 ` [dpdk-dev] [PATCH v5] " Shougang Wang
2020-07-24 9:00 ` Xie, WeiX
2020-07-24 9:38 ` [dpdk-dev] [PATCH v6] " Shougang Wang
2020-07-24 9:54 ` Jeff Guo
2020-07-24 9:58 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3477A02730D77D5AC29B4E6088770@BYAPR11MB3477.namprd11.prod.outlook.com \
--to=shougangx.wang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).