From: David Marchand <david.marchand@redhat.com>
To: Vamsi Krishna Attunuru <vattunuru@marvell.com>,
Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [EXT] Re: [PATCH] kni: fix build with Linux 6.3
Date: Thu, 13 Apr 2023 09:22:05 +0200 [thread overview]
Message-ID: <CAJFAV8wvvvH-gC=o9ZkBHxqp-v6xw+tLHLRtpxFqBkE5tcPyvA@mail.gmail.com> (raw)
In-Reply-To: <MWHPR18MB0942EFCA7A6BC50DD991EF81A6849@MWHPR18MB0942.namprd18.prod.outlook.com>
On Fri, Mar 24, 2023 at 4:04 AM Vamsi Krishna Attunuru
<vattunuru@marvell.com> wrote:
> > > So I think the dpdk commit e73831dc6c26 ("kni: support userspace VA")
> > > uselessly introduced call to this flag and we can remove it.
> > > Adding author and reviewers of this change.
> >
> > Alternatively, we could go with passing 0 in flags when FOLL_TOUCH is not
> > exported.
> > Something like:
>
> Yes, this flag is useless, I vaguely remember like I added it from v1(in that patch series) itself along with multiple kernel version checks,
> but by looking at the internals neither of them would not need it.
>
> We could pass 0 in flags as suggested.
Ok, thanks for the confirmation Vamsi.
Ferruh, can you submit a v2?
--
David Marchand
next prev parent reply other threads:[~2023-04-13 7:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 17:29 Ferruh Yigit
2023-02-28 20:45 ` David Marchand
2023-03-20 12:10 ` David Marchand
2023-03-20 13:01 ` David Marchand
2023-03-24 3:04 ` [EXT] " Vamsi Krishna Attunuru
2023-04-13 7:22 ` David Marchand [this message]
2023-04-14 15:29 ` Ferruh Yigit
2023-04-14 15:25 ` [PATCH v2] " Ferruh Yigit
2023-04-17 7:32 ` David Marchand
2023-04-19 14:38 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wvvvH-gC=o9ZkBHxqp-v6xw+tLHLRtpxFqBkE5tcPyvA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=thomas@monjalon.net \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).