From: David Marchand <david.marchand@6wind.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/2] Added functions to get RX/TX default configuration
Date: Mon, 29 Sep 2014 16:40:34 +0200 [thread overview]
Message-ID: <CALwxeUujSbNZ8u4w=w-Wacqmqw+4MBJoskbiFX7ZT2MYiU_ovw@mail.gmail.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D89722628293@IRSMSX108.ger.corp.intel.com>
Hello Pablo,
On Mon, Sep 29, 2014 at 4:02 PM, De Lara Guarch, Pablo <
pablo.de.lara.guarch@intel.com> wrote:
> Hi David,
>
> > - All I can see in this patchset is stuff that should remain in the PMD
> (since
> > this is really specific to them).
> >
> > - Anyway, if you want to let application get this information, why the
> new API
> > ?
> > From my point of view, this should go in rte_eth_dev_info_get().
>
> Thanks for the comments. Main changes are in the PMDs, and I only added
> two functions in rte_ethdev.c, which basically calls the functions in the
> PMDs.
> Anyway, so you suggest to modify the rte_eth_dev_info structure, so it
> also contains these two structures populated with the default values?
>
- Yep, that would be the idea.
This way applications can reuse these structures "as is" or change some
values before calling rx / tx _queue_setup.
- By the way, I noticed that rte_eth_dev_info_get() is only resetting part
of the dev_info structure given by the user.
We might want to reset the dev_info structure to 0 before filling it ?
>From my point of view, rte_eth_dev_info_get() is not in the datapath.
I would prefer it to be safe.
--
David Marchand
next prev parent reply other threads:[~2014-09-29 14:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 14:19 Pablo de Lara
2014-09-26 14:19 ` [dpdk-dev] [PATCH 1/2] pmd: Added rte_eth_rxconf_defaults and rte_eth_txconf defaults functions Pablo de Lara
2014-09-26 14:19 ` [dpdk-dev] [PATCH 2/2] app: Used rte_eth_rxconf_defaults and rte_eth_txconf_defaults in apps Pablo de Lara
2014-09-27 18:45 ` [dpdk-dev] [PATCH 0/2] Added functions to get RX/TX default configuration David Marchand
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D89722628264@IRSMSX108.ger.corp.intel.com>
2014-09-29 14:02 ` De Lara Guarch, Pablo
2014-09-29 14:40 ` David Marchand [this message]
2014-10-01 8:00 ` [dpdk-dev] [PATCH v2 0/2] Get default RX/TX configuration Pablo de Lara
2014-10-01 8:00 ` [dpdk-dev] [PATCH v2 1/2] pmd: Modified dev_info structure to include " Pablo de Lara
2014-10-01 8:38 ` Bruce Richardson
2014-10-01 8:42 ` Bruce Richardson
2014-10-01 8:45 ` David Marchand
2014-10-01 8:00 ` [dpdk-dev] [PATCH v2 2/2] app: Used default RX/TX configuration got from dev info in apps Pablo de Lara
2014-10-01 9:49 ` [dpdk-dev] [PATCH v3 0/3] Get default RX/TX configuration Pablo de Lara
2014-10-01 9:49 ` [dpdk-dev] [PATCH v3 1/3] ether: Reset whole dev info structure Pablo de Lara
2014-10-10 11:08 ` Thomas Monjalon
2014-10-01 9:49 ` [dpdk-dev] [PATCH v3 2/3] pmd: Modified dev_info structure to include default RX/TX configuration Pablo de Lara
2014-10-10 11:14 ` Thomas Monjalon
2014-10-10 12:05 ` De Lara Guarch, Pablo
2014-10-01 9:49 ` [dpdk-dev] [PATCH v3 3/3] app: Used default RX/TX configuration got from dev info in apps Pablo de Lara
2014-10-10 11:20 ` Thomas Monjalon
2014-10-10 12:07 ` De Lara Guarch, Pablo
2014-10-01 9:54 ` [dpdk-dev] [PATCH v3 0/3] Get default RX/TX configuration De Lara Guarch, Pablo
2014-10-02 10:18 ` David Marchand
2014-10-10 12:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUujSbNZ8u4w=w-Wacqmqw+4MBJoskbiFX7ZT2MYiU_ovw@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).