From: Bing Zhao <bingz@nvidia.com>
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Cc: Ori Kam <orika@nvidia.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"mdr@ashroe.eu" <mdr@ashroe.eu>,
"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
"beilei.xing@intel.com" <beilei.xing@intel.com>,
"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add hairpin bind and unbind APIs
Date: Thu, 15 Oct 2020 02:56:59 +0000 [thread overview]
Message-ID: <CY4PR1201MB00728B8A226B7A30FD220CDAD0020@CY4PR1201MB0072.namprd12.prod.outlook.com> (raw)
In-Reply-To: <3492876.G95Fza0IFT@thomas>
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, October 14, 2020 10:36 PM
> To: Bing Zhao <bingz@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>; ferruh.yigit@intel.com;
> arybchenko@solarflare.com; mdr@ashroe.eu; nhorman@tuxdriver.com;
> bernard.iremonger@intel.com; beilei.xing@intel.com;
> wenzhuo.lu@intel.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add hairpin bind and
> unbind APIs
>
> External email: Use caution opening links or attachments
>
>
> Hi,
> Cosmetic comments below:
>
> 08/10/2020 14:05, Bing Zhao:
> > +int
> > +rte_eth_hairpin_bind(uint16_t tx_port, uint16_t rx_port) {
> > + struct rte_eth_dev *dev;
> > + int ret;
> > +
> > + RTE_ETH_VALID_PORTID_OR_ERR_RET(tx_port, -EINVAL);
>
> It should be -ENODEV
Got it, changed. BTW, I checked the ethdev and it seems some functions are using "EINVAL" and some are using "ENODEV". So should all of these functions use "ENODEV"?
>
> > + dev = &rte_eth_devices[tx_port];
> > + if (!dev->data->dev_started) {
> > + RTE_ETHDEV_LOG(ERR, "TX port %d is not started",
> tx_port);
> > + return -EBUSY;
> > + }
> > +
> > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->hairpin_bind, -
> ENOTSUP);
> > + ret = (*dev->dev_ops->hairpin_bind)(dev, rx_port);
> > + if (ret)
> > + RTE_ETHDEV_LOG(ERR, "Failed to bind hairpin TX %d "
> > + "to RX %d (%d - all ports)", tx_port,
> > + rx_port, RTE_MAX_ETHPORTS);
>
> Looks like \n is missing.
Fixed, thanks.
>
> > +
> > + return ret;
> > +}
> > +
> > +int
> > +rte_eth_hairpin_unbind(uint16_t tx_port, uint16_t rx_port)
>
> Same comments as for bind function.
Done.
>
> [...]
> > /**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change, or be removed, without
> prior
> > + notice
> > + *
> > + * Bind all hairpin TX queues of one port to the RX queues of the
> peer port.
> > + * It is only allowed to call this API after all hairpin queues
> are
> > + configured
> > + * properly and the devices of TX and peer RX are in started
> state.
>
> "call this API" -> "call this function"
Done.
>
> "devices of TX" is a strange wording.
> I would make it simpler:
> "the devices of TX and peer RX" -> "the devices"
>
> > + *
> > + * @param tx_port
> > + * The TX port identifier of the Ethernet device.
>
> A device does not have a TX port.
> I think you mean "The identifier of the TX port."
Done.
>
> > + * @param rx_port
> > + * The peer RX port identifier of the Ethernet device.
>
> Remove "of the Ethernet device"
Done.
>
> > + * RTE_MAX_ETHPORTS is allowed for the traversal of all devices.
> > + * RX port ID could have the same value with TX port ID.
>
> "same value as"
Done.
>
> > + *
> > + * @return
> > + * - (0) if successful.
> > + * - (-EINVAL) if bad parameter.
> > + * - (-EBUSY) if device is not in started state.
> > + * - (-ENOTSUP) if hardware doesn't support.
> > + * - Others detailed errors from PMD drivers.
>
> Please add ENODEV case, maybe instead of EINVAL.
Replaced. PMD may return -EINVAL but it is not necessary so I will not list it here anymore.
>
> > + */
> > +__rte_experimental
> > +int rte_eth_hairpin_bind(uint16_t tx_port, uint16_t rx_port);
> > +
> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change, or be removed, without
> prior
> > +notice
> > + *
> > + * Unbind all hairpin TX queues of one port from the RX queues of
> the peer port.
> > + * This should be called before closing the TX or RX devices
> > +(optional). After
>
> Split the line after the end of sentence and start next one on a
> fresh line.
>
Done
> > + * unbind the hairpin ports pair, it is allowed to bind them
> again.
>
> "unbind" -> "unbinding"
Done
>
> > + * Changing queues configuration should be after stopping the
> device.
> > + *
> > + * @param tx_port
> > + * The TX port identifier of the Ethernet device.
> > + * @param rx_port
> > + * The peer RX port identifier of the Ethernet device.
> > + * RTE_MAX_ETHPORTS is allowed for traversal of all devices.
> > + * RX port ID could have the same value with TX port ID.
> > + *
> > + * @return
> > + * - (0) if successful.
> > + * - (-EINVAL) if bad parameter.
> > + * - (-EBUSY) if device is in stopped state.
> > + * - (-ENOTSUP) if hardware doesn't support.
> > + * - Others detailed errors from PMD drivers.
>
> Same comments as for the bind function.
Done.
>
> > + */
> > +__rte_experimental
> > +int rte_eth_hairpin_unbind(uint16_t tx_port, uint16_t rx_port);
>
>
Thanks a lot
next prev parent reply other threads:[~2020-10-15 2:57 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 4:51 [dpdk-dev] [RFC] introduce support for hairpin between two ports Bing Zhao
2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 0/4] " Bing Zhao
2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 1/4] ethdev: add support for flow item transmit queue Bing Zhao
2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 2/4] testpmd: add item transmit queue in flow CLI Bing Zhao
2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 3/4] ethdev: add hairpin bind APIs Bing Zhao
2020-09-13 15:49 ` [dpdk-dev] [RFC PATCH v2 4/4] ethdev: add new attributes to hairpin queues config Bing Zhao
2020-10-01 0:25 ` [dpdk-dev] [PATCH 0/4] introduce support for hairpin between two ports Bing Zhao
2020-10-01 0:25 ` [dpdk-dev] [PATCH 1/4] ethdev: add hairpin bind and unbind APIs Bing Zhao
2020-10-04 9:20 ` Ori Kam
2020-10-07 11:21 ` Bing Zhao
2020-10-07 11:42 ` Ori Kam
2020-10-01 0:26 ` [dpdk-dev] [PATCH 2/4] ethdev: add new attributes to hairpin config Bing Zhao
2020-10-04 9:22 ` Ori Kam
2020-10-07 11:32 ` Bing Zhao
2020-10-01 0:26 ` [dpdk-dev] [PATCH 3/4] ethdev: add APIs for hairpin queue operation Bing Zhao
2020-10-04 9:34 ` Ori Kam
2020-10-07 11:34 ` Bing Zhao
2020-10-01 0:26 ` [dpdk-dev] [PATCH 4/4] app/testpmd: change hairpin queues setup Bing Zhao
2020-10-04 9:39 ` Ori Kam
2020-10-07 11:36 ` Bing Zhao
2020-10-04 9:45 ` [dpdk-dev] [PATCH 0/4] introduce support for hairpin between two ports Ori Kam
2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 0/6] " Bing Zhao
2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 1/6] ethdev: add hairpin bind and unbind APIs Bing Zhao
2020-10-08 9:07 ` Ori Kam
2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 2/6] ethdev: add new attributes to hairpin config Bing Zhao
2020-10-08 9:23 ` Ori Kam
2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 3/6] ethdev: add API to get hairpin peer ports list Bing Zhao
2020-10-08 9:40 ` Ori Kam
2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 4/6] ethdev: add APIs for hairpin queue operation Bing Zhao
2020-10-08 9:44 ` Ori Kam
2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 5/6] app/testpmd: change hairpin queues setup Bing Zhao
2020-10-08 9:45 ` Ori Kam
2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 6/6] doc: update for two ports hairpin mode Bing Zhao
2020-10-08 9:47 ` Ori Kam
2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 0/6] introduce support for hairpin between two ports Bing Zhao
2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 1/6] ethdev: add hairpin bind and unbind APIs Bing Zhao
2020-10-14 14:35 ` Thomas Monjalon
2020-10-15 2:56 ` Bing Zhao [this message]
2020-10-15 7:31 ` Thomas Monjalon
2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 2/6] ethdev: add new attributes to hairpin config Bing Zhao
2020-10-12 21:37 ` Thomas Monjalon
2020-10-13 12:29 ` Bing Zhao
2020-10-13 12:41 ` Thomas Monjalon
2020-10-13 13:21 ` Bing Zhao
2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 3/6] ethdev: add API to get hairpin peer ports list Bing Zhao
2020-10-08 12:31 ` Ori Kam
2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 4/6] ethdev: add APIs for hairpin queue operation Bing Zhao
2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 5/6] app/testpmd: change hairpin queues setup Bing Zhao
2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 6/6] doc: update for two ports hairpin mode Bing Zhao
2020-10-12 21:30 ` Thomas Monjalon
2020-10-13 1:13 ` Bing Zhao
2020-10-13 6:37 ` Thomas Monjalon
2020-10-13 6:40 ` Bing Zhao
2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 0/5] introduce support for hairpin between two ports Bing Zhao
2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 1/5] ethdev: add hairpin bind and unbind APIs Bing Zhao
2020-10-14 14:43 ` Thomas Monjalon
2020-10-15 2:59 ` Bing Zhao
2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 2/5] ethdev: add new attributes to hairpin config Bing Zhao
2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 3/5] ethdev: add API to get hairpin peer ports list Bing Zhao
2020-10-14 15:02 ` Thomas Monjalon
2020-10-15 4:03 ` Bing Zhao
2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 4/5] ethdev: add APIs for hairpin queue operation Bing Zhao
2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 5/5] app/testpmd: change hairpin queues setup Bing Zhao
2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 0/5] introduce support for hairpin between two ports Bing Zhao
2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 1/5] ethdev: add hairpin bind and unbind APIs Bing Zhao
2020-10-15 10:34 ` Thomas Monjalon
2020-10-15 11:39 ` Bing Zhao
2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 2/5] ethdev: add new attributes to hairpin config Bing Zhao
2020-10-15 10:46 ` Thomas Monjalon
2020-10-15 13:45 ` Bing Zhao
2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 3/5] ethdev: add API to get hairpin peer ports list Bing Zhao
2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 4/5] ethdev: add APIs for hairpin queue operation Bing Zhao
2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 5/5] app/testpmd: change hairpin queues setup Bing Zhao
2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 0/5] introduce support for hairpin between two ports Bing Zhao
2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 1/5] ethdev: add hairpin bind and unbind APIs Bing Zhao
2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 2/5] ethdev: add new attributes to hairpin config Bing Zhao
2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 3/5] ethdev: add API to get hairpin peer ports list Bing Zhao
2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 4/5] ethdev: add APIs for hairpin queue operation Bing Zhao
2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 5/5] app/testpmd: change hairpin queues setup Bing Zhao
2020-10-15 23:03 ` [dpdk-dev] [PATCH v6 0/5] introduce support for hairpin between two ports Ferruh Yigit
2020-10-16 1:34 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1201MB00728B8A226B7A30FD220CDAD0020@CY4PR1201MB0072.namprd12.prod.outlook.com \
--to=bingz@nvidia.com \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).