From: Ori Kam <orika@nvidia.com> To: Bing Zhao <bingz@nvidia.com>, NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "mdr@ashroe.eu" <mdr@ashroe.eu>, "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>, "bernard.iremonger@intel.com" <bernard.iremonger@intel.com>, "beilei.xing@intel.com" <beilei.xing@intel.com>, "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v2 3/6] ethdev: add API to get hairpin peer ports list Date: Thu, 8 Oct 2020 09:40:42 +0000 Message-ID: <MN2PR12MB42863E4026D8921E460BC9D0D60B0@MN2PR12MB4286.namprd12.prod.outlook.com> (raw) In-Reply-To: <1602147098-9768-4-git-send-email-bingz@nvidia.com> Hi Bing, PSB, Best, Ori > -----Original Message----- > From: Bing Zhao <bingz@nvidia.com> > Sent: Thursday, October 8, 2020 11:52 AM > Subject: [PATCH v2 3/6] ethdev: add API to get hairpin peer ports list > > After hairpin queues are configured, in general, the application will > maintain the ports topology and even the queues configuration for > hairpin. But sometimes it will not. > > If there is no hot-plug, it is easy to bind and unbind hairpin among > all the ports. The application can just connect or disconnect the > hairpin egress ports to / from all the probed ingress ports. Then > all the connections could be handled properly. > > But with hot-plug / hot-unplug, one port could be probed and removed > dynamically. With two ports hairpin, all the connections from and to > this port should be handled after start(bind) or before stop(unbind). > It is necessary to know the hairpin topology with this port. > > This API will return the ports list with the actual peer ports number > after configuration. Either peer RX or TX ports will be gotten with > this function call. > > Signed-off-by: Bing Zhao <bingz@nvidia.com> > --- > lib/librte_ethdev/rte_ethdev.c | 24 ++++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev.h | 27 +++++++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev_driver.h | 30 > ++++++++++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev_version.map | 1 + > 4 files changed, 82 insertions(+) > > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > index a4adeff..ea7892a 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -2208,6 +2208,30 @@ struct rte_eth_dev * > return ret; > } > > +int > +rte_eth_hairpin_get_peer_ports(uint16_t cur_port, uint16_t *peer_ports, > + bool direction) > +{ > + struct rte_eth_dev *dev; > + int ret; > + > + if (!peer_ports) > + return -EINVAL; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(cur_port, -EINVAL); > + dev = &rte_eth_devices[cur_port]; > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops- > >hairpin_get_peer_ports, > + -ENOTSUP); > + > + ret = (*dev->dev_ops->hairpin_get_peer_ports)(dev, peer_ports, > + direction); > + if (ret < 0) > + RTE_ETHDEV_LOG(ERR, "Failed to get %d hairpin peer %s > ports", > + cur_port, direction ? "RX" : "TX"); > + > + return ret; > +} > + > void > rte_eth_tx_buffer_drop_callback(struct rte_mbuf **pkts, uint16_t unsent, > void *userdata __rte_unused) > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 94a981c..6680de2 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -2134,6 +2134,33 @@ int rte_eth_tx_queue_setup(uint16_t port_id, > uint16_t tx_queue_id, > * @warning > * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > * > + * Get all the hairpin peer RX / TX ports of the current port. > + * The caller should ensure that the array is large enough to save the ports > + * list. > + * > + * @param cur_port > + * The current port identifier of the Ethernet device. > + * @param peer_ports > + * Pointer to the array to save the peer ports list * > + * @param direction > + * Current port to peer port direction > + * true - current used as TX to get all peer RX ports. > + * false - current used as RX to get all peer TX ports. > + * > + * @return > + * - (0 or positive) actual peer ports number. > + * - (-EINVAL) if bad parameter. > + * - (-ENOTSUP) if hardware doesn't support. > + * - Others detailed errors from PMD drivers. > + */ > +__rte_experimental > +int rte_eth_hairpin_get_peer_ports(uint16_t cur_port, uint16_t *peer_ports, > + bool direction); > + I think direction should be changed to int, or change the name to ingress, also I think we should add the peer_ports array size, so in case the application didn't allocate enough space it will simply end in error. > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > + * > * Bind all hairpin TX queues of one port to the RX queues of the peer port. > * It is only allowed to call this API after all hairpin queues are configured > * properly and the devices of TX and peer RX are in started state. > diff --git a/lib/librte_ethdev/rte_ethdev_driver.h > b/lib/librte_ethdev/rte_ethdev_driver.h > index f8eb879..ecca9d6 100644 > --- a/lib/librte_ethdev/rte_ethdev_driver.h > +++ b/lib/librte_ethdev/rte_ethdev_driver.h > @@ -576,6 +576,34 @@ typedef int (*eth_tx_hairpin_queue_setup_t) > > /** > * @internal > + * Get all hairpin TX/RX peer ports of the current device, if any. > + * > + * @param dev > + * ethdev handle of port. > + * @param peer_ports > + * array to save the ports list. > + * @param direction > + * value to decide the current to peer direction > + * true - used as TX to get all peer RX ports. > + * false - used as RX to get all peer TX ports. > + * > + * @return > + * Negative errno value on error, 0 or positive on success. > + * > + * @retval 0 > + * Success, no peer ports. > + * @retval >0 > + * Actual number of the peer ports. > + * @retval -ENOTSUP > + * Get peer ports API is not supported. > + * @retval -EINVAL > + * One of the parameters is invalid. > + */ > +typedef int (*hairpin_get_peer_ports_t)(struct rte_eth_dev *dev, > + uint16_t *peer_ports, bool direction); > + > +/** > + * @internal > * Bind all hairpin TX queues of one port to the RX queues of the peer port. > * > * @param dev > @@ -761,6 +789,8 @@ struct eth_dev_ops { > /**< Set up device RX hairpin queue. */ > eth_tx_hairpin_queue_setup_t tx_hairpin_queue_setup; > /**< Set up device TX hairpin queue. */ > + hairpin_get_peer_ports_t hairpin_get_peer_ports; > + /**< Get hairpin peer ports list. */ > eth_hairpin_bind_t hairpin_bind; > /**< Bind all hairpin TX queues of device to the peer port RX queues. */ > eth_hairpin_unbind_t hairpin_unbind; > diff --git a/lib/librte_ethdev/rte_ethdev_version.map > b/lib/librte_ethdev/rte_ethdev_version.map > index 18efe4e..1019e28 100644 > --- a/lib/librte_ethdev/rte_ethdev_version.map > +++ b/lib/librte_ethdev/rte_ethdev_version.map > @@ -228,6 +228,7 @@ EXPERIMENTAL { > > # added in 20.11 > rte_eth_hairpin_bind; > + rte_eth_hairpin_get_peer_ports; > rte_eth_hairpin_unbind; > rte_eth_link_speed_to_str; > rte_eth_link_to_str; > -- > 1.8.3.1
next prev parent reply other threads:[~2020-10-08 9:41 UTC|newest] Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-11 4:51 [dpdk-dev] [RFC] introduce support for hairpin between two ports Bing Zhao 2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 0/4] " Bing Zhao 2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 1/4] ethdev: add support for flow item transmit queue Bing Zhao 2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 2/4] testpmd: add item transmit queue in flow CLI Bing Zhao 2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 3/4] ethdev: add hairpin bind APIs Bing Zhao 2020-09-13 15:49 ` [dpdk-dev] [RFC PATCH v2 4/4] ethdev: add new attributes to hairpin queues config Bing Zhao 2020-10-01 0:25 ` [dpdk-dev] [PATCH 0/4] introduce support for hairpin between two ports Bing Zhao 2020-10-01 0:25 ` [dpdk-dev] [PATCH 1/4] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-04 9:20 ` Ori Kam 2020-10-07 11:21 ` Bing Zhao 2020-10-07 11:42 ` Ori Kam 2020-10-01 0:26 ` [dpdk-dev] [PATCH 2/4] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-04 9:22 ` Ori Kam 2020-10-07 11:32 ` Bing Zhao 2020-10-01 0:26 ` [dpdk-dev] [PATCH 3/4] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-04 9:34 ` Ori Kam 2020-10-07 11:34 ` Bing Zhao 2020-10-01 0:26 ` [dpdk-dev] [PATCH 4/4] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-04 9:39 ` Ori Kam 2020-10-07 11:36 ` Bing Zhao 2020-10-04 9:45 ` [dpdk-dev] [PATCH 0/4] introduce support for hairpin between two ports Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 0/6] " Bing Zhao 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 1/6] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-08 9:07 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 2/6] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-08 9:23 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 3/6] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-08 9:40 ` Ori Kam [this message] 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 4/6] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-08 9:44 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 5/6] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-08 9:45 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 6/6] doc: update for two ports hairpin mode Bing Zhao 2020-10-08 9:47 ` Ori Kam 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 0/6] introduce support for hairpin between two ports Bing Zhao 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 1/6] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-14 14:35 ` Thomas Monjalon 2020-10-15 2:56 ` Bing Zhao 2020-10-15 7:31 ` Thomas Monjalon 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 2/6] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-12 21:37 ` Thomas Monjalon 2020-10-13 12:29 ` Bing Zhao 2020-10-13 12:41 ` Thomas Monjalon 2020-10-13 13:21 ` Bing Zhao 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 3/6] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-08 12:31 ` Ori Kam 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 4/6] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 5/6] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 6/6] doc: update for two ports hairpin mode Bing Zhao 2020-10-12 21:30 ` Thomas Monjalon 2020-10-13 1:13 ` Bing Zhao 2020-10-13 6:37 ` Thomas Monjalon 2020-10-13 6:40 ` Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 0/5] introduce support for hairpin between two ports Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 1/5] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-14 14:43 ` Thomas Monjalon 2020-10-15 2:59 ` Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 2/5] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 3/5] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-14 15:02 ` Thomas Monjalon 2020-10-15 4:03 ` Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 4/5] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 5/5] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 0/5] introduce support for hairpin between two ports Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 1/5] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-15 10:34 ` Thomas Monjalon 2020-10-15 11:39 ` Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 2/5] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-15 10:46 ` Thomas Monjalon 2020-10-15 13:45 ` Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 3/5] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 4/5] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 5/5] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 0/5] introduce support for hairpin between two ports Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 1/5] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 2/5] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 3/5] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 4/5] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 5/5] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-15 23:03 ` [dpdk-dev] [PATCH v6 0/5] introduce support for hairpin between two ports Ferruh Yigit 2020-10-16 1:34 ` Bing Zhao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=MN2PR12MB42863E4026D8921E460BC9D0D60B0@MN2PR12MB4286.namprd12.prod.outlook.com \ --to=orika@nvidia.com \ --cc=arybchenko@solarflare.com \ --cc=beilei.xing@intel.com \ --cc=bernard.iremonger@intel.com \ --cc=bingz@nvidia.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=mdr@ashroe.eu \ --cc=nhorman@tuxdriver.com \ --cc=thomas@monjalon.net \ --cc=wenzhuo.lu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git