From: Ophir Munk <ophirmu@nvidia.com> To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>, Bernard Iremonger <bernard.iremonger@intel.com>, Olivier Matz <olivier.matz@6wind.com> Subject: Re: [dpdk-dev] [PATCH v5 0/3] Add GENEVE protocol parsing to testpmd Date: Wed, 7 Oct 2020 15:43:18 +0000 Message-ID: <DM5PR12MB1161DE367B69797418E41F32DC0A0@DM5PR12MB1161.namprd12.prod.outlook.com> (raw) In-Reply-To: <e62fe448-d629-fefb-e7df-570a2382314a@intel.com> Hi Ferruh, I sent V6 which addresses your last review. Please see more comments inline. > -----Original Message----- > From: Ferruh Yigit <ferruh.yigit@intel.com> > Sent: Tuesday, October 6, 2020 5:59 PM > On 9/18/2020 3:17 PM, Ophir Munk wrote: > > v1: > > Initial version > > v2: > > Rebased + Minor update in protocol options field: > > char opts[0] ===> uint8_t opts[] > > v3: > > Rebase > > document "geneve-port=N" parameter > > v4: > > Mispelling corrections > > v5: > > Rebase + Updates following review > > > https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch > > > es.dpdk.org%2Fpatch%2F77734%2F&data=02%7C01%7Cophirmu%40nv > idia.com > > > %7C1b01b5de39d24d61e38008d86a086ae2%7C43083d15727340c1b7db39e > fd9ccc17a > > > %7C0%7C0%7C637375931691373733&sdata=csLb5OdTmWlpv1k4Z7ZZ > YN1b1d2cd8 > > %2BTxxnydgNnyQ4%3D&reserved=0 > > > > Ophir Munk (3): > > app/testpmd: add GENEVE parsing > > app/testpmd: enable configuring GENEVE port > > app/testpmd: reduce tunnel parsing code duplication > > > > Hi Ophir, > > The patchset looks good except a few comments I put into the patches. > > But I have two highlevel questions/comments, > > 1) The testpmd tunnel parsing feature is not documented properly, there are > various related commands but there is no documentation to put all together. > What do you think putting a new section for it under the "Testpmd Runtime > Functions" (testpmd_funcs.rst) with this patchset? I prefer this to be in a separate patchset. Geneve in testpmd is not complete yet. I know that there is current work in progress to add geneve options to flows. Maybe its worth waiting till Geneve is finalized in testpmd. > > 2) The 'csum' forwarding engine seems become forwarding engine for the > case where packet payload needs to be parsed, like gro/gso, tunnel parse. > Even the description of the forwarding engine in the documentation is not > accurate now. > I wonder if we should rename the forwarding engine at this stage? Can you please be more specific to which renaming you are referring to? Can you give examples?
next prev parent reply other threads:[~2020-10-07 15:43 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-29 8:29 [dpdk-dev] [PATCH v1 " Ophir Munk 2020-07-29 8:29 ` [dpdk-dev] [PATCH v1 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-07-29 8:29 ` [dpdk-dev] [PATCH v1 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-07-29 8:29 ` [dpdk-dev] [PATCH v1 3/3] app/testpmd: reduce tunnel parsing code duplication Ophir Munk 2020-08-27 7:02 ` [dpdk-dev] [PATCH v2 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk 2020-08-27 7:02 ` [dpdk-dev] [PATCH v2 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-09-14 17:27 ` Ferruh Yigit 2020-09-15 12:53 ` [dpdk-dev] [PATCH v3 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk 2020-09-15 12:53 ` [dpdk-dev] [PATCH v3 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-09-15 13:17 ` [dpdk-dev] [PATCH v4 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk 2020-09-15 13:17 ` [dpdk-dev] [PATCH v4 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-09-15 13:56 ` Ophir Munk 2020-09-17 12:23 ` Olivier Matz 2020-09-18 14:21 ` Ophir Munk 2020-09-18 14:17 ` [dpdk-dev] [PATCH v5 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk 2020-09-18 14:17 ` [dpdk-dev] [PATCH v5 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-10-06 14:30 ` Ferruh Yigit 2020-10-07 14:52 ` Ophir Munk 2020-10-07 16:25 ` Ferruh Yigit 2020-10-08 8:44 ` Ophir Munk 2020-10-08 13:37 ` Ferruh Yigit 2020-10-07 15:30 ` [dpdk-dev] [PATCH v6 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk 2020-10-07 15:30 ` [dpdk-dev] [PATCH v6 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-10-08 20:16 ` [dpdk-dev] [PATCH v7 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk 2020-10-08 20:16 ` [dpdk-dev] [PATCH v7 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-10-08 20:16 ` [dpdk-dev] [PATCH v7 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-10-08 20:16 ` [dpdk-dev] [PATCH v7 3/3] app/testpmd: tunnel parsing protocols cleanup Ophir Munk 2020-10-09 12:49 ` [dpdk-dev] [PATCH v7 0/3] Add GENEVE protocol parsing to testpmd Ferruh Yigit 2020-10-07 15:30 ` [dpdk-dev] [PATCH v6 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-10-07 15:30 ` [dpdk-dev] [PATCH v6 3/3] app/testpmd: tunnel parsing protocols cleanup Ophir Munk 2020-10-07 16:05 ` Ferruh Yigit 2020-09-18 14:17 ` [dpdk-dev] [PATCH v5 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-09-18 14:17 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: reduce tunnel parsing code duplication Ophir Munk 2020-10-06 14:30 ` Ferruh Yigit 2020-10-07 10:56 ` Ophir Munk 2020-10-06 14:58 ` [dpdk-dev] [PATCH v5 0/3] Add GENEVE protocol parsing to testpmd Ferruh Yigit 2020-10-07 15:43 ` Ophir Munk [this message] 2020-10-07 16:00 ` Ferruh Yigit 2020-09-15 13:17 ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-09-15 13:17 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: reduce tunnel parsing code duplication Ophir Munk 2020-09-15 12:53 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-09-15 12:53 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: reduce tunnel parsing code duplication Ophir Munk 2020-08-27 7:02 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-09-14 17:31 ` Ferruh Yigit 2020-09-15 8:46 ` Ophir Munk 2020-09-15 11:07 ` Ferruh Yigit 2020-09-15 12:59 ` Ophir Munk 2020-09-15 13:19 ` Ophir Munk 2020-08-27 7:02 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: reduce tunnel parsing code duplication Ophir Munk 2020-08-31 6:40 ` [dpdk-dev] [PATCH v2 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DM5PR12MB1161DE367B69797418E41F32DC0A0@DM5PR12MB1161.namprd12.prod.outlook.com \ --to=ophirmu@nvidia.com \ --cc=beilei.xing@intel.com \ --cc=bernard.iremonger@intel.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=olivier.matz@6wind.com \ --cc=wenzhuo.lu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git