From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] app/test: fix vdev test in test_eal_flags
Date: Tue, 1 Jul 2014 11:44:49 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8971A797E1F@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1404206489-30703-1-git-send-email-olivier.matz@6wind.com>
Hi Olivier,
> -----Original Message-----
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> Sent: Tuesday, July 01, 2014 10:21 AM
> To: dev@dpdk.org; De Lara Guarch, Pablo
> Cc: olivier.matz@6wind.com
> Subject: [PATCH v2] app/test: fix vdev test in test_eal_flags
>
> In whitelist test, within EAL flags unit test, the vdev flag test fails
> because it is started in a secondary process, which is not able to
> allocate memzones and this is required to instanciate a pmd_ring.
>
> This patch changes the vdev flag test to run it in a primary process.
>
> Patch "app/test: fix build switches to enable cmdline tests"
> from Thomas Monjalon is needed for this patch.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> app/test/test_eal_flags.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
> index 1b80b80..4a50d37 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -59,6 +59,7 @@
> #define no_shconf "--no-shconf"
> #define pci_whitelist "--pci-whitelist"
> #define vdev "--vdev"
> +#define whitelist_prefix "whitelist"
> #define memtest "memtest"
> #define memtest1 "memtest1"
> #define memtest2 "memtest2"
> @@ -314,7 +315,8 @@ test_whitelist_flag(void)
> pci_whitelist, "00FF:09:0B.3"};
> const char *wlval2[] = {prgname, prefix, mp_flag, "-n", "1", "-c", "1",
> pci_whitelist, "09:0B.3", pci_whitelist, "0a:0b.1"};
> - const char *wlval3[] = {prgname, prefix, mp_flag, "-n", "1", "-c", "1",
> + const char *wlval3[] = {prgname, "--file-prefix=" whitelist_prefix,
> + "-n", "1", "-c", "1",
> pci_whitelist, "09:0B.3,type=test",
> pci_whitelist, "08:00.1,type=normal",
> #ifdef RTE_LIBRTE_PMD_RING
> --
> 1.9.2
Thanks for this. It works fine :) Actually, I am thinking of creating a separate test
for vdev, out of whitelist test, as it has no relation with it. Do you agree on this?
Thanks,
Pablo
next prev parent reply other threads:[~2014-07-01 11:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 14:42 [dpdk-dev] [PATCH] app/test: Removed vdev test in EAL flags unit test Pablo de Lara
2014-07-01 8:31 ` Olivier MATZ
2014-07-01 8:32 ` [dpdk-dev] [PATCH] app/test: fix vdev test in test_eal_flags Olivier Matz
2014-07-01 8:59 ` [dpdk-dev] [PATCH] app/test: Removed vdev test in EAL flags unit test De Lara Guarch, Pablo
2014-07-01 9:20 ` Olivier MATZ
2014-07-01 9:21 ` [dpdk-dev] [PATCH v2] app/test: fix vdev test in test_eal_flags Olivier Matz
2014-07-01 11:44 ` De Lara Guarch, Pablo [this message]
2014-07-01 12:00 ` Olivier MATZ
2014-07-01 12:11 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8971A797E1F@IRSMSX103.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).