* [dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of queues
@ 2017-12-04 6:38 zhouyangchao
2017-12-20 6:40 ` Zhang, Helin
0 siblings, 1 reply; 5+ messages in thread
From: zhouyangchao @ 2017-12-04 6:38 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang
FM10K HW does not have such restrictions.
Enabling RSS with single queue is not used to distribute flow but to
compute a RSS hash value.
It can reduce cpu cycles of computing a hash value with five tuples.
In addition, there is an explicit method to disable RSS instead of an
obscure way.
Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
---
drivers/net/fm10k/fm10k_ethdev.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 2d05a46..403f6c5 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -533,9 +533,8 @@ fm10k_dev_rss_configure(struct rte_eth_dev *dev)
0x6A, 0x42, 0xB7, 0x3B, 0xBE, 0xAC, 0x01, 0xFA,
};
- if (dev->data->nb_rx_queues == 1 ||
- dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS ||
- dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) {
+ if (dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS ||
+ dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) {
FM10K_WRITE_REG(hw, FM10K_MRQC(0), 0);
return;
}
--
2.9.0.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of queues
2017-12-04 6:38 [dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of queues zhouyangchao
@ 2017-12-20 6:40 ` Zhang, Helin
0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Helin @ 2017-12-20 6:40 UTC (permalink / raw)
To: zhouyangchao, dev; +Cc: Zhang, Qi Z
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhouyangchao
> Sent: Monday, December 4, 2017 2:38 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z
> Subject: [dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of
> queues
>
> FM10K HW does not have such restrictions.
>
> Enabling RSS with single queue is not used to distribute flow but to compute
> a RSS hash value.
> It can reduce cpu cycles of computing a hash value with five tuples.
> In addition, there is an explicit method to disable RSS instead of an obscure
> way.
>
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
Applied to next-net-intel, thanks! /Helin
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <889ce4b6-5f2e-4830-a750-4c75ee0c7749@zyc-PC.local>]
* Re: [dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of queues
[not found] <889ce4b6-5f2e-4830-a750-4c75ee0c7749@zyc-PC.local>
@ 2017-12-05 1:51 ` Zhang, Qi Z
0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Qi Z @ 2017-12-05 1:51 UTC (permalink / raw)
To: zhouyangchao, dev
> -----Original Message-----
> From: zhouyangchao [mailto:zhouyates@gmail.com]
> Sent: Monday, December 4, 2017 2:38 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH] net/fm10k: remove RSS restriction with num of queues
>
> FM10K HW does not have such restrictions.
>
> Enabling RSS with single queue is not used to distribute flow but to compute
> a RSS hash value.
> It can reduce cpu cycles of computing a hash value with five tuples.
> In addition, there is an explicit method to disable RSS instead of an obscure
> way.
>
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> ---
> drivers/net/fm10k/fm10k_ethdev.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/fm10k/fm10k_ethdev.c
> b/drivers/net/fm10k/fm10k_ethdev.c
> index 2d05a46..403f6c5 100644
> --- a/drivers/net/fm10k/fm10k_ethdev.c
> +++ b/drivers/net/fm10k/fm10k_ethdev.c
> @@ -533,9 +533,8 @@ fm10k_dev_rss_configure(struct rte_eth_dev *dev)
> 0x6A, 0x42, 0xB7, 0x3B, 0xBE, 0xAC, 0x01, 0xFA,
> };
>
> - if (dev->data->nb_rx_queues == 1 ||
> - dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS ||
> - dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) {
> + if (dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS ||
> + dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) {
> FM10K_WRITE_REG(hw, FM10K_MRQC(0), 0);
> return;
> }
> --
> 2.9.0.windows.1
>
>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Regards
Qi
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <d51a98a0-33f0-44e8-a0e0-a90008f856ad@zyc-PC.local>]
* Re: [dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of queues
[not found] <d51a98a0-33f0-44e8-a0e0-a90008f856ad@zyc-PC.local>
@ 2017-11-29 6:54 ` Zhang, Qi Z
0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Qi Z @ 2017-11-29 6:54 UTC (permalink / raw)
To: zhouyangchao, dev; +Cc: qi.z.zhang@intel.comqi.z.zhang@intel.com
Hi:
> -----Original Message-----
> From: zhouyangchao [mailto:zhouyates@gmail.com]
> Sent: Wednesday, November 29, 2017 2:12 PM
> To: dev@dpdk.org
> Cc: qi.z.zhang@intel.comqi.z.zhang@intel.com
> Subject: [PATCH] net/fm10k: remove RSS restriction with num of queues
>
> FM10K HW does not have such restrictions.
>
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> ---
> drivers/net/fm10k/fm10k_ethdev.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/fm10k/fm10k_ethdev.c
> b/drivers/net/fm10k/fm10k_ethdev.c
> index 2d05a46..403f6c5 100644
> --- a/drivers/net/fm10k/fm10k_ethdev.c
> +++ b/drivers/net/fm10k/fm10k_ethdev.c
> @@ -533,9 +533,8 @@ fm10k_dev_rss_configure(struct rte_eth_dev *dev)
> 0x6A, 0x42, 0xB7, 0x3B, 0xBE, 0xAC, 0x01, 0xFA,
> };
>
> - if (dev->data->nb_rx_queues == 1 ||
> - dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS ||
> - dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) {
Yes, you can enable RSS with single queue, but it is not necessary.
> + if (dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS ||
> + dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) {
> FM10K_WRITE_REG(hw, FM10K_MRQC(0), 0);
> return;
> }
> --
> 2.9.0.windows.1
>
>
Regards
Qi
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of queues
@ 2017-11-29 6:12 zhouyangchao
0 siblings, 0 replies; 5+ messages in thread
From: zhouyangchao @ 2017-11-29 6:12 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang
FM10K HW does not have such restrictions.
Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
---
drivers/net/fm10k/fm10k_ethdev.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 2d05a46..403f6c5 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -533,9 +533,8 @@ fm10k_dev_rss_configure(struct rte_eth_dev *dev)
0x6A, 0x42, 0xB7, 0x3B, 0xBE, 0xAC, 0x01, 0xFA,
};
- if (dev->data->nb_rx_queues == 1 ||
- dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS ||
- dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) {
+ if (dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS ||
+ dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) {
FM10K_WRITE_REG(hw, FM10K_MRQC(0), 0);
return;
}
--
2.9.0.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-20 6:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-04 6:38 [dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of queues zhouyangchao
2017-12-20 6:40 ` Zhang, Helin
[not found] <889ce4b6-5f2e-4830-a750-4c75ee0c7749@zyc-PC.local>
2017-12-05 1:51 ` Zhang, Qi Z
[not found] <d51a98a0-33f0-44e8-a0e0-a90008f856ad@zyc-PC.local>
2017-11-29 6:54 ` Zhang, Qi Z
-- strict thread matches above, loose matches on Subject: below --
2017-11-29 6:12 zhouyangchao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).