DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8
@ 2020-09-18  7:01 Thierry Herbelot
  2020-09-18  7:12 ` Somnath Kotur
  0 siblings, 1 reply; 5+ messages in thread
From: Thierry Herbelot @ 2020-09-18  7:01 UTC (permalink / raw)
  To: dev; +Cc: Thomas Monjalon, Ajit Khaparde, Somnath Kotur

  .../drivers/net/bnxt/tf_ulp/ulp_def_rules.c: In function ‘bnxt_ulp_destroy_df_rules’:
  .../dpdk/drivers/net/bnxt/tf_ulp/ulp_def_rules.c:425:28: error:
    comparison is always true due to limited range of data type [-Werror=type-limits]
  for (port_id = 0; port_id < RTE_MAX_ETHPORTS; port_id++) {
                            ^

Fixes: 769de16872ab9 ('net/bnxt: fix port default rule create/destroy')
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
index 9fb1a028ff66..ff5aed3d74c4 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
@@ -397,7 +397,7 @@ void
 bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global)
 {
 	struct bnxt_ulp_df_rule_info *info;
-	uint8_t port_id;
+	uint16_t port_id;
 
 	if (!BNXT_TRUFLOW_EN(bp) ||
 	    BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))
-- 
2.27.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8
  2020-09-18  7:01 [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8 Thierry Herbelot
@ 2020-09-18  7:12 ` Somnath Kotur
  2020-09-18  7:31   ` David Marchand
  0 siblings, 1 reply; 5+ messages in thread
From: Somnath Kotur @ 2020-09-18  7:12 UTC (permalink / raw)
  To: Thierry Herbelot; +Cc: dev, Thomas Monjalon, Ajit Khaparde

On Fri, Sep 18, 2020 at 12:32 PM Thierry Herbelot
<thierry.herbelot@6wind.com> wrote:
>
>   .../drivers/net/bnxt/tf_ulp/ulp_def_rules.c: In function ‘bnxt_ulp_destroy_df_rules’:
>   .../dpdk/drivers/net/bnxt/tf_ulp/ulp_def_rules.c:425:28: error:
>     comparison is always true due to limited range of data type [-Werror=type-limits]
>   for (port_id = 0; port_id < RTE_MAX_ETHPORTS; port_id++) {
>                             ^
>
> Fixes: 769de16872ab9 ('net/bnxt: fix port default rule create/destroy')
> Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Cc: Somnath Kotur <somnath.kotur@broadcom.com>
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
>  drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> index 9fb1a028ff66..ff5aed3d74c4 100644
> --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> @@ -397,7 +397,7 @@ void
>  bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global)
>  {
>         struct bnxt_ulp_df_rule_info *info;
> -       uint8_t port_id;
> +       uint16_t port_id;
>
>         if (!BNXT_TRUFLOW_EN(bp) ||
>             BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))
> --
> 2.27.0
>
Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8
  2020-09-18  7:12 ` Somnath Kotur
@ 2020-09-18  7:31   ` David Marchand
  2020-09-18 16:16     ` Ajit Khaparde
  0 siblings, 1 reply; 5+ messages in thread
From: David Marchand @ 2020-09-18  7:31 UTC (permalink / raw)
  To: Somnath Kotur, Thierry Herbelot, Ajit Khaparde, Xia, Chenbo
  Cc: dev, Thomas Monjalon

On Fri, Sep 18, 2020 at 9:12 AM Somnath Kotur
<somnath.kotur@broadcom.com> wrote:
>
> On Fri, Sep 18, 2020 at 12:32 PM Thierry Herbelot
> <thierry.herbelot@6wind.com> wrote:
> >
> >   .../drivers/net/bnxt/tf_ulp/ulp_def_rules.c: In function ‘bnxt_ulp_destroy_df_rules’:
> >   .../dpdk/drivers/net/bnxt/tf_ulp/ulp_def_rules.c:425:28: error:
> >     comparison is always true due to limited range of data type [-Werror=type-limits]
> >   for (port_id = 0; port_id < RTE_MAX_ETHPORTS; port_id++) {
> >                             ^
> >
> > Fixes: 769de16872ab9 ('net/bnxt: fix port default rule create/destroy')
> > Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > Cc: Somnath Kotur <somnath.kotur@broadcom.com>
> >
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > ---
> >  drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> > index 9fb1a028ff66..ff5aed3d74c4 100644
> > --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> > +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> > @@ -397,7 +397,7 @@ void
> >  bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global)
> >  {
> >         struct bnxt_ulp_df_rule_info *info;
> > -       uint8_t port_id;
> > +       uint16_t port_id;
> >
> >         if (!BNXT_TRUFLOW_EN(bp) ||
> >             BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))
> > --
> > 2.27.0
> >
> Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>
>

This patch rang a bell.
There is the exact same patch proposed by Xia with a comment, so I
guess Xia is still working on it?
https://patchwork.dpdk.org/patch/75177/#117201


-- 
David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8
  2020-09-18  7:31   ` David Marchand
@ 2020-09-18 16:16     ` Ajit Khaparde
  2020-09-20 15:26       ` Xia, Chenbo
  0 siblings, 1 reply; 5+ messages in thread
From: Ajit Khaparde @ 2020-09-18 16:16 UTC (permalink / raw)
  To: David Marchand
  Cc: Somnath Kotur, Thierry Herbelot, Xia, Chenbo, dev, Thomas Monjalon

::snip::
> >
>
> This patch rang a bell.
> There is the exact same patch proposed by Xia with a comment, so I
> guess Xia is still working on it?
> https://patchwork.dpdk.org/patch/75177/#117201
Xia,
Will you submit the changes that Thomas asked for?
Otherwise I will apply the bnxt patch and you can work on the rest.

Thanks
Ajit

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8
  2020-09-18 16:16     ` Ajit Khaparde
@ 2020-09-20 15:26       ` Xia, Chenbo
  0 siblings, 0 replies; 5+ messages in thread
From: Xia, Chenbo @ 2020-09-20 15:26 UTC (permalink / raw)
  To: Ajit Khaparde, David Marchand
  Cc: Somnath Kotur, Thierry Herbelot, dev, Thomas Monjalon

Hi, David & Ajit

Yes, I will submit a patch to change all eth port id to uint16_t
this week as I promised. Is this ok for you?

Thanks,
Chenbo

> -----Original Message-----
> From: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Sent: Saturday, September 19, 2020 12:16 AM
> To: David Marchand <david.marchand@redhat.com>
> Cc: Somnath Kotur <somnath.kotur@broadcom.com>; Thierry Herbelot
> <thierry.herbelot@6wind.com>; Xia, Chenbo <chenbo.xia@intel.com>; dev
> <dev@dpdk.org>; Thomas Monjalon <thomas@monjalon.net>
> Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat
> 8
> 
> ::snip::
> > >
> >
> > This patch rang a bell.
> > There is the exact same patch proposed by Xia with a comment, so I
> > guess Xia is still working on it?
> > https://patchwork.dpdk.org/patch/75177/#117201
> Xia,
> Will you submit the changes that Thomas asked for?
> Otherwise I will apply the bnxt patch and you can work on the rest.
> 
> Thanks
> Ajit

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18  7:01 [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8 Thierry Herbelot
2020-09-18  7:12 ` Somnath Kotur
2020-09-18  7:31   ` David Marchand
2020-09-18 16:16     ` Ajit Khaparde
2020-09-20 15:26       ` Xia, Chenbo

DPDK patches and discussions

Archives are clonable:
	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox