From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: Ankur Dwivedi <adwivedi@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
"anoobj@marvell.com" <anoobj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/3] test/event_crypto_adapter: fix function arguments
Date: Tue, 6 Oct 2020 10:21:45 +0000 [thread overview]
Message-ID: <MWHPR11MB1838A264A007918CE6825D48E80D0@MWHPR11MB1838.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200925072841.17578-3-adwivedi@marvell.com>
Hi Ankur,
Overall, it looks good.
You have missed out fixing caps args in one place line #299 of test_sessionless_with_op_forward_mode().
> -----Original Message-----
> From: Ankur Dwivedi <adwivedi@marvell.com>
> Sent: Friday, September 25, 2020 12:59 PM
> To: dev@dpdk.org
> Cc: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> jerinj@marvell.com; anoobj@marvell.com; Ankur Dwivedi
> <adwivedi@marvell.com>
> Subject: [PATCH v2 2/3] test/event_crypto_adapter: fix function arguments
>
> The arguments passed to rte_event_crypto_adapter_caps_get() and
> rte_event_crypto_adapter_create() are incorrect.
>
> In the rte_event_crypto_adapter_caps_get(), event device id should be the
> first argument and cryptodev id should be the second argument.
> In the rte_event_crypto_adapter_create(), the event device id should be
> the second argument.
>
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> ---
> app/test/test_event_crypto_adapter.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 3c64742b3..572ef9c27 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -209,8 +209,8 @@ test_op_forward_mode(uint8_t session_less)
> &cipher_xform,
> params.session_priv_mpool);
> TEST_ASSERT_SUCCESS(ret, "Failed to init session\n");
>
> - ret =
> rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID,
> - evdev, &cap);
> + ret = rte_event_crypto_adapter_caps_get(evdev,
> TEST_CDEV_ID,
> + &cap);
> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter
> capabilities\n");
>
> if (cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA) { @@ -321,7
> +321,7 @@ test_session_with_op_forward_mode(void)
> uint32_t cap;
> int ret;
>
> - ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID,
> evdev, &cap);
> + ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
>
> if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ -
> 410,8 +410,8 @@ test_op_new_mode(uint8_t session_less)
> params.session_mpool);
> TEST_ASSERT_NOT_NULL(sess, "Session creation failed\n");
>
> - ret =
> rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID,
> - evdev, &cap);
> + ret = rte_event_crypto_adapter_caps_get(evdev,
> TEST_CDEV_ID,
> + &cap);
> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter
> capabilities\n");
>
> if (cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA) { @@ -460,7
> +460,7 @@ test_sessionless_with_op_new_mode(void)
> uint32_t cap;
> int ret;
>
> - ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID,
> evdev, &cap);
> + ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
>
> if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ -
> 486,7 +486,7 @@ test_session_with_op_new_mode(void)
> uint32_t cap;
> int ret;
>
> - ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID,
> evdev, &cap);
> + ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
>
> if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ -
> 706,7 +706,7 @@ test_crypto_adapter_create(void)
>
> /* Create adapter with default port creation callback */
> ret = rte_event_crypto_adapter_create(TEST_ADAPTER_ID,
> - TEST_CDEV_ID,
> + evdev,
> &conf, 0);
> TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto
> adapter\n");
>
> @@ -719,7 +719,7 @@ test_crypto_adapter_qp_add_del(void)
> uint32_t cap;
> int ret;
>
> - ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID,
> evdev, &cap);
> + ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
>
> if (cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) {
> --
> 2.28.0
next prev parent reply other threads:[~2020-10-06 10:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 9:15 [dpdk-dev] [PATCH 0/3] Bug fixes in event crypto adapter test application Ankur Dwivedi
2020-09-08 9:15 ` [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode Ankur Dwivedi
2020-09-11 7:37 ` Gujjar, Abhinandan S
2020-09-18 7:10 ` Gujjar, Abhinandan S
2020-09-18 14:34 ` Ankur Dwivedi
2020-09-18 14:42 ` Gujjar, Abhinandan S
2020-09-18 15:03 ` Ankur Dwivedi
2020-09-23 5:31 ` Ankur Dwivedi
2020-09-23 7:17 ` Gujjar, Abhinandan S
2020-10-08 9:12 ` Jerin Jacob
2020-09-08 9:15 ` [dpdk-dev] [PATCH 2/3] test/event_crypto_adapter: fix function arguments Ankur Dwivedi
2020-09-08 9:15 ` [dpdk-dev] [PATCH 3/3] test/event_crypto_adapter: free resources during exit Ankur Dwivedi
2020-09-25 7:28 ` [dpdk-dev] [PATCH v2 0/3] Bug fixes in event crypto adapter test application Ankur Dwivedi
2020-09-25 7:28 ` [dpdk-dev] [PATCH v2 1/3] test/event_crypto_adapter: return error with unsupported mode Ankur Dwivedi
2020-09-25 7:28 ` [dpdk-dev] [PATCH v2 2/3] test/event_crypto_adapter: fix function arguments Ankur Dwivedi
2020-10-06 10:21 ` Gujjar, Abhinandan S [this message]
2020-10-06 12:57 ` Ankur Dwivedi
2020-09-25 7:28 ` [dpdk-dev] [PATCH v2 3/3] test/event_crypto_adapter: free resources during exit Ankur Dwivedi
2020-10-06 10:21 ` Gujjar, Abhinandan S
2020-10-06 10:29 ` Gujjar, Abhinandan S
2020-10-06 13:00 ` Ankur Dwivedi
2020-10-05 9:43 ` [dpdk-dev] [PATCH v2 0/3] Bug fixes in event crypto adapter test application Jerin Jacob
2020-10-05 9:48 ` Gujjar, Abhinandan S
2020-10-07 5:26 ` [dpdk-dev] [PATCH v3 0/3] Bug fixes in event crypto adapter test Ankur Dwivedi
2020-10-07 5:26 ` [dpdk-dev] [PATCH v3 1/3] test/event_crypto_adapter: return error with unsupported mode Ankur Dwivedi
2020-10-08 7:25 ` Gujjar, Abhinandan S
2020-10-07 5:26 ` [dpdk-dev] [PATCH v3 2/3] test/event_crypto_adapter: fix function arguments Ankur Dwivedi
2020-10-08 7:26 ` Gujjar, Abhinandan S
2020-10-07 5:26 ` [dpdk-dev] [PATCH v3 3/3] test/event_crypto_adapter: free resources during exit Ankur Dwivedi
2020-10-08 7:26 ` Gujjar, Abhinandan S
2020-10-08 12:52 ` [dpdk-dev] [PATCH v4 0/3] Bug fixes in event crypto adapter test Ankur Dwivedi
2020-10-08 12:52 ` [dpdk-dev] [PATCH v4 1/3] test/event_crypto_adapter: return error for unsupported mode Ankur Dwivedi
2020-10-08 12:52 ` [dpdk-dev] [PATCH v4 2/3] test/event_crypto_adapter: fix function arguments Ankur Dwivedi
2020-10-08 12:52 ` [dpdk-dev] [PATCH v4 3/3] test/event_crypto_adapter: free resources during exit Ankur Dwivedi
2020-10-08 15:00 ` [dpdk-dev] [PATCH v4 0/3] Bug fixes in event crypto adapter test Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB1838A264A007918CE6825D48E80D0@MWHPR11MB1838.namprd11.prod.outlook.com \
--to=abhinandan.gujjar@intel.com \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).