From: Akhil Goyal <akhil.goyal@nxp.com> To: Nicolas Chautru <nicolas.chautru@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com> Subject: Re: [dpdk-dev] [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function Date: Thu, 16 Apr 2020 19:30:08 +0000 Message-ID: <VI1PR04MB316813AC9BB47C1E29DF543DE6D80@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw) In-Reply-To: <1585526580-113508-11-git-send-email-nicolas.chautru@intel.com> > > diff --git a/drivers/baseband/fpga_5gnr_fec/Makefile > b/drivers/baseband/fpga_5gnr_fec/Makefile > index 3f5c511..b68a79f 100644 > --- a/drivers/baseband/fpga_5gnr_fec/Makefile > +++ b/drivers/baseband/fpga_5gnr_fec/Makefile > @@ -23,4 +23,7 @@ LIBABIVER := 1 > # library source files > SRCS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC) += > rte_fpga_5gnr_fec.c > > +# export include files > +SYMLINK-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC)-include += > fpga_5gnr_fec.h > + > include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h > b/drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h > new file mode 100644 > index 0000000..7eebc7d > --- /dev/null > +++ b/drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h > @@ -0,0 +1,74 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2020 Intel Corporation > + */ > + > +#ifndef _FPGA_5GNR_FEC_H_ > +#define _FPGA_5GNR_FEC_H_ > + > +#include <stdint.h> > +#include <stdbool.h> > + > +/** > + * @file fpga_5gnr_fec.h > + * > + * Interface for Intel(R) FGPA 5GNR FEC device configuration at the host level, > + * directly accessible by the application. > + * Configuration related to 5GNR functionality is done through > + * librte_bbdev library. > + * > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + */ The exposed PMD header files are normally prefixed as rte_pmd_ You should rename your other header file as fpga_5gnr_fec.h And this one as rte_pmd_fpga_5gnr_fec.h BTW what is the need of a pmd API to configure the fpga? Is it not possible to do that as one of rte_bbdev_ops ? I can see that the comments in rte_bbdev_ops are not in proper format. '<' should not be there if comment is before the element Could you please correct them in a separate patch? Please check other structures as well > + > +#ifdef __cplusplus > +extern "C" { > +#endif > + > +/**< Number of Virtual Functions FGPA 4G FEC supports */ > +#define FPGA_5GNR_FEC_NUM_VFS 8 > + > +/** > + * Structure to pass FPGA 4G FEC configuration. > + */ > +struct fpga_5gnr_fec_conf { > + /**< 1 if PF is used for dataplane, 0 for VFs */ > + bool pf_mode_en; > + /**< Number of UL queues per VF */ > + uint8_t vf_ul_queues_number[FPGA_5GNR_FEC_NUM_VFS]; > + /**< Number of DL queues per VF */ > + uint8_t vf_dl_queues_number[FPGA_5GNR_FEC_NUM_VFS]; > + /**< UL bandwidth. Needed for schedule algorithm */ > + uint8_t ul_bandwidth; > + /**< DL bandwidth. Needed for schedule algorithm */ > + uint8_t dl_bandwidth; > + /**< UL Load Balance */ > + uint8_t ul_load_balance; > + /**< DL Load Balance */ > + uint8_t dl_load_balance; > + /**< FLR timeout value */ > + uint16_t flr_time_out; If you are adding comment before the element, then no need to add '<'
next prev parent reply other threads:[~2020-04-16 19:30 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-30 0:02 [dpdk-dev] [PATCH v2 00/13] drivers/baseband: add PMD for FPGA 5GNR FEC Nicolas Chautru 2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 01/13] bbdev: add capability flag for filler bits inclusion in HARQ Nicolas Chautru 2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 02/13] bbdev: expose device HARQ buffer size at device level Nicolas Chautru 2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 03/13] drivers/baseband: add PMD for FPGA 5GNR FEC Nicolas Chautru 2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 04/13] baseband/fpga_5gnr_fec: add register definition file Nicolas Chautru 2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 05/13] baseband/fpga_5gnr_fec: add device info_get function Nicolas Chautru 2020-04-16 18:15 ` Akhil Goyal 2020-04-16 21:20 ` Chautru, Nicolas 2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 06/13] baseband/fpga_5gnr_fec: add queue configuration Nicolas Chautru 2020-04-11 3:13 ` Xu, Rosen 2020-04-14 0:16 ` Chautru, Nicolas 2020-04-15 6:13 ` Xu, Rosen 2020-04-15 15:51 ` Chautru, Nicolas 2020-04-16 1:09 ` Xu, Rosen 2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 07/13] baseband/fpga_5gnr_fec: add LDPC processing functions Nicolas Chautru 2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 08/13] baseband/fpga_5gnr_fec: add HW error capture Nicolas Chautru 2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 09/13] baseband/fpga_5gnr_fec: add debug functionality Nicolas Chautru 2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function Nicolas Chautru 2020-04-15 15:40 ` Power, Niall 2020-04-16 19:30 ` Akhil Goyal [this message] 2020-04-16 21:45 ` Chautru, Nicolas 2020-05-01 23:15 ` Chautru, Nicolas 2020-05-04 17:19 ` Thomas Monjalon 2020-06-25 0:30 ` Chautru, Nicolas 2020-06-25 8:13 ` Thomas Monjalon 2020-06-26 1:14 ` Chautru, Nicolas 2020-06-26 10:08 ` Thomas Monjalon 2020-07-10 22:48 ` Chautru, Nicolas 2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 11/13] baseband/fpga_5gnr_fec: add harq loopback capability Nicolas Chautru 2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 12/13] baseband/fpga_5gnr_fec: add interrupt support Nicolas Chautru 2020-04-16 18:43 ` Akhil Goyal 2020-03-30 0:03 ` [dpdk-dev] [PATCH v2 13/13] doc: add feature matrix table for bbdev devices Nicolas Chautru 2020-04-15 15:40 ` [dpdk-dev] [PATCH v2 00/13] drivers/baseband: add PMD for FPGA 5GNR FEC Power, Niall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VI1PR04MB316813AC9BB47C1E29DF543DE6D80@VI1PR04MB3168.eurprd04.prod.outlook.com \ --to=akhil.goyal@nxp.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=nicolas.chautru@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git