Re: [dpdk-dev] [PATCH v2 12/13] baseband/fpga_5gnr_fec: add interrupt support

[Akhil Goyal <akhil.goyal@nxp.com>]

> 
> Adding support for interrupt capability in the PMD
> and the related operations.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>  drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 156
> +++++++++++++++++++++
>  1 file changed, 156 insertions(+)
> 
> diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> index b8cad1a..45a3126 100644
> --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> @@ -110,6 +110,23 @@
>  	return rte_le_to_cpu_32(ret);
>  }
> 
> +/* Read a register of FPGA 5GNR FEC device */
> +static uint8_t
> +fpga_reg_read_8(void *mmio_base, uint32_t offset)
> +{
> +	void *reg_addr = RTE_PTR_ADD(mmio_base, offset);
> +	return *((volatile uint8_t *)(reg_addr));
> +}
> +
> +/* Read a register of FPGA 5GNR FEC device */
> +static uint64_t
> +fpga_reg_read_64(void *mmio_base, uint32_t offset)
> +{
> +	void *reg_addr = RTE_PTR_ADD(mmio_base, offset);
> +	uint64_t ret = *((volatile uint64_t *)(reg_addr));
> +	return rte_le_to_cpu_64(ret);
> +}
> +

Above reg_read APIs should be moved in the header file and made as inline along with all others in your 6/13 patch.