From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Maryam Tahhan <mtahhan@redhat.com>,
stephen@networkplumber.org, lihuisong@huawei.com,
fengchengwen@huawei.com, liuyonglong@huawei.com,
david.marchand@redhat.com
Cc: dev@dpdk.org, Ciara Loftus <ciara.loftus@intel.com>,
Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>,
Kevin Traynor <ktraynor@redhat.com>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s
Date: Thu, 11 Jan 2024 11:35:11 +0000 [thread overview]
Message-ID: <f13d8a0e-ea38-4eaa-9b42-f8c8549ea5cc@amd.com> (raw)
In-Reply-To: <a9e88269-0642-4945-a5dd-e65076a7f82c@redhat.com>
On 1/11/2024 9:01 AM, Maryam Tahhan wrote:
> On 10/01/2024 15:21, Ferruh Yigit wrote:
>> On 1/10/2024 2:58 PM, Maryam Tahhan wrote:
>>> Hi folks
>>>
>>> Just wondering if there's any other comments re this patch after all the
>>> review comments were addressed?
>>>
>> Hi Maryam,
>>
>> There was a request from David, to the previous version, that fixes
>> (either to code or document) should be separated into its own patch, so
>> that they can be merged to our LTS (say 21.11.x) releases, to make sure
>> LTS release has correct info/code. On top of it your changes can be
>> another patch.
>>
>> As document completely changed, it is not easy for me to say, can you
>> please confirm that there is no fix to the documentation unrelated with
>> your code change?
>>
> Hey Ferruh
>
> Yes - I should've clarified. I took David's comments into consideration.
> The old use_cni implementation is broken (so if a DPDK pod wants
> multiple AF_XDP interfaces it will not work). So IMHO it doesn't make
> sense to patch documentation for something that is broken. The whole
> change would need to be back ported to LTS.
>
Devarg is user interface, changing it impacts the user.
Assume that user of '22.11.3' using 'use_cni' dev_arg, it will be broken
when user upgrades DPDK to '22.11.4', which is not expected.
dev_arg is not API/ABI but as it impacts the user, it is in the gray
area to backport to the LTS release.
Current patch doesn't have Fixes tag or stable tag, so it doesn't
request to be backported to LTS release. I took this as an improvement,
more than a fix.
As far as I understand existing code (that use 'use_cni' dev_arg)
supports only single netdev, this patch adds support for multiple netdevs.
So what do you think keep LTS with 'use_cni' dev_arg, is there a
requirement to update LTS release?
If so, can it be an option to keep 'use_cni' for backward compatibility
but add only add 'uds_path' and remove 'use_cni' in next LTS?
>
> However, I have a second change to apply on top of this - so I will send
> a series. So please hold off merging for now.
>
> BR
> Maryam
>
next prev parent reply other threads:[~2024-01-11 11:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 11:04 Maryam Tahhan
2024-01-10 14:58 ` Maryam Tahhan
2024-01-10 15:21 ` Ferruh Yigit
2024-01-11 9:01 ` Maryam Tahhan
2024-01-11 11:35 ` Ferruh Yigit [this message]
2024-01-11 12:21 ` Maryam Tahhan
2024-01-11 13:28 ` Kevin Traynor
2024-01-11 14:21 ` Ferruh Yigit
2024-02-07 23:24 ` Ferruh Yigit
2024-02-09 12:40 ` Loftus, Ciara
2024-02-09 16:52 ` Maryam Tahhan
2024-02-09 18:07 ` Ferruh Yigit
2024-02-09 17:02 ` Maryam Tahhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f13d8a0e-ea38-4eaa-9b42-f8c8549ea5cc@amd.com \
--to=ferruh.yigit@amd.com \
--cc=bluca@debian.org \
--cc=ciara.loftus@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ktraynor@redhat.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=mtahhan@redhat.com \
--cc=shibin.koikkara.reeny@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).