From: Maryam Tahhan <mtahhan@redhat.com>
To: "Loftus, Ciara" <ciara.loftus@intel.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"lihuisong@huawei.com" <lihuisong@huawei.com>,
"fengchengwen@huawei.com" <fengchengwen@huawei.com>,
"liuyonglong@huawei.com" <liuyonglong@huawei.com>,
"Marchand, David" <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Koikkara Reeny, Shibin" <shibin.koikkara.reeny@intel.com>,
Kevin Traynor <ktraynor@redhat.com>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s
Date: Fri, 9 Feb 2024 16:52:15 +0000 [thread overview]
Message-ID: <fb3f7cac-6d05-4671-ac54-407f612a0de8@redhat.com> (raw)
In-Reply-To: <MW4PR11MB5872C7A2F35BE5E37F9CCB458E4B2@MW4PR11MB5872.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2790 bytes --]
On 09/02/2024 12:40, Loftus, Ciara wrote:
>> Hi Maryam,
>>
>> How do you want to continue with the patch, I think options we considered:
>>
>> 1. Fix 'use_cni' documentation (which we can backport to LTS) and
>> overload the argument for new purpose. This will enable new feature by
>> keeping backward compatibility. And requires new version of this patch.
>>
>> 2. If the 'use_cni' is completely broken in the 23.11 LTS, which means
>> there is no user or backward compatibility to worry about, we can merge
>> this patch and backport it to LTS.
>>
>> 3. Don't backport this fix to LTS, merge only to current release, which
>> means your new feature won't be available to some users as long as a few
>> years.
>>
>>
>> (1.) is most user friendly, but if 'use_cni' already broken in LTS we
>> can go with option (2.). What do you think?
>>
>>
>>
>> btw, @Ciara, @Maryam, if (2.) is true, how we end up having a feature
>> ('use_cni' dev_args) completely broken in an LTS release?
> My understanding is that the use_cni implementation that is available in the 23.11 LTS is compatible with a particular version of the afxdp-plugins-for-kubernetes source. Maryam's change makes it compatible with the latest version. @Maryam can you confirm this?
> If my understanding is correct then I think we should include the version/tag/commit-id of afxdp-plugins-for-kubernetes that the code is compatible with. Including backporting a patch to LTS to specify what version that code is comaptible with.
Yeah that's correct, the existing use_cni implementation would work with
a particular version of the AF_XDP Device Plugin (with the limitation
that the DPDK pod cannot request multiple interfaces from different
device pools). From a deployment POV - I would consider this a broken
behaviour. Non the less we can document it more explicitly.
The use_cni changes I'm making now will enable multi interface support
(for a DPDK pod, keeping backward compatibility in mind). It will also
still work with the older version of the AF_XDP device plugin (with the
1 interface limitation for the DPDK pod). I will document all of these
in the next revision.
In addition to the changes mentioned above, I'm also extending the
AF_XDP PMD to support retrieving the xskmap FD from a pinned BPF map (A
new feature in the AF_XDP Device Plugin).
All the above will be pushed in another revision of the patchset shortly
(in addition to documentation changes). I'm just running tests and
breaking down the patches into (hopefully) logical chunks.
And lastly there's one other issue that I'm trying to also
investigate/resolve - which is the AF_XDP Device Plugin integration
under AF_XDP PMD doesn't support busy polling. That's probably another
feature to add. >>> this might be a separate patch
[-- Attachment #2: Type: text/html, Size: 3426 bytes --]
next prev parent reply other threads:[~2024-02-09 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 11:04 Maryam Tahhan
2024-01-10 14:58 ` Maryam Tahhan
2024-01-10 15:21 ` Ferruh Yigit
2024-01-11 9:01 ` Maryam Tahhan
2024-01-11 11:35 ` Ferruh Yigit
2024-01-11 12:21 ` Maryam Tahhan
2024-01-11 13:28 ` Kevin Traynor
2024-01-11 14:21 ` Ferruh Yigit
2024-02-07 23:24 ` Ferruh Yigit
2024-02-09 12:40 ` Loftus, Ciara
2024-02-09 16:52 ` Maryam Tahhan [this message]
2024-02-09 18:07 ` Ferruh Yigit
2024-02-09 17:02 ` Maryam Tahhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb3f7cac-6d05-4671-ac54-407f612a0de8@redhat.com \
--to=mtahhan@redhat.com \
--cc=bluca@debian.org \
--cc=ciara.loftus@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=ktraynor@redhat.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=shibin.koikkara.reeny@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).