patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/iavf: fix queue pairs configuration
@ 2020-12-23  5:29 Zhang,Alvin
  2020-12-23  6:06 ` Xu, Ting
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Zhang,Alvin @ 2020-12-23  5:29 UTC (permalink / raw)
  To: beilei.xing, ting.xu; +Cc: dev, Alvin Zhang, stable

From: Alvin Zhang <alvinx.zhang@intel.com>

Check if there are enough queue pairs currently allocated, and if not,
request PF to allocate them.

Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more queues")
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
 drivers/net/iavf/iavf_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 7e3c26a..f015121 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -372,8 +372,10 @@ struct rte_iavf_xstats_name_off {
 	} else {
 		/* Check if large VF is already enabled. If so, disable and
 		 * release redundant queue resource.
+		 * Or check if enough queue pairs. If not, request them from PF.
 		 */
-		if (vf->lv_enabled) {
+		if (vf->lv_enabled ||
+		    num_queue_pairs > vf->vsi_res->num_queue_pairs) {
 			ret = iavf_queues_req_reset(dev, num_queue_pairs);
 			if (ret)
 				return ret;
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [PATCH] net/iavf: fix queue pairs configuration
  2020-12-23  5:29 [dpdk-stable] [PATCH] net/iavf: fix queue pairs configuration Zhang,Alvin
@ 2020-12-23  6:06 ` Xu, Ting
  2020-12-23  6:28   ` Zhang, AlvinX
  2020-12-24  9:33 ` [dpdk-stable] [dpdk-dev] " Huang, ZhiminX
  2020-12-28 10:56 ` Zhang, Qi Z
  2 siblings, 1 reply; 5+ messages in thread
From: Xu, Ting @ 2020-12-23  6:06 UTC (permalink / raw)
  To: Zhang, AlvinX, Xing, Beilei; +Cc: dev, Zhang, AlvinX, stable

Hi, Alvin,

> -----Original Message-----
> From: Zhang,Alvin <alvinx.zhang@intel.com>
> Sent: Wednesday, December 23, 2020 1:30 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Xu, Ting <ting.xu@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/iavf: fix queue pairs configuration
> 
> From: Alvin Zhang <alvinx.zhang@intel.com>
> 
> Check if there are enough queue pairs currently allocated, and if not, request
> PF to allocate them.
> 
> Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more queues")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
>  drivers/net/iavf/iavf_ethdev.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index 7e3c26a..f015121 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -372,8 +372,10 @@ struct rte_iavf_xstats_name_off {
>  	} else {
>  		/* Check if large VF is already enabled. If so, disable and
>  		 * release redundant queue resource.
> +		 * Or check if enough queue pairs. If not, request them from
> PF.
>  		 */
> -		if (vf->lv_enabled) {
> +		if (vf->lv_enabled ||
> +		    num_queue_pairs > vf->vsi_res->num_queue_pairs) {
>  			ret = iavf_queues_req_reset(dev, num_queue_pairs);
>  			if (ret)
>  				return ret;
> --
> 1.8.3.1

Will it be better to change ret = iavf_queues_req_reset(dev, num_queue_pairs); to ret = iavf_queues_req_reset(dev, IAVF_MAX_NUM_QUEUES_DFLT); based on the original codes?
Since PF provides default 16 queue pairs to VF. If large VF is no need to be enabled, it may be better to reset the queue pairs number to 16. So that we don't need to compare the queue pairs number and request queues each time when it is no more than 16. If more, it turns to large VF to handle.
The original codes here are not good.
Thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [PATCH] net/iavf: fix queue pairs configuration
  2020-12-23  6:06 ` Xu, Ting
@ 2020-12-23  6:28   ` Zhang, AlvinX
  0 siblings, 0 replies; 5+ messages in thread
From: Zhang, AlvinX @ 2020-12-23  6:28 UTC (permalink / raw)
  To: Xu, Ting, Xing, Beilei; +Cc: dev, stable

Hi Xuting,

Thanks for your reply.
It's very efficient for CVL. But the FVL PF provides default 4 queue pairs to VF,
if every VF request 16 queue pairs, there may be not enough queues pairs for all VFs.

BR,
Alvin

> -----Original Message-----
> From: Xu, Ting <ting.xu@intel.com>
> Sent: Wednesday, December 23, 2020 2:06 PM
> To: Zhang, AlvinX <alvinx.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH] net/iavf: fix queue pairs configuration
> 
> Hi, Alvin,
> 
> > -----Original Message-----
> > From: Zhang,Alvin <alvinx.zhang@intel.com>
> > Sent: Wednesday, December 23, 2020 1:30 PM
> > To: Xing, Beilei <beilei.xing@intel.com>; Xu, Ting <ting.xu@intel.com>
> > Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH] net/iavf: fix queue pairs configuration
> >
> > From: Alvin Zhang <alvinx.zhang@intel.com>
> >
> > Check if there are enough queue pairs currently allocated, and if not,
> > request PF to allocate them.
> >
> > Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more
> > queues")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> > ---
> >  drivers/net/iavf/iavf_ethdev.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/iavf/iavf_ethdev.c
> > b/drivers/net/iavf/iavf_ethdev.c index 7e3c26a..f015121 100644
> > --- a/drivers/net/iavf/iavf_ethdev.c
> > +++ b/drivers/net/iavf/iavf_ethdev.c
> > @@ -372,8 +372,10 @@ struct rte_iavf_xstats_name_off {
> >  	} else {
> >  		/* Check if large VF is already enabled. If so, disable and
> >  		 * release redundant queue resource.
> > +		 * Or check if enough queue pairs. If not, request them from
> > PF.
> >  		 */
> > -		if (vf->lv_enabled) {
> > +		if (vf->lv_enabled ||
> > +		    num_queue_pairs > vf->vsi_res->num_queue_pairs) {
> >  			ret = iavf_queues_req_reset(dev, num_queue_pairs);
> >  			if (ret)
> >  				return ret;
> > --
> > 1.8.3.1
> 
> Will it be better to change ret = iavf_queues_req_reset(dev, num_queue_pairs);
> to ret = iavf_queues_req_reset(dev, IAVF_MAX_NUM_QUEUES_DFLT); based on
> the original codes?
> Since PF provides default 16 queue pairs to VF. If large VF is no need to be
> enabled, it may be better to reset the queue pairs number to 16. So that we
> don't need to compare the queue pairs number and request queues each time
> when it is no more than 16. If more, it turns to large VF to handle.
> The original codes here are not good.
> Thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/iavf: fix queue pairs configuration
  2020-12-23  5:29 [dpdk-stable] [PATCH] net/iavf: fix queue pairs configuration Zhang,Alvin
  2020-12-23  6:06 ` Xu, Ting
@ 2020-12-24  9:33 ` Huang, ZhiminX
  2020-12-28 10:56 ` Zhang, Qi Z
  2 siblings, 0 replies; 5+ messages in thread
From: Huang, ZhiminX @ 2020-12-24  9:33 UTC (permalink / raw)
  To: Zhang, AlvinX, Xing, Beilei, Xu, Ting; +Cc: dev, Zhang, AlvinX, stable

Tested-by: Huang, ZhiminX <zhiminx.huang@intel.com>

Regards,
HuangZhiMin


> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Zhang,Alvin
> Sent: Wednesday, December 23, 2020 1:30 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Xu, Ting <ting.xu@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/iavf: fix queue pairs configuration
> 
> From: Alvin Zhang <alvinx.zhang@intel.com>
> 
> Check if there are enough queue pairs currently allocated, and if not, request
> PF to allocate them.
> 
> Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more queues")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
>  drivers/net/iavf/iavf_ethdev.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index
> 7e3c26a..f015121 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -372,8 +372,10 @@ struct rte_iavf_xstats_name_off {
>  	} else {
>  		/* Check if large VF is already enabled. If so, disable and
>  		 * release redundant queue resource.
> +		 * Or check if enough queue pairs. If not, request them from PF.
>  		 */
> -		if (vf->lv_enabled) {
> +		if (vf->lv_enabled ||
> +		    num_queue_pairs > vf->vsi_res->num_queue_pairs) {
>  			ret = iavf_queues_req_reset(dev, num_queue_pairs);
>  			if (ret)
>  				return ret;
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/iavf: fix queue pairs configuration
  2020-12-23  5:29 [dpdk-stable] [PATCH] net/iavf: fix queue pairs configuration Zhang,Alvin
  2020-12-23  6:06 ` Xu, Ting
  2020-12-24  9:33 ` [dpdk-stable] [dpdk-dev] " Huang, ZhiminX
@ 2020-12-28 10:56 ` Zhang, Qi Z
  2 siblings, 0 replies; 5+ messages in thread
From: Zhang, Qi Z @ 2020-12-28 10:56 UTC (permalink / raw)
  To: Zhang, AlvinX, Xing, Beilei, Xu, Ting; +Cc: dev, Zhang, AlvinX, stable



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Zhang,Alvin
> Sent: Wednesday, December 23, 2020 1:30 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Xu, Ting <ting.xu@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/iavf: fix queue pairs configuration
> 
> From: Alvin Zhang <alvinx.zhang@intel.com>
> 
> Check if there are enough queue pairs currently allocated, and if not, request PF
> to allocate them.
> 
> Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more queues")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-12-28 10:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23  5:29 [dpdk-stable] [PATCH] net/iavf: fix queue pairs configuration Zhang,Alvin
2020-12-23  6:06 ` Xu, Ting
2020-12-23  6:28   ` Zhang, AlvinX
2020-12-24  9:33 ` [dpdk-stable] [dpdk-dev] " Huang, ZhiminX
2020-12-28 10:56 ` Zhang, Qi Z

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git