Re: [dpdk-stable] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics

[Andrew Rybchenko <arybchenko@solarflare.com>]

On 22.03.2019 16:37, David Marchand wrote:
> Having the standard stats and the rx burst stats on the same line gives a
> really long line and is not consistent with the rest.
>
> Before:
>    RX-packets: 3542977        TX-packets: 3542971        TX-dropped: 6               RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
>    TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
>
> After:
>    RX-packets: 4629969        TX-packets: 4629969        TX-dropped: 0
>    RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
>    TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> Changelog since v2:
> - Cc'd stable
>
> ---
>   app/test-pmd/testpmd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 216be47..40199c1 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1459,7 +1459,7 @@ struct extmem_param {
>   	       "TX Port=%2d/Queue=%2d %s\n",
>   	       fwd_top_stats_border, fs->rx_port, fs->rx_queue,
>   	       fs->tx_port, fs->tx_queue, fwd_top_stats_border);
> -	printf("  RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u",
> +	printf("  RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u\n",
>   	       fs->rx_packets, fs->tx_packets, fs->fwd_dropped);
>   
>   	/* if checksum mode */


In fact bad Rx checksum counters follow and I think they should be in 
this line.

That's why there is no \n here from the very beginning.

My fix for the bug (local) just add \n in else branch below.


Andrew.