Re: [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new VLAN design for Intel ice PMD

["Wang, Haiyue" <haiyue.wang@intel.com>]

> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Wednesday, June 16, 2021 23:47
> To: Wang, Haiyue <haiyue.wang@intel.com>; stable@dpdk.org
> Cc: xuemingl@nvidia.com; thomas@monjalon.net; christian.ehrhardt@canonical.com; ktraynor@redhat.com;
> Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: Re: [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new VLAN design for Intel ice PMD
> 
> On Fri, 2021-06-11 at 15:15 +0800, Haiyue Wang wrote:
> > When LTS 20.11 was released, the Intel ice PMD has a basic VLAN offload,
> > which can only handle single VLAN mode for firmware limitation. Now the
> > firmware is updated to support double VLAN mode and single VLAN mode at
> > the same time. It depends on the driver to do selection at the boot time.
> >
> > As VLAN protocol handling like strip, filter, flow is very common use, we
> > request to support the ice PMD can run on the latest firmware for enabling
> > the new design. This is compatible backport as the main tree.
> >
> > v2: Fix the subject fix with messy code like : PATCHÂ
> >
> > Haiyue Wang (4):
> >   net/ice/base: do not set VLAN mode in DCF mode
> >   net/ice: fix VLAN strip for double VLAN
> >   net/ice: fix VLAN 0 adding based on VLAN mode
> >   net/ice: update QinQ switch filter handling
> >
> > Junfeng Guo (1):
> >   net/ice: enable QinQ filter for switch
> >
> > Qi Zhang (12):
> >   net/ice/base: align add VSI and update VSI AQ command buffer
> >   net/ice/base: add interface to support configuring VLAN mode
> >   net/ice/base: fix outer VLAN related macro
> >   net/ice/base: add VLAN TPID for VLAN filters
> >   net/ice/base: support checking double VLAN mode
> >   net/ice/base: support configuring device in double VLAN mode
> >   net/ice/base: update boost TCAM for DVM
> >   net/ice/base: change protocol ID for VLAN in DVM
> >   net/ice/base: refactor post DDP download VLAN mode config
> >   net/ice/base: log if DDP/FW do not support QinQ
> >   net/ice/base: add inner VLAN protocol type for QinQ filter
> >   net/ice/base: fix QinQ PPPoE dummy packet selection
> >
> > Yuying Zhang (1):
> >   net/ice/base: add ethertype offset for QinQ dummy packet
> >
> >  drivers/net/ice/base/ice_adminq_cmd.h    | 268 ++++++++-----
> >  drivers/net/ice/base/ice_bitops.h        |  45 +++
> >  drivers/net/ice/base/ice_common.c        |  38 ++
> >  drivers/net/ice/base/ice_common.h        |   4 +
> >  drivers/net/ice/base/ice_flex_pipe.c     | 302 +++++++++++++--
> >  drivers/net/ice/base/ice_flex_pipe.h     |  12 +
> >  drivers/net/ice/base/ice_flex_type.h     |  39 ++
> >  drivers/net/ice/base/ice_protocol_type.h |   1 +
> >  drivers/net/ice/base/ice_switch.c        | 124 +++++-
> >  drivers/net/ice/base/ice_switch.h        |  15 +
> >  drivers/net/ice/base/ice_type.h          |   4 +
> >  drivers/net/ice/base/ice_vlan_mode.c     | 451 ++++++++++++++++++++++
> >  drivers/net/ice/base/ice_vlan_mode.h     |  16 +
> >  drivers/net/ice/base/meson.build         |   1 +
> >  drivers/net/ice/ice_ethdev.c             | 455 +++++++++++++----------
> >  drivers/net/ice/ice_ethdev.h             |  10 +-
> >  drivers/net/ice/ice_generic_flow.c       |   8 +
> >  drivers/net/ice/ice_generic_flow.h       |   1 +
> >  drivers/net/ice/ice_switch_filter.c      | 114 +++++-
> >  19 files changed, 1545 insertions(+), 363 deletions(-)
> >  create mode 100644 drivers/net/ice/base/ice_vlan_mode.c
> >  create mode 100644 drivers/net/ice/base/ice_vlan_mode.h
> 
> Hi,
> 
> At 1.9k diffstat, this series is quite large. Given it's a new feature,
> rather than a series of bug fixes, this would seem a bit risky to me.
> Final word of course belongs to Xueming, since he's managing this one.
> See:
> 

01. Does the feature break API/ABI?

 NO.

02. Does the feature break backwards compatibility?

 NO.

03. Is it for the latest LTS release (to avoid LTS upgrade issues)?

Yes.

04. Is there a commitment from the proposer or affiliation to validate the feature and check for regressions in related functionality?

Passed internally, if needed, an official Test-by can be provided. 

05. Is there a track record of the proposer or affiliation validating stable releases?

Bugzilla ?

06. Is it obvious that the feature will not impact existing functionality?

Yes.

07. How intrusive is the code change?

 From LOC, yes, 1.9K seems to be BIG, but DPDK PMD related is 588, other is
 the share code in base (1320), which is tested and validated on other platform.
 
     drivers/net/ice/ice_ethdev.c             | 455 +++++++++++++----------
     drivers/net/ice/ice_ethdev.h             |  10 +-
     drivers/net/ice/ice_generic_flow.c       |   8 +
     drivers/net/ice/ice_generic_flow.h       |   1 +
     drivers/net/ice/ice_switch_filter.c      | 114 +++++-

08. What is the scope of the code change?

PMD only.

09. Does it impact common components or vendor specific?

NO.

10. Is there a justifiable use case (a clear user need)?

Yes, for firmware updated. And we have the customer who wants to use the
VLAN feature on LTS 20.11.

11. Is there a community consensus about the backport?

...

> https://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported
> 
> --
> Kind regards,
> Luca Boccassi