patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/iavf: fix TSO max segment size
@ 2021-03-01  7:57 Qi Zhang
  2021-03-26  1:27 ` Xing, Beilei
  0 siblings, 1 reply; 3+ messages in thread
From: Qi Zhang @ 2021-03-01  7:57 UTC (permalink / raw)
  To: jingjing.wu
  Cc: arjun.anantharam, timothy.miskell, beilei.xing, dev, Qi Zhang, stable

According to Intel® AVF spec
(https://www.intel.com/content/dam/
www/public/us/en/documents/product-specifications/
ethernet-adaptive-virtual-function-hardware-spec.pdf)
section 2.2.2.3:
The max segment size(MSS) of TSO should not be set lower than 88.

Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")
Cc: stable@dpdk.org

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/iavf/iavf_rxtx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h
index 922ddadad1..69979971fd 100644
--- a/drivers/net/iavf/iavf_rxtx.h
+++ b/drivers/net/iavf/iavf_rxtx.h
@@ -34,7 +34,7 @@
 #define DEFAULT_TX_RS_THRESH     32
 #define DEFAULT_TX_FREE_THRESH   32
 
-#define IAVF_MIN_TSO_MSS          256
+#define IAVF_MIN_TSO_MSS          88
 #define IAVF_MAX_TSO_MSS          9668
 #define IAVF_TSO_MAX_SEG          UINT8_MAX
 #define IAVF_TX_MAX_MTU_SEG       8
-- 
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/iavf: fix TSO max segment size
  2021-03-01  7:57 [dpdk-stable] [PATCH] net/iavf: fix TSO max segment size Qi Zhang
@ 2021-03-26  1:27 ` Xing, Beilei
  2021-03-26  6:49   ` Zhang, Qi Z
  0 siblings, 1 reply; 3+ messages in thread
From: Xing, Beilei @ 2021-03-26  1:27 UTC (permalink / raw)
  To: Zhang, Qi Z, Wu, Jingjing
  Cc: Anantharam, Arjun, Miskell, Timothy, dev, stable



> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Monday, March 1, 2021 3:57 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Anantharam, Arjun <arjun.anantharam@intel.com>; Miskell, Timothy
> <timothy.miskell@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/iavf: fix TSO max segment size
> 
> According to Intel® AVF spec
> (https://www.intel.com/content/dam/
> www/public/us/en/documents/product-specifications/
> ethernet-adaptive-virtual-function-hardware-spec.pdf)
> section 2.2.2.3:
> The max segment size(MSS) of TSO should not be set lower than 88.
> 
> Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  drivers/net/iavf/iavf_rxtx.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index
> 922ddadad1..69979971fd 100644
> --- a/drivers/net/iavf/iavf_rxtx.h
> +++ b/drivers/net/iavf/iavf_rxtx.h
> @@ -34,7 +34,7 @@
>  #define DEFAULT_TX_RS_THRESH     32
>  #define DEFAULT_TX_FREE_THRESH   32
> 
> -#define IAVF_MIN_TSO_MSS          256
> +#define IAVF_MIN_TSO_MSS          88
>  #define IAVF_MAX_TSO_MSS          9668
>  #define IAVF_TSO_MAX_SEG          UINT8_MAX
>  #define IAVF_TX_MAX_MTU_SEG       8
> --
> 2.26.2

Acked-by: Beilei Xing <beilei.xing@intel.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/iavf: fix TSO max segment size
  2021-03-26  1:27 ` Xing, Beilei
@ 2021-03-26  6:49   ` Zhang, Qi Z
  0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2021-03-26  6:49 UTC (permalink / raw)
  To: Xing, Beilei, Wu, Jingjing
  Cc: Anantharam, Arjun, Miskell, Timothy, dev, stable



> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Friday, March 26, 2021 9:28 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Anantharam, Arjun <arjun.anantharam@intel.com>; Miskell, Timothy
> <timothy.miskell@intel.com>; dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH] net/iavf: fix TSO max segment size
> 
> 
> 
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: Monday, March 1, 2021 3:57 PM
> > To: Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: Anantharam, Arjun <arjun.anantharam@intel.com>; Miskell, Timothy
> > <timothy.miskell@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> > dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/iavf: fix TSO max segment size
> >
> > According to Intel® AVF spec
> > (https://www.intel.com/content/dam/
> > www/public/us/en/documents/product-specifications/
> > ethernet-adaptive-virtual-function-hardware-spec.pdf)
> > section 2.2.2.3:
> > The max segment size(MSS) of TSO should not be set lower than 88.
> >
> > Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> >  drivers/net/iavf/iavf_rxtx.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/iavf/iavf_rxtx.h
> > b/drivers/net/iavf/iavf_rxtx.h index 922ddadad1..69979971fd 100644
> > --- a/drivers/net/iavf/iavf_rxtx.h
> > +++ b/drivers/net/iavf/iavf_rxtx.h
> > @@ -34,7 +34,7 @@
> >  #define DEFAULT_TX_RS_THRESH     32
> >  #define DEFAULT_TX_FREE_THRESH   32
> >
> > -#define IAVF_MIN_TSO_MSS          256
> > +#define IAVF_MIN_TSO_MSS          88
> >  #define IAVF_MAX_TSO_MSS          9668
> >  #define IAVF_TSO_MAX_SEG          UINT8_MAX
> >  #define IAVF_TX_MAX_MTU_SEG       8
> > --
> > 2.26.2
> 
> Acked-by: Beilei Xing <beilei.xing@intel.com>
> 

Applied to dpdk-next-net-intel.

Thanks
Qi


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-26  6:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01  7:57 [dpdk-stable] [PATCH] net/iavf: fix TSO max segment size Qi Zhang
2021-03-26  1:27 ` Xing, Beilei
2021-03-26  6:49   ` Zhang, Qi Z

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git