* [dpdk-test-report] |WARNING| pw53568 [PATCH 10/11] net/hinic: add TX module
[not found] <1558427054-187378-1-git-send-email-xuanziyang2@huawei.com>
@ 2019-05-21 8:14 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-05-21 8:14 UTC (permalink / raw)
To: test-report; +Cc: Ziyang Xuan
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53568
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw_ci == sw_ci'
#469: FILE: drivers/net/hinic/hinic_pmd_tx.c:424:
+ if ((hw_ci == sw_ci) ||
+ (((hw_ci - sw_ci) & sq_mask) < tx_info->wqebb_cnt))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'm->pool != mbuf_free[0]->pool'
#491: FILE: drivers/net/hinic/hinic_pmd_tx.c:446:
+ if (unlikely((m->pool != mbuf_free[0]->pool) ||
+ (nb_free >= HINIC_MAX_TX_FREE_BULK))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_free >= HINIC_MAX_TX_FREE_BULK'
#491: FILE: drivers/net/hinic/hinic_pmd_tx.c:446:
+ if (unlikely((m->pool != mbuf_free[0]->pool) ||
+ (nb_free >= HINIC_MAX_TX_FREE_BULK))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'm->tso_segsz == 0'
#579: FILE: drivers/net/hinic/hinic_pmd_tx.c:534:
+ if ((m->tso_segsz == 0) ||
+ ((ol_flags & PKT_TX_IPV4) &&
+ !(ol_flags & PKT_TX_IP_CKSUM)))
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#617: FILE: drivers/net/hinic/hinic_pmd_tx.c:572:
+ rte_cpu_to_be_16(
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#715: FILE: drivers/net/hinic/hinic_pmd_tx.c:670:
+ if (eth_type == ETHER_TYPE_IPv4) {
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#725: FILE: drivers/net/hinic/hinic_pmd_tx.c:680:
+ } else if (eth_type == ETHER_TYPE_IPv6) {
total: 0 errors, 0 warnings, 7 checks, 1044 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-05-21 8:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1558427054-187378-1-git-send-email-xuanziyang2@huawei.com>
2019-05-21 8:14 ` [dpdk-test-report] |WARNING| pw53568 [PATCH 10/11] net/hinic: add TX module checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).