* [dpdk-test-report] |WARNING| pw54596 [PATCH 22/29] net/sfc/base: factor out upstream port vAdaptor allocation
[not found] <1560152324-20538-23-git-send-email-arybchenko@solarflare.com>
@ 2019-06-13 13:53 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-06-13 13:53 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54596
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#38: FILE: drivers/net/sfc/base/ef10_nic.c:2223:
+static __checkReturn efx_rc_t
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#39: FILE: drivers/net/sfc/base/ef10_nic.c:2224:
+ef10_upstream_port_vadaptor_alloc(
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rc != ENOENT'
#58: FILE: drivers/net/sfc/base/ef10_nic.c:2243:
+ if (EFX_PCI_FUNCTION_IS_PF(&enp->en_nic_cfg) ||
+ (rc != ENOENT)) {
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#87: FILE: drivers/net/sfc/base/ef10_nic.c:2272:
+ return (rc);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'enp->en_vswitchp != NULL'
#155: FILE: drivers/net/sfc/base/ef10_nic.c:2394:
+ if ((enp->en_vswitchp != NULL) && (enp->en_vswitchp->ev_evcp != NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'enp->en_vswitchp->ev_evcp != NULL'
#155: FILE: drivers/net/sfc/base/ef10_nic.c:2394:
+ if ((enp->en_vswitchp != NULL) && (enp->en_vswitchp->ev_evcp != NULL)) {
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#163: FILE: drivers/net/sfc/base/ef10_nic.c:2402:
+ if ((rc = ef10_upstream_port_vadaptor_alloc(enp)) != 0)
total: 2 errors, 0 warnings, 5 checks, 138 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-06-13 13:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1560152324-20538-23-git-send-email-arybchenko@solarflare.com>
2019-06-13 13:53 ` [dpdk-test-report] |WARNING| pw54596 [PATCH 22/29] net/sfc/base: factor out upstream port vAdaptor allocation checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).