[dpdk-test-report] |WARNING| pw87839 [PATCH v3] log: support custom log function

[dpdk-test-report] |WARNING| pw87839 [PATCH v3] log: support custom log function

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/87839

_coding style issues_


ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#130: FILE: lib/librte_eal/include/rte_log.h:116:
+rte_log_sink_set(rte_log_write_function* logf);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#162: FILE: lib/librte_eal/linux/eal_log.c:71:
+rte_log_sink_set(rte_log_write_function* logf)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: lib/librte_eal/linux/eal_log.c:73:
+    console_log_func.write = logf;$

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#171: FILE: lib/librte_eal/linux/eal_log.c:80:
+rte_log_write_function*
+rte_log_sink_get(void) {

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#173: FILE: lib/librte_eal/linux/eal_log.c:82:
+    return console_log_func.write;$

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#202: FILE: lib/librte_eal/windows/eal_log.c:23:
+rte_log_sink_set(rte_log_write_function* logf)

WARNING:RETURN_VOID: void function return statements are not generally useful
#206: FILE: lib/librte_eal/windows/eal_log.c:27:
+	return;
+}

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#211: FILE: lib/librte_eal/windows/eal_log.c:32:
+rte_log_write_function*
+rte_log_sink_get(void) {

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#213: FILE: lib/librte_eal/windows/eal_log.c:34:
+    return NULL;$

total: 5 errors, 4 warnings, 89 lines checked

[dpdk-test-report] |WARNING| pw87839 [PATCH] [v3] log: support custom log function

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 4383 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/87839

_Testing issues_

Submitter: Li Feng <fengli@smartx.com>
Date: Wednesday, February 10 2021 05:20:19 
DPDK git baseline: Repo:dpdk
  Branch: master
  CommitID:0d32fd0945d8bd235ca57b8c15463fd72ba5b8c4

87839 --> testing fail

Test environment and result as below:

+---------------------+----------------------+--------------------+-------------------+----------------+
|     Environment     | dpdk_mingw64_compile | dpdk_meson_compile | dpdk_compile_spdk | dpdk_unit_test |
+=====================+======================+====================+===================+================+
| Windows Server 2019 | PASS                 | PASS               | SKIPPED           | SKIPPED        |
+---------------------+----------------------+--------------------+-------------------+----------------+
| FreeBSD 11.2        | SKIPPED              | PASS               | SKIPPED           | SKIPPED        |
+---------------------+----------------------+--------------------+-------------------+----------------+
| CentOS 8            | SKIPPED              | PASS               | SKIPPED           | SKIPPED        |
+---------------------+----------------------+--------------------+-------------------+----------------+
| openSUSE Leap 15    | SKIPPED              | PASS               | SKIPPED           | SKIPPED        |
+---------------------+----------------------+--------------------+-------------------+----------------+
| Arch Linux          | SKIPPED              | PASS               | SKIPPED           | SKIPPED        |
+---------------------+----------------------+--------------------+-------------------+----------------+
| Fedora 31           | SKIPPED              | PASS               | FAIL              | SKIPPED        |
+---------------------+----------------------+--------------------+-------------------+----------------+
| Ubuntu 18.04 ARM    | SKIPPED              | PASS               | SKIPPED           | PASS           |
+---------------------+----------------------+--------------------+-------------------+----------------+
| Ubuntu 18.04        | SKIPPED              | PASS               | FAIL              | PASS           |
+---------------------+----------------------+--------------------+-------------------+----------------+

==== 20 line log output for Fedora 31 (dpdk_compile_spdk): ====
LINK spdk_trace_record
/usr/bin/ld.bfd: /dpdk/build/lib/librte_ethdev.a(librte_ethdev_rte_class_eth.c.o): in function `eth_mac_cmp':
rte_class_eth.c:(.text+0x1d4): undefined reference to `rte_ether_unformat_addr'
collect2: error: ld returned 1 exit status
make[2]: *** [/spdk/mk/spdk.app.mk:65: /spdk/build/bin/spdk_trace_record] Error 1
make[1]: *** [/spdk/mk/spdk.subdirs.mk:44: trace_record] Error 2
make[1]: *** Waiting for unfinished jobs....
/usr/bin/ld.bfd: /dpdk/build/lib/librte_ethdev.a(librte_ethdev_rte_class_eth.c.o): in function `eth_mac_cmp':
rte_class_eth.c:(.text+0x1d4): undefined reference to `rte_ether_unformat_addr'
collect2: error: ld returned 1 exit status
make[2]: *** [/spdk/mk/spdk.app.mk:65: /spdk/build/bin/iscsi_top] Error 1
make[1]: *** [/spdk/mk/spdk.subdirs.mk:44: iscsi_top] Error 2
/usr/bin/ld.bfd: /dpdk/build/lib/librte_ethdev.a(librte_ethdev_rte_class_eth.c.o): in function `eth_mac_cmp':
rte_class_eth.c:(.text+0x1d4): undefined reference to `rte_ether_unformat_addr'
collect2: error: ld returned 1 exit status
make[2]: *** [/spdk/mk/spdk.app.mk:65: /spdk/build/bin/nvmf_tgt] Error 1
make[1]: *** [/spdk/mk/spdk.subdirs.mk:44: nvmf_tgt] Error 2
LINK spdk_trace
make: *** [/spdk/mk/spdk.subdirs.mk:44: app] Error 2
[2] Error running command.
==== End log output ====

Windows Server 2019
	Kernel: 10.0
	Compiler: clang 9.0 and gcc 8.1.0 (MinGW)

FreeBSD 11.2
	Kernel: 11.2
	Compiler: gcc 8.3

CentOS 8
	Kernel: 4.18.0.el8_0
	Compiler: gcc 8.3.1

openSUSE Leap 15
	Kernel: 4.12.14
	Compiler: gcc 7.4.1

Arch Linux
	Kernel: latest
	Compiler: gcc latest

Fedora 31
	Kernel: 5.3.16
	Compiler: gcc 9.2.1

Ubuntu 18.04 ARM
	Kernel: 5.4.0-53-generic
	Compiler: gcc 9.3

Ubuntu 18.04
	Kernel: 4.15.0-generic
	Compiler: gcc 7.5

To view detailed results, visit:
https://lab.dpdk.org/results/dashboard/patchsets/15589/

UNH-IOL DPDK Community Lab

To manage your email subscriptions, visit: 
https://lab.dpdk.org/results/dashboard/preferences/subscriptions/