DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning
@ 2020-03-25 14:11 Kevin Traynor
  2020-03-25 14:11 ` [dpdk-dev] [RFC 1/2] meson: gcc 10 disable stringop-overflow warnings Kevin Traynor
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Kevin Traynor @ 2020-03-25 14:11 UTC (permalink / raw)
  To: dev, thomas, bruce.richardson
  Cc: ravi1.kumar, g.singh, hemant.agrawal, akhil.goyal, johndale,
	hyonkim, jingjing.wu, wenzhuo.lu, rmody, shshaikh, matan,
	shahafs, declan.doherty, cristian.dumitrescu, Kevin Traynor

This is a blunt way to remove this warning.

Some alternatives are:
- disable the warning for individual components
- components rework to statically allocate memory for parts of structs impacted

Maybe there's some other solutions?

Impacted components:
../drivers/crypto/caam_jr/caam_jr_pvt.h
../drivers/crypto/ccp/ccp_crypto.h
../drivers/crypto/dpaa_sec/dpaa_sec.h
../drivers/crypto/virtio/virtio_cryptodev.h
../drivers/net/enic/base/vnic_dev.c
../drivers/net/iavf/../../common/iavf/virtchnl.h
../drivers/net/ice/base/ice_adminq_cmd.h
../drivers/net/mlx4/mlx4_rxtx.c
../drivers/net/qede/base/ecore_mcp.c
../lib/librte_cryptodev/rte_cryptodev.h
../lib/librte_pipeline/rte_table_action.c

Full details in the Bugzilla:
https://bugs.dpdk.org/show_bug.cgi?id=421

Kevin Traynor (2):
  meson: gcc 10 disable stringop-overflow warnings
  mk: gcc 10 disable stringop-overflow warnings

 config/meson.build           | 3 ++-
 mk/toolchain/gcc/rte.vars.mk | 3 +++
 2 files changed, 5 insertions(+), 1 deletion(-)

-- 
2.21.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [RFC 1/2] meson: gcc 10 disable stringop-overflow warnings
  2020-03-25 14:11 [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning Kevin Traynor
@ 2020-03-25 14:11 ` Kevin Traynor
  2020-03-25 14:11 ` [dpdk-dev] [RFC 2/2] mk: " Kevin Traynor
  2020-03-25 14:18 ` [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning Thomas Monjalon
  2 siblings, 0 replies; 4+ messages in thread
From: Kevin Traynor @ 2020-03-25 14:11 UTC (permalink / raw)
  To: dev, thomas, bruce.richardson
  Cc: ravi1.kumar, g.singh, hemant.agrawal, akhil.goyal, johndale,
	hyonkim, jingjing.wu, wenzhuo.lu, rmody, shshaikh, matan,
	shahafs, declan.doherty, cristian.dumitrescu, Kevin Traynor

Disable this warning at the top level as it is being
raised on several components.

Bugzilla ID: 421

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
 config/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/config/meson.build b/config/meson.build
index abedd76f2..522368a29 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -200,5 +200,6 @@ warning_flags = [
 	'-Wno-address-of-packed-member',
 	'-Wno-packed-not-aligned',
-	'-Wno-missing-field-initializers'
+	'-Wno-missing-field-initializers',
+	'-Wno-stringop-overflow'
 ]
 if not dpdk_conf.get('RTE_ARCH_64')
-- 
2.21.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [RFC 2/2] mk: gcc 10 disable stringop-overflow warnings
  2020-03-25 14:11 [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning Kevin Traynor
  2020-03-25 14:11 ` [dpdk-dev] [RFC 1/2] meson: gcc 10 disable stringop-overflow warnings Kevin Traynor
@ 2020-03-25 14:11 ` " Kevin Traynor
  2020-03-25 14:18 ` [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning Thomas Monjalon
  2 siblings, 0 replies; 4+ messages in thread
From: Kevin Traynor @ 2020-03-25 14:11 UTC (permalink / raw)
  To: dev, thomas, bruce.richardson
  Cc: ravi1.kumar, g.singh, hemant.agrawal, akhil.goyal, johndale,
	hyonkim, jingjing.wu, wenzhuo.lu, rmody, shshaikh, matan,
	shahafs, declan.doherty, cristian.dumitrescu, Kevin Traynor

Disable this warning at the top level as it is being
raised on several components.

Bugzilla ID: 421

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
 mk/toolchain/gcc/rte.vars.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk
index f19305e49..fe4b8c705 100644
--- a/mk/toolchain/gcc/rte.vars.mk
+++ b/mk/toolchain/gcc/rte.vars.mk
@@ -101,4 +101,7 @@ endif
 WERROR_FLAGS += -Wno-address-of-packed-member
 
+# disable stringop-overflow warnings
+WERROR_FLAGS += -Wno-stringop-overflow
+
 export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF
 export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS
-- 
2.21.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning
  2020-03-25 14:11 [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning Kevin Traynor
  2020-03-25 14:11 ` [dpdk-dev] [RFC 1/2] meson: gcc 10 disable stringop-overflow warnings Kevin Traynor
  2020-03-25 14:11 ` [dpdk-dev] [RFC 2/2] mk: " Kevin Traynor
@ 2020-03-25 14:18 ` Thomas Monjalon
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2020-03-25 14:18 UTC (permalink / raw)
  To: Kevin Traynor
  Cc: dev, bruce.richardson, ravi1.kumar, g.singh, hemant.agrawal,
	akhil.goyal, johndale, hyonkim, jingjing.wu, wenzhuo.lu, rmody,
	shshaikh, matan, shahafs, declan.doherty, cristian.dumitrescu,
	Kevin Traynor

25/03/2020 15:11, Kevin Traynor:
> This is a blunt way to remove this warning.
> 
> Some alternatives are:
> - disable the warning for individual components
> - components rework to statically allocate memory for parts of structs impacted
> 
> Maybe there's some other solutions?

In general, I am against disabling warnings, neither globally nor specifically.
Is there a way to hide false positives without disabling the warning?

> Impacted components:
> ../drivers/crypto/caam_jr/caam_jr_pvt.h
> ../drivers/crypto/ccp/ccp_crypto.h
> ../drivers/crypto/dpaa_sec/dpaa_sec.h
> ../drivers/crypto/virtio/virtio_cryptodev.h
> ../drivers/net/enic/base/vnic_dev.c
> ../drivers/net/iavf/../../common/iavf/virtchnl.h
> ../drivers/net/ice/base/ice_adminq_cmd.h
> ../drivers/net/mlx4/mlx4_rxtx.c
> ../drivers/net/qede/base/ecore_mcp.c
> ../lib/librte_cryptodev/rte_cryptodev.h
> ../lib/librte_pipeline/rte_table_action.c
> 
> Full details in the Bugzilla:
> https://bugs.dpdk.org/show_bug.cgi?id=421

Would be easier to provide explanations here.
I think we need at least one false positive example.

> Kevin Traynor (2):
>   meson: gcc 10 disable stringop-overflow warnings
>   mk: gcc 10 disable stringop-overflow warnings

You don't need to split in 2 patches.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 14:11 [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning Kevin Traynor
2020-03-25 14:11 ` [dpdk-dev] [RFC 1/2] meson: gcc 10 disable stringop-overflow warnings Kevin Traynor
2020-03-25 14:11 ` [dpdk-dev] [RFC 2/2] mk: " Kevin Traynor
2020-03-25 14:18 ` [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning Thomas Monjalon

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox