* [PATCH] devtools: fix version variable not initialized
@ 2024-04-17 9:32 Dengdui Huang
2024-06-27 14:28 ` David Marchand
0 siblings, 1 reply; 4+ messages in thread
From: Dengdui Huang @ 2024-04-17 9:32 UTC (permalink / raw)
To: dev; +Cc: bruce.richardson, fengchengwen, haijie1, lihuisong, liuyonglong
The version variable is not initialized. Therefore, if the -V option
is not specified, the value of $version is obtained from the context,
which may cause the version map parsing failure.
Fixes: 6edec7f202ac ("devtools: list symbols by version")
Cc: stable@dpdk.org
Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
---
buildtools/map-list-symbol.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/buildtools/map-list-symbol.sh b/buildtools/map-list-symbol.sh
index bc3b8d766f..43f276c05f 100755
--- a/buildtools/map-list-symbol.sh
+++ b/buildtools/map-list-symbol.sh
@@ -5,6 +5,7 @@
section=all
symbol=all
quiet=
+version=
while getopts 'S:s:qV:' name; do
case $name in
--
2.33.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] devtools: fix version variable not initialized
2024-04-17 9:32 [PATCH] devtools: fix version variable not initialized Dengdui Huang
@ 2024-06-27 14:28 ` David Marchand
2024-06-28 6:55 ` huangdengdui
2024-07-09 4:51 ` David Marchand
0 siblings, 2 replies; 4+ messages in thread
From: David Marchand @ 2024-06-27 14:28 UTC (permalink / raw)
To: Dengdui Huang
Cc: dev, bruce.richardson, fengchengwen, haijie1, lihuisong, liuyonglong
On Wed, Apr 17, 2024 at 11:32 AM Dengdui Huang <huangdengdui@huawei.com> wrote:
>
> The version variable is not initialized. Therefore, if the -V option
> is not specified, the value of $version is obtained from the context,
> which may cause the version map parsing failure.
>
> Fixes: 6edec7f202ac ("devtools: list symbols by version")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
This is an internal script and I wonder how the mentionned issue is hit.
In any case this fix is correct.
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] devtools: fix version variable not initialized
2024-06-27 14:28 ` David Marchand
@ 2024-06-28 6:55 ` huangdengdui
2024-07-09 4:51 ` David Marchand
1 sibling, 0 replies; 4+ messages in thread
From: huangdengdui @ 2024-06-28 6:55 UTC (permalink / raw)
To: David Marchand
Cc: dev, bruce.richardson, fengchengwen, haijie1, lihuisong, liuyonglong
On 2024/6/27 22:28, David Marchand wrote:
> On Wed, Apr 17, 2024 at 11:32 AM Dengdui Huang <huangdengdui@huawei.com> wrote:
>>
>> The version variable is not initialized. Therefore, if the -V option
>> is not specified, the value of $version is obtained from the context,
>> which may cause the version map parsing failure.
>>
>> Fixes: 6edec7f202ac ("devtools: list symbols by version")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
>
> This is an internal script and I wonder how the mentionned issue is hit.
> In any case this fix is correct.
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
>
>
Thanks for your review.
The project build script may pass version information through environment variables.
This problem occurs if the following execution sequence exists:
export version=devel
meson build
ninja -C build
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] devtools: fix version variable not initialized
2024-06-27 14:28 ` David Marchand
2024-06-28 6:55 ` huangdengdui
@ 2024-07-09 4:51 ` David Marchand
1 sibling, 0 replies; 4+ messages in thread
From: David Marchand @ 2024-07-09 4:51 UTC (permalink / raw)
To: Dengdui Huang
Cc: dev, bruce.richardson, fengchengwen, haijie1, lihuisong, liuyonglong
On Thu, Jun 27, 2024 at 4:28 PM David Marchand
<david.marchand@redhat.com> wrote:
> On Wed, Apr 17, 2024 at 11:32 AM Dengdui Huang <huangdengdui@huawei.com> wrote:
> >
> > The version variable is not initialized. Therefore, if the -V option
> > is not specified, the value of $version is obtained from the context,
> > which may cause the version map parsing failure.
> >
> > Fixes: 6edec7f202ac ("devtools: list symbols by version")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-09 4:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17 9:32 [PATCH] devtools: fix version variable not initialized Dengdui Huang
2024-06-27 14:28 ` David Marchand
2024-06-28 6:55 ` huangdengdui
2024-07-09 4:51 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).