DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v1 1/1] net/qede: fix redundant condition in debug code
@ 2021-11-30 16:59 Anatoly Burakov
  2022-01-10  7:19 ` Jerin Jacob
  2022-01-10  8:43 ` [EXT] " Rasesh Mody
  0 siblings, 2 replies; 6+ messages in thread
From: Anatoly Burakov @ 2021-11-30 16:59 UTC (permalink / raw)
  To: dev, Rasesh Mody, Devendra Singh Rawat, Igor Russkikh; +Cc: stable

Expression "a && 1" is equivalent to just "a", so fix the accidental
inclusion of a literal in code.

Cc: stable@dpdk.org

Fixes: ec55c118792b ("net/qede: add infrastructure for debug data collection")
Cc: rmody@marvell.com

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---

Notes:
    This isn't a bug, this is just a syntactic anomaly, likely a remnant of some
    kind of debugging code.
    
    This issue was found with Control Flag [1], which i ran on DPDK codebase just
    out of curiosity. This was the only issue worth addressing that the tool
    produced output for.
    
    [1] https://github.com/IntelLabs/control-flag

 drivers/net/qede/qede_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/qede/qede_debug.c b/drivers/net/qede/qede_debug.c
index 2297d245c4..ba807ea680 100644
--- a/drivers/net/qede/qede_debug.c
+++ b/drivers/net/qede/qede_debug.c
@@ -3522,7 +3522,7 @@ static enum dbg_status qed_grc_dump(struct ecore_hwfn *p_hwfn,
 
 	/* Dump MCP HW Dump */
 	if (qed_grc_is_included(p_hwfn, DBG_GRC_PARAM_DUMP_MCP_HW_DUMP) &&
-	    !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP) && 1)
+	    !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP))
 		offset += qed_grc_dump_mcp_hw_dump(p_hwfn,
 						   p_ptt,
 						   dump_buf + offset, dump);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-01-11 12:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-30 16:59 [PATCH v1 1/1] net/qede: fix redundant condition in debug code Anatoly Burakov
2022-01-10  7:19 ` Jerin Jacob
2022-01-10  7:35   ` [EXT] " Devendra Singh Rawat
2022-01-10  8:15   ` Igor Russkikh
2022-01-10  8:43 ` [EXT] " Rasesh Mody
2022-01-11 12:04   ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).