RE: [PATCH] net/gve: fix bug in verify driver compatibility

["Guo, Junfeng" <junfeng.guo@intel.com>]

> -----Original Message-----
> From: Rushil Gupta <rushilg@google.com>
> Sent: Thursday, June 1, 2023 12:50
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; ferruh.yigit@amd.com
> Cc: Guo, Junfeng <junfeng.guo@intel.com>; dev@dpdk.org; Rushil Gupta
> <rushilg@google.com>
> Subject: [PATCH] net/gve: fix bug in verify driver compatibility
> 
> gVNIC requires physical address to be passed in the adminq command.
> This was initially rightly pointed by ferruh.yigit@.
> Fixed by passing 'driver_info_mem->iova'.

For bug fixing, it is required to reference the id of the commit which introduced the bug.
You can generate the required lines using the following git alias:
''' git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'"  '''
and then put the output of ''' git fixline <SHA> ''' into the commit message.

And also be CCed to the stable@dpdk.org mailing list. Thanks!

Regards,
Junfeng

> 
> Signed-off-by: Rushil Gupta <rushilg@google.com>
> ---
>  drivers/net/gve/gve_ethdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
> index 2c1e73d07a..aa75abe102 100644
> --- a/drivers/net/gve/gve_ethdev.c
> +++ b/drivers/net/gve/gve_ethdev.c
> @@ -276,7 +276,8 @@ gve_verify_driver_compatibility(struct gve_priv
> *priv)
>  			(char *)driver_info->os_version_str2);
> 
>  	err = gve_adminq_verify_driver_compatibility(priv,
> -		sizeof(struct gve_driver_info), (dma_addr_t)driver_info);
> +		sizeof(struct gve_driver_info),
> +		(dma_addr_t)driver_info_mem->iova);
>  	/* It's ok if the device doesn't support this */
>  	if (err == -EOPNOTSUPP)
>  		err = 0;
> --
> 2.41.0.rc2.161.g9c6817b8e7-goog