DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Rushil Gupta <rushilg@google.com>, qi.z.zhang@intel.com
Cc: junfeng.guo@intel.com, dev@dpdk.org
Subject: Re: [PATCH] net/gve: fix bug in verify driver compatibility
Date: Thu, 1 Jun 2023 11:24:27 +0100	[thread overview]
Message-ID: <660baf37-53e9-6274-1cef-9beea3f69f8c@amd.com> (raw)
In-Reply-To: <859b86f2-888f-b60b-b10e-d83d3a37fe7e@amd.com>

On 6/1/2023 9:26 AM, Ferruh Yigit wrote:
> On 6/1/2023 5:49 AM, Rushil Gupta wrote:
>> gVNIC requires physical address to be passed in the adminq command.
>> This was initially rightly pointed by ferruh.yigit@.
>> Fixed by passing 'driver_info_mem->iova'.
>>
>> Signed-off-by: Rushil Gupta <rushilg@google.com>
>> ---
>>  drivers/net/gve/gve_ethdev.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
>> index 2c1e73d07a..aa75abe102 100644
>> --- a/drivers/net/gve/gve_ethdev.c
>> +++ b/drivers/net/gve/gve_ethdev.c
>> @@ -276,7 +276,8 @@ gve_verify_driver_compatibility(struct gve_priv *priv)
>>  			(char *)driver_info->os_version_str2);
>>  
>>  	err = gve_adminq_verify_driver_compatibility(priv,
>> -		sizeof(struct gve_driver_info), (dma_addr_t)driver_info);
>> +		sizeof(struct gve_driver_info),
>> +		(dma_addr_t)driver_info_mem->iova);
>>
> 
> Yep, this was my point, let me squashed onto original patch in next-net.
> 
> 

Squashed into relevant commit in next-net, thanks.
Can you please verify latest code in next-net?

  reply	other threads:[~2023-06-01 10:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01  3:15 Rushil Gupta
2023-06-01  4:49 ` Rushil Gupta
2023-06-01  6:44   ` Guo, Junfeng
2023-06-01  8:35     ` Ferruh Yigit
2023-06-01  8:58       ` Guo, Junfeng
2023-06-01  8:26   ` Ferruh Yigit
2023-06-01 10:24     ` Ferruh Yigit [this message]
2023-06-01 16:32       ` Rushil Gupta
2023-06-02 14:49         ` Ferruh Yigit
2023-06-02 21:44           ` Rushil Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=660baf37-53e9-6274-1cef-9beea3f69f8c@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=dev@dpdk.org \
    --cc=junfeng.guo@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=rushilg@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).