From: Rushil Gupta <rushilg@google.com>
To: qi.z.zhang@intel.com, ferruh.yigit@amd.com
Cc: junfeng.guo@intel.com, dev@dpdk.org, Rushil Gupta <rushilg@google.com>
Subject: [PATCH] net/gve: fix bug in verify driver compatibility
Date: Thu, 1 Jun 2023 03:15:13 +0000 [thread overview]
Message-ID: <20230601031513.453016-1-rushilg@google.com> (raw)
gVNIC requires physical address to be passed in the adminq command.
This was initially rightly pointed by ferruh.yigit@.
Fixed by passing 'driver_info_mem->iova'.
Signed-off-by: Rushil Gupta <rushilg@google.com>
---
drivers/net/gve/gve_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
index 2c1e73d07a..1c5ce930a4 100644
--- a/drivers/net/gve/gve_ethdev.c
+++ b/drivers/net/gve/gve_ethdev.c
@@ -276,7 +276,8 @@ gve_verify_driver_compatibility(struct gve_priv *priv)
(char *)driver_info->os_version_str2);
err = gve_adminq_verify_driver_compatibility(priv,
- sizeof(struct gve_driver_info), (dma_addr_t)driver_info);
+ sizeof(struct gve_driver_info),
+ (dma_addr_t)driver_info_mem->iova);
/* It's ok if the device doesn't support this */
if (err == -EOPNOTSUPP)
err = 0;
--
2.41.0.rc2.161.g9c6817b8e7-goog
next reply other threads:[~2023-06-01 3:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 3:15 Rushil Gupta [this message]
2023-06-01 4:49 ` Rushil Gupta
2023-06-01 6:44 ` Guo, Junfeng
2023-06-01 8:35 ` Ferruh Yigit
2023-06-01 8:58 ` Guo, Junfeng
2023-06-01 8:26 ` Ferruh Yigit
2023-06-01 10:24 ` Ferruh Yigit
2023-06-01 16:32 ` Rushil Gupta
2023-06-02 14:49 ` Ferruh Yigit
2023-06-02 21:44 ` Rushil Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601031513.453016-1-rushilg@google.com \
--to=rushilg@google.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=junfeng.guo@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).