[dts] [PATCH V1] tests/ipfrag:Modify the way to get the core.

[dts] [PATCH V1] tests/ipfrag:Modify the way to get the core.

[zhu,shuai]

Some platforms have a core number less than a fixed value.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_ipfrag.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_ipfrag.py b/tests/TestSuite_ipfrag.py
index 3a9ffb8..139917c 100644
--- a/tests/TestSuite_ipfrag.py
+++ b/tests/TestSuite_ipfrag.py
@@ -92,7 +92,7 @@ class TestIpfrag(TestCase):
         self.ports_socket = self.dut.get_numa_id(ports[0])
 
         # Verify that enough threads are available
-        cores = self.dut.get_core_list("2S/2C/2T")
+        cores = self.dut.get_core_list("all")
         self.verify(cores is not None, "Insufficient cores for speed testing")
 
         global P0, P1
-- 
2.17.2

Re: [dts] [PATCH V1] tests/ipfrag:Modify the way to get the core.

[Rami Rosen]

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

Hi, Zhu,

> Some platforms have a core number less than a fixed value.

Thanks for this patch. You are right, obviously there are platforms with
other combinations than
"2S/2C/2T", and actually I myself run DTS on diifferent platforms than this
and had some issues related to it with various DTS test modules.

 I have a question, though,if I may:
On which platform ( i mean which combination of socket/core/thread in that
platform) did the solution of using cores = self.dut.get_core_listst("all")
instead of the  hard coded "2S/2C/2T" worked  for you for this ipfrag Test
Module?

And a general question to DTS developers/maintainer:  all the DTS test
suites use hard coded values for the S/C/T combination. And obviously this
will fail on certain platforms. Wouldn't it be reasonable to replace all
these occurrences with self.dut.get_core_listst("all") ? Will
self.dut.get_core_listst("all") always work, for any combination of
socket/core/thread ? Will this work for 2S/4C/2T ?

Regards,
Rami Rosen

[-- Attachment #2: Type: text/html, Size: 2297 bytes --]

Re: [dts] [PATCH V1] tests/ipfrag:Modify the way to get the core.

[Zhu, ShuaiX]

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

I think that using the all parameter should be possible in the current code. Some platforms have fewer core values than fixed values. For example, using 2S/4C/2T, the following error occurs: Cannot get requested core configuration requested 2S/4C/2T have.

From: Rami Rosen [mailto:ramirose@gmail.com]
Sent: Thursday, January 24, 2019 9:54 AM
To: Zhu, ShuaiX <shuaix.zhu@intel.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH V1] tests/ipfrag:Modify the way to get the core.

Hi, Zhu,

> Some platforms have a core number less than a fixed value.

Thanks for this patch. You are right, obviously there are platforms with other combinations than
"2S/2C/2T", and actually I myself run DTS on diifferent platforms than this and had some issues related to it with various DTS test modules.

 I have a question, though,if I may:
On which platform ( i mean which combination of socket/core/thread in that platform) did the solution of using cores = self.dut.get_core_listst("all") instead of the  hard coded "2S/2C/2T" worked  for you for this ipfrag Test Module?

And a general question to DTS developers/maintainer:  all the DTS test suites use hard coded values for the S/C/T combination. And obviously this will fail on certain platforms. Wouldn't it be reasonable to replace all these occurrences with self.dut.get_core_listst("all") ? Will self.dut.get_core_listst("all") always work, for any combination of socket/core/thread ? Will this work for 2S/4C/2T ?

Regards,
Rami Rosen

[-- Attachment #2: Type: text/html, Size: 5892 bytes --]

Re: [dts] [PATCH V1] tests/ipfrag:Modify the way to get the core.

[Tu, Lijuan]

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

The main tactic of get_core_list() is if system core less than your request, it will give you all cores.

Thanks for your feedback, I will go through it ,  and figure out the issue.




From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Rami Rosen
Sent: Thursday, January 24, 2019 9:54 AM
To: Zhu, ShuaiX <shuaix.zhu@intel.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH V1] tests/ipfrag:Modify the way to get the core.

Hi, Zhu,

> Some platforms have a core number less than a fixed value.

Thanks for this patch. You are right, obviously there are platforms with other combinations than
"2S/2C/2T", and actually I myself run DTS on diifferent platforms than this and had some issues related to it with various DTS test modules.

 I have a question, though,if I may:
On which platform ( i mean which combination of socket/core/thread in that platform) did the solution of using cores = self.dut.get_core_listst("all") instead of the  hard coded "2S/2C/2T" worked  for you for this ipfrag Test Module?

And a general question to DTS developers/maintainer:  all the DTS test suites use hard coded values for the S/C/T combination. And obviously this will fail on certain platforms. Wouldn't it be reasonable to replace all these occurrences with self.dut.get_core_listst("all") ? Will self.dut.get_core_listst("all") always work, for any combination of socket/core/thread ? Will this work for 2S/4C/2T ?

Regards,
Rami Rosen

[-- Attachment #2: Type: text/html, Size: 6027 bytes --]