[dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous mode

[dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous mode

[Rosen Xu]

v5 updates:
===========
 - Modificate some comments for this patch

v4 updates:
===========
 - Add some comments for this patch

v3 updates:
===========
 - Move modification from device close to device disable
 - i40evf_reset_vf() will cause kernel driver enable all vlan promiscuous,
   so unicast/multicast promiscuous disable should set before reset.

v2 updates:
===========
 - Add more comments

In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit
doesn't disable promiscuous mode, this will cause vlan filter set by
Kernel Driver will not take effect.

This patch will fix it, add promiscuous disable at device disable.

Fixes: 4861cde46116 ("i40e: new poll mode driver")
Cc: stable@dpdk.org

Signed-off-by: Rosen Xu <rosen.xu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 48e7ac2..b8977a6 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2288,6 +2288,14 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 
 	i40evf_dev_stop(dev);
 	i40e_dev_free_queues(dev);
+	/*
+	 * disable promiscuous mode before reset vf
+	 * it fixes missing disable promiscuous mode
+	 * when work with kernel dirver bug issue
+	 */
+	i40evf_dev_promiscuous_disable(dev);
+	i40evf_dev_allmulticast_disable(dev);
+
 	i40evf_reset_vf(hw);
 	i40e_shutdown_adminq(hw);
 	/* disable uio intr before callback unregister */
-- 
1.8.3.1

[dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous mode

[Rosen Xu]

v5 updates:
===========
 - Modificate some comments for this patch

v4 updates:
===========
 - Add some comments for this patch

v3 updates:
===========
 - Move modification from device close to device disable
 - i40evf_reset_vf() will cause kernel driver enable all vlan promiscuous,
   so unicast/multicast promiscuous disable should set before reset.

v2 updates:
===========
 - Add more comments

In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit
doesn't disable promiscuous mode, this will cause vlan filter set by
Kernel Driver will not take effect.

This patch will fix it, add promiscuous disable at device disable.

Fixes: 4861cde46116 ("i40e: new poll mode driver")
Cc: stable@dpdk.org

Signed-off-by: Rosen Xu <rosen.xu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 48e7ac2..b8977a6 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2288,6 +2288,14 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 
 	i40evf_dev_stop(dev);
 	i40e_dev_free_queues(dev);
+	/*
+	 * disable promiscuous mode before reset vf
+	 * it fixes missing disable promiscuous mode
+	 * when work with kernel dirver bug issue
+	 */
+	i40evf_dev_promiscuous_disable(dev);
+	i40evf_dev_allmulticast_disable(dev);
+
 	i40evf_reset_vf(hw);
 	i40e_shutdown_adminq(hw);
 	/* disable uio intr before callback unregister */
-- 
1.8.3.1

Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous mode

[Luca Boccassi]

On Sat, 2018-04-28 at 19:37 +0800, Rosen Xu wrote:
> v5 updates:
> ===========
>  - Modificate some comments for this patch
> 
> v4 updates:
> ===========
>  - Add some comments for this patch
> 
> v3 updates:
> ===========
>  - Move modification from device close to device disable
>  - i40evf_reset_vf() will cause kernel driver enable all vlan
> promiscuous,
>    so unicast/multicast promiscuous disable should set before reset.
> 
> v2 updates:
> ===========
>  - Add more comments
> 
> In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit
> doesn't disable promiscuous mode, this will cause vlan filter set by
> Kernel Driver will not take effect.
> 
> This patch will fix it, add promiscuous disable at device disable.
> 
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Has this or a version of this fix been committed to mainline?

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous mode

[Xu, Rosen]

> -----Original Message-----
> From: Luca Boccassi [mailto:bluca@debian.org]
> Sent: Monday, April 30, 2018 9:43 PM
> To: Xu, Rosen
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous
> mode
> 
> On Sat, 2018-04-28 at 19:37 +0800, Rosen Xu wrote:
> > v5 updates:
> > ===========
> >  - Modificate some comments for this patch
> >
> > v4 updates:
> > ===========
> >  - Add some comments for this patch
> >
> > v3 updates:
> > ===========
> >  - Move modification from device close to device disable
> >  - i40evf_reset_vf() will cause kernel driver enable all vlan
> > promiscuous,
> >    so unicast/multicast promiscuous disable should set before reset.
> >
> > v2 updates:
> > ===========
> >  - Add more comments
> >
> > In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit
> > doesn't disable promiscuous mode, this will cause vlan filter set by
> > Kernel Driver will not take effect.
> >
> > This patch will fix it, add promiscuous disable at device disable.
> >
> > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> Has this or a version of this fix been committed to mainline?

Do you means to commit to Kernel Driver?

> --
> Kind regards,
> Luca Boccassi

Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous mode

[Xu, Rosen]

> -----Original Message-----
> From: Luca Boccassi [mailto:bluca@debian.org]
> Sent: Monday, April 30, 2018 21:43
> To: Xu, Rosen <rosen.xu@intel.com>
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous
> mode
> 
> On Sat, 2018-04-28 at 19:37 +0800, Rosen Xu wrote:
> > v5 updates:
> > ===========
> >  - Modificate some comments for this patch
> >
> > v4 updates:
> > ===========
> >  - Add some comments for this patch
> >
> > v3 updates:
> > ===========
> >  - Move modification from device close to device disable
> >  - i40evf_reset_vf() will cause kernel driver enable all vlan
> > promiscuous,
> >    so unicast/multicast promiscuous disable should set before reset.
> >
> > v2 updates:
> > ===========
> >  - Add more comments
> >
> > In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit
> > doesn't disable promiscuous mode, this will cause vlan filter set by
> > Kernel Driver will not take effect.
> >
> > This patch will fix it, add promiscuous disable at device disable.
> >
> > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> Has this or a version of this fix been committed to mainline?

I have submit the patch, the action of merging this patch is belongs to maintainer.
Do you think so?

> --
> Kind regards,
> Luca Boccassi

Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous mode

[Luca Boccassi]

On Tue, 2018-05-01 at 13:27 +0000, Xu, Rosen wrote:
> > -----Original Message-----
> > From: Luca Boccassi [mailto:bluca@debian.org]
> > Sent: Monday, April 30, 2018 21:43
> > To: Xu, Rosen <rosen.xu@intel.com>
> > Cc: stable@dpdk.org
> > Subject: Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling
> > promiscuous
> > mode
> > 
> > On Sat, 2018-04-28 at 19:37 +0800, Rosen Xu wrote:
> > > v5 updates:
> > > ===========
> > >  - Modificate some comments for this patch
> > > 
> > > v4 updates:
> > > ===========
> > >  - Add some comments for this patch
> > > 
> > > v3 updates:
> > > ===========
> > >  - Move modification from device close to device disable
> > >  - i40evf_reset_vf() will cause kernel driver enable all vlan
> > > promiscuous,
> > >    so unicast/multicast promiscuous disable should set before
> > > reset.
> > > 
> > > v2 updates:
> > > ===========
> > >  - Add more comments
> > > 
> > > In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD
> > > exit
> > > doesn't disable promiscuous mode, this will cause vlan filter set
> > > by
> > > Kernel Driver will not take effect.
> > > 
> > > This patch will fix it, add promiscuous disable at device
> > > disable.
> > > 
> > > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > > Cc: stable@dpdk.org
> > > 
> > > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> > 
> > Has this or a version of this fix been committed to mainline?
> 
> I have submit the patch, the action of merging this patch is belongs
> to maintainer.
> Do you think so?

Yes - the reason I ask is because the process we follow for the stable
releases is to tag commits that are backported with the commit ID of
the patch that was merged into dpdk/master, for tracking.
And also, for patches that to into dpdk/master, we wait to merge until
the version to dpdk/master is merged first.

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous mode

[Xu, Rosen]

> -----Original Message-----
> From: Luca Boccassi [mailto:bluca@debian.org]
> Sent: Tuesday, May 01, 2018 21:52
> To: Xu, Rosen <rosen.xu@intel.com>
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous
> mode
> 
> On Tue, 2018-05-01 at 13:27 +0000, Xu, Rosen wrote:
> > > -----Original Message-----
> > > From: Luca Boccassi [mailto:bluca@debian.org]
> > > Sent: Monday, April 30, 2018 21:43
> > > To: Xu, Rosen <rosen.xu@intel.com>
> > > Cc: stable@dpdk.org
> > > Subject: Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling
> > > promiscuous mode
> > >
> > > On Sat, 2018-04-28 at 19:37 +0800, Rosen Xu wrote:
> > > > v5 updates:
> > > > ===========
> > > >  - Modificate some comments for this patch
> > > >
> > > > v4 updates:
> > > > ===========
> > > >  - Add some comments for this patch
> > > >
> > > > v3 updates:
> > > > ===========
> > > >  - Move modification from device close to device disable
> > > >  - i40evf_reset_vf() will cause kernel driver enable all vlan
> > > > promiscuous,
> > > >    so unicast/multicast promiscuous disable should set before
> > > > reset.
> > > >
> > > > v2 updates:
> > > > ===========
> > > >  - Add more comments
> > > >
> > > > In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD
> > > > exit doesn't disable promiscuous mode, this will cause vlan filter
> > > > set by Kernel Driver will not take effect.
> > > >
> > > > This patch will fix it, add promiscuous disable at device disable.
> > > >
> > > > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > > > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> > >
> > > Has this or a version of this fix been committed to mainline?
> >
> > I have submit the patch, the action of merging this patch is belongs
> > to maintainer.
> > Do you think so?
> 
> Yes - the reason I ask is because the process we follow for the stable releases
> is to tag commits that are backported with the commit ID of the patch that
> was merged into dpdk/master, for tracking.
> And also, for patches that to into dpdk/master, we wait to merge until the
> version to dpdk/master is merged first.

+Maintainers

> --
> Kind regards,
> Luca Boccassi